aboutsummaryrefslogtreecommitdiff
path: root/.gitignore
diff options
context:
space:
mode:
authoreldritch horrors <pennae@lix.systems>2024-05-26 17:45:36 +0200
committereldritch horrors <pennae@lix.systems>2024-05-26 20:57:09 +0000
commited6b3165ea3de4e1dda93ce0f23ff61079e4fe0b (patch)
tree3794ddaac97871be3bb82ed5c9e847e4311c3cbb /.gitignore
parent742c62a6eb3d5411a0ab748387060c28ca16a25a (diff)
worker: process timeouts first, and exclusively
check goals for timeouts first, and their activity fds only if no timeout has occurred. checking for timeouts *after* activity sets us up for assertion failures by running multiple build completion notifiers, the first of which will kill/reap the the goal process and consuming the Pid instance. when the second notifier attempts to do the same it will core dump with an assertion failure in Pid and take down not only the single goal, but the entire daemon and all goals it was building. luckily this is rare in practice since it requires a build to both finish and time out at the same time. writing a test for this is not feasible due to how much it relies on scheduling to actually trigger the underlying bug, but on idle machines it can usually be triggered by running multiple sleeping builds with timeout set to the sleep duration and `--keep-going`: nix-build --timeout 10 --builders '' --keep-going -E ' with import <nixpkgs> {}; builtins.genList (i: runCommand "foo-${toString i}" {} "sleep 10") 100 ' Change-Id: I394d36b2e5ffb909cf8a19977d569bbdb71cb67b
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions