aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Burdette <bburdette@gmail.com>2020-05-06 15:01:13 -0600
committerBen Burdette <bburdette@gmail.com>2020-05-06 15:01:13 -0600
commite3901638b50d91ddc9c356adc35ded00a00fe94b (patch)
treeb51a141c3da9a3c24ca7173b993dd0b7f35d6465
parente76ad2e48a71aa9804311f4dfb34374a5295b3b6 (diff)
todo removal
-rw-r--r--src/error-demo/error-demo.cc1
-rw-r--r--src/libstore/gc.cc1
-rw-r--r--src/nix-daemon/nix-daemon.cc1
-rw-r--r--src/nix/upgrade-nix.cc2
4 files changed, 0 insertions, 5 deletions
diff --git a/src/error-demo/error-demo.cc b/src/error-demo/error-demo.cc
index b1b313e32..0d3dcf616 100644
--- a/src/error-demo/error-demo.cc
+++ b/src/error-demo/error-demo.cc
@@ -23,7 +23,6 @@ int main()
logger->logEI(e.info());
}
-
// ErrorInfo constructor
try {
auto e = Error("some error");
diff --git a/src/libstore/gc.cc b/src/libstore/gc.cc
index 4f6f78a99..629c4360c 100644
--- a/src/libstore/gc.cc
+++ b/src/libstore/gc.cc
@@ -41,7 +41,6 @@ AutoCloseFD LocalStore::openGCLock(LockType lockType)
throw SysError("opening global GC lock '%1%'", fnGCLock);
if (!lockFile(fdGCLock.get(), lockType, false)) {
- // TODO: info?
printError("waiting for the big garbage collector lock...");
lockFile(fdGCLock.get(), lockType, true);
}
diff --git a/src/nix-daemon/nix-daemon.cc b/src/nix-daemon/nix-daemon.cc
index 5336db136..731ab22e5 100644
--- a/src/nix-daemon/nix-daemon.cc
+++ b/src/nix-daemon/nix-daemon.cc
@@ -247,7 +247,6 @@ static void daemonLoop(char * * argv)
} catch (Interrupted & e) {
return;
} catch (Error & error) {
- // TODO append error message
ErrorInfo ei = error.info();
string prevhint = (error.info().hint.has_value() ? error.info().hint->str() : "");
ei.hint = std::optional(hintfmt("error processing connection: %1%", prevhint));
diff --git a/src/nix/upgrade-nix.cc b/src/nix/upgrade-nix.cc
index 8f4e529bc..831a83fd1 100644
--- a/src/nix/upgrade-nix.cc
+++ b/src/nix/upgrade-nix.cc
@@ -64,13 +64,11 @@ struct CmdUpgradeNix : MixDryRun, StoreCommand
if (dryRun) {
stopProgressBar();
- // TODO change to info?
logWarning(
ErrorInfo {
.name = "Version update",
.hint = hintfmt("would upgrade to version %s", version)
});
- // printError("would upgrade to version %s", version);
return;
}