diff options
author | Eelco Dolstra <edolstra@gmail.com> | 2019-09-02 17:50:44 +0200 |
---|---|---|
committer | Eelco Dolstra <edolstra@gmail.com> | 2019-09-02 17:50:44 +0200 |
commit | aeb695c0074b52772057b36f442a054f8d1a856d (patch) | |
tree | 7576c5adb8a00b61791fb435fe55aa28974a3be5 | |
parent | c693f80b814c244dcdae7a2e87fb9e444d9d1ca5 (diff) |
Remove obsolete OpenSSL locking code
OpenSSL 1.1.1 no longer needs this (https://github.com/openssl/openssl/commit/2e52e7df518d80188c865ea3f7bb3526d14b0c08).
This shuts up a clang warning about opensslLockCallback being unused.
-rw-r--r-- | src/libmain/shared.cc | 20 | ||||
-rw-r--r-- | src/libutil/hash.cc | 4 |
2 files changed, 4 insertions, 20 deletions
diff --git a/src/libmain/shared.cc b/src/libmain/shared.cc index 0afddfb78..910549583 100644 --- a/src/libmain/shared.cc +++ b/src/libmain/shared.cc @@ -15,8 +15,6 @@ #include <unistd.h> #include <signal.h> -#include <openssl/crypto.h> - namespace nix { @@ -80,20 +78,6 @@ string getArg(const string & opt, } -/* OpenSSL is not thread-safe by default - it will randomly crash - unless the user supplies a mutex locking function. So let's do - that. */ -static std::vector<std::mutex> opensslLocks; - -static void opensslLockCallback(int mode, int type, const char * file, int line) -{ - if (mode & CRYPTO_LOCK) - opensslLocks[type].lock(); - else - opensslLocks[type].unlock(); -} - - static void sigHandler(int signo) { } @@ -105,10 +89,6 @@ void initNix() std::cerr.rdbuf()->pubsetbuf(buf, sizeof(buf)); #endif - /* Initialise OpenSSL locking. */ - opensslLocks = std::vector<std::mutex>(CRYPTO_num_locks()); - CRYPTO_set_locking_callback(opensslLockCallback); - loadConfFile(); startSignalHandlerThread(); diff --git a/src/libutil/hash.cc b/src/libutil/hash.cc index 1c14ebb18..362c537fe 100644 --- a/src/libutil/hash.cc +++ b/src/libutil/hash.cc @@ -13,6 +13,10 @@ #include <sys/stat.h> #include <fcntl.h> +#if OPENSSL_VERSION_NUMBER < 0x10101000L +#error "Unsupported version of OpenSSL, you need at least 1.1.1" +#endif + namespace nix { |