aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThéophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>2023-01-13 10:53:40 +0100
committerGitHub <noreply@github.com>2023-01-13 10:53:40 +0100
commitdda71d3726a1767dbd4674cde6e130093e290183 (patch)
tree436fe648af8a26a55df878e091ec5a1a1207110b
parenteaa20f25747eb025c7c4e69fa83f0e455a65393f (diff)
parent7de8af526e196f16b757289b41cde65ccd68f4e8 (diff)
Merge pull request #7427 from fricklerhandwerk/pr-policy
state priorities in triaging and discussion process
-rw-r--r--maintainers/README.md34
1 files changed, 31 insertions, 3 deletions
diff --git a/maintainers/README.md b/maintainers/README.md
index 60768db0a..08d197c1b 100644
--- a/maintainers/README.md
+++ b/maintainers/README.md
@@ -36,17 +36,45 @@ Issues on the board progress through the following states:
- No Status
- Team members can add pull requests or issues to discuss or review together.
-
During the discussion meeting, the team triages new items.
+ To be considered, issues and pull requests must have a high-level description to provide the whole team with the necessary context at a glance.
+
+ On every meeting, at least one item from each of the following categories is inspected:
+
+ 1. [critical](https://github.com/NixOS/nix/labels/critical)
+ 2. [security](https://github.com/NixOS/nix/labels/security)
+ 3. [regression](https://github.com/NixOS/nix/labels/regression)
+ 4. [bug](https://github.com/NixOS/nix/issues?q=is%3Aopen+label%3Abug+sort%3Areactions-%2B1-desc)
+
+ - [oldest pull requests](https://github.com/NixOS/nix/pulls?q=is%3Apr+is%3Aopen+sort%3Acreated-asc)
+ - [most popular pull requests](https://github.com/NixOS/nix/pulls?q=is%3Apr+is%3Aopen+sort%3Areactions-%2B1-desc)
+ - [oldest issues](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+sort%3Acreated-asc)
+ - [most popular issues](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc)
+
+ Team members can also add pull requests or issues they would like the whole team to consider.
+
If there is disagreement on the general idea behind an issue or pull request, it is moved to _To discuss_, otherwise to _In review_.
- To discuss
- Pull requests and issues that are important and controversial are discussed by the team during discussion meetings.
+ Pull requests and issues that are deemed important and controversial are discussed by the team during discussion meetings.
This may be where the merit of the change itself or the implementation strategy is contested by a team member.
+ As a general guideline, the order of items is determined as follows:
+
+ - Prioritise pull requests over issues
+
+ Contributors who took the time to implement concrete change proposals should not wait indefinitely.
+
+ - Prioritise fixing bugs over documentation, improvements or new features
+
+ The team values stability and accessibility higher than raw functionality.
+
+ - Interleave issues and PRs
+
+ This way issues without attempts at a solution get a chance to get addressed.
+
- In review
Pull requests in this column are reviewed together during work meetings.