Merge pull request #8895 from hercules-ci/gc-before-stats

eval: Run a full GC before printing stats

(cherry picked from commit aeea49609be014b1928c95b7ec28dbedeb4f032a)
Change-Id: I47a23d3a7a47ea61d9a2b5727b638f879f3aaf1e

1 files changed, 18 insertions, 2 deletions

diff --git a/src/libexpr/eval.hh b/src/libexpr/eval.hh
index 553cbe4fd..42dd73d11 100644
--- a/src/libexpr/eval.hh
+++ b/src/libexpr/eval.hh
@@ -709,9 +709,25 @@ public:
     void concatLists(Value & v, size_t nrLists, Value * * lists, const PosIdx pos, std::string_view errorCtx);
 
     /**
-     * Print statistics.
+     * Print statistics, if enabled.
+     *
+     * Performs a full memory GC before printing the statistics, so that the
+     * GC statistics are more accurate.
+     */
+    void maybePrintStats();
+
+    /**
+     * Print statistics, unconditionally, cheaply, without performing a GC first.
+     */
+    void printStatistics();
+
+    /**
+     * Perform a full memory garbage collection - not incremental.
+     *
+     * @return true if Nix was built with GC and a GC was performed, false if not.
+     *              The return value is currently not thread safe - just the return value.
      */
-    void printStats();
+    bool fullGC();
 
     /**
      * Realise the given context, and return a mapping from the placeholders