aboutsummaryrefslogtreecommitdiff
path: root/src/libstore/build/derivation-goal.hh
diff options
context:
space:
mode:
authoreldritch horrors <pennae@lix.systems>2024-05-01 23:12:56 +0200
committereldritch horrors <pennae@lix.systems>2024-05-03 00:50:31 +0000
commitd55b158e24fd4b56c6d8017626a4db7d6f56dd1f (patch)
tree7cfa9727851c1b20e14dcdfdbfcb60820f43746a /src/libstore/build/derivation-goal.hh
parent076dfd30c6167cfb8f5003a36baef4438f687782 (diff)
libutil: make rewriteStrings sound
this is used in CA rewriting, replacement of placeholders in derivations, generating scripts for devShells, and some more places. in all of these transitive replacements are unsound, and overlapping replacements would be as well. there even is a test that transitive replacements do not happen (in the CA RewriteSink suite), but none for overlapping replacements. a minimally surprising binary rewriter surely would not do any of these replacements, the only reason we have not seen this break yet is probably that rewriteStrings is only called for store paths and things that look like store paths (and those should never overlap nor admit such transitive replacements) Change-Id: I6fc29f939d5061d9f56c752624a823ece8437c07
Diffstat (limited to 'src/libstore/build/derivation-goal.hh')
0 files changed, 0 insertions, 0 deletions