diff options
| author | Jade Lovelace <lix@jade.fyi> | 2024-06-15 13:10:03 -0700 |
|---|---|---|
| committer | jade <lix@jade.fyi> | 2024-06-18 23:29:08 +0000 |
| commit | 66a9fbb7ffa781f46e246de08700739fa775650c (patch) | |
| tree | 26fae72b695169b7c758f8203f0d658cf6a414ee /src/libstore/build/sandbox-defaults.sb | |
| parent | b9b1bbd22fc3b34a4d8e2090f0d033f742c32ee0 (diff) | |
libstore: fix queryValidPaths concurrency
The lock usage was obviously wrong so it was entirely serialized. This
has the predicted speedups, the only question is whether it is sound
because it's exposing a bunch of new code to actual concurrency.
I did audit all the stores' queryPathInfoUncached implementations and
they all look *intended* to be thread safe, but whether that is actually
sound or not: lol lmao. I am highly confident in the s3 one because it
is calling s3 sdk methods that are thread safe and has no actual state.
Others are using Pool and look to be *supposed* to be thread safe, but
unsure if they actually are.
Change-Id: I0369152a510e878b5ac56c9ac956a98d48cd5fef
Diffstat (limited to 'src/libstore/build/sandbox-defaults.sb')
0 files changed, 0 insertions, 0 deletions