diff options
| author | Eelco Dolstra <edolstra@gmail.com> | 2023-02-03 11:55:37 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-03 11:55:37 +0100 |
| commit | dbe0748f970a86911aae2cb6b603dfb8b541f8d9 (patch) | |
| tree | 80e3f83e7412020c4b5905f4d3e32c7a886140ff /src/libstore/daemon.cc | |
| parent | 1647354d6b640b7341fba0c94d3dfb6b06355b2d (diff) | |
| parent | a47e055e090a85884413dfc7889897f4e3d831fb (diff) | |
Merge pull request #7739 from obsidiansystems/user-settings
Move `trustedUsers` and `allowedUsers` to separate config struct
Diffstat (limited to 'src/libstore/daemon.cc')
| -rw-r--r-- | src/libstore/daemon.cc | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/src/libstore/daemon.cc b/src/libstore/daemon.cc index d1f69fe2d..5e6fd011f 100644 --- a/src/libstore/daemon.cc +++ b/src/libstore/daemon.cc @@ -529,7 +529,14 @@ static void performOp(TunnelLogger * logger, ref<Store> store, mode = (BuildMode) readInt(from); /* Repairing is not atomic, so disallowed for "untrusted" - clients. */ + clients. + + FIXME: layer violation in this message: the daemon code (i.e. + this file) knows whether a client/connection is trusted, but it + does not how how the client was authenticated. The mechanism + need not be getting the UID of the other end of a Unix Domain + Socket. + */ if (mode == bmRepair && !trusted) throw Error("repairing is not allowed because you are not in 'trusted-users'"); } @@ -546,7 +553,9 @@ static void performOp(TunnelLogger * logger, ref<Store> store, mode = (BuildMode) readInt(from); /* Repairing is not atomic, so disallowed for "untrusted" - clients. */ + clients. + + FIXME: layer violation; see above. */ if (mode == bmRepair && !trusted) throw Error("repairing is not allowed because you are not in 'trusted-users'"); |