diff options
author | John Ericson <John.Ericson@Obsidian.Systems> | 2023-04-14 18:18:32 -0400 |
---|---|---|
committer | John Ericson <John.Ericson@Obsidian.Systems> | 2023-04-15 12:51:19 -0400 |
commit | 24866b71c40f0fcb5a601d90d4f87366fe626090 (patch) | |
tree | 6aef97ef7c0e00d463256ba6c876fb6e50a843f5 /src/libstore/remote-fs-accessor.hh | |
parent | 0f2b5146c79895ac10362b6da56b535fc3d963a4 (diff) |
Introduce `SingleDrvOutputs`
In many cases we are dealing with a collection of realisations, they are
all outputs of the same derivation. In that case, we don't need
"derivation hashes modulos" to be part of our map key, because the
output names alone will be unique. Those hashes are still part of the
realisation proper, so we aren't loosing any information, we're just
"normalizing our schema" by narrowing the "primary key".
Besides making our data model a bit "tighter" this allows us to avoid a
double `for` loop in `DerivationGoal::waiteeDone`. The inner `for` loop
was previously just to select the output we cared about without knowing
its hash. Now we can just select the output by name directly.
Note that neither protocol is changed as part of this: we are still
transferring `DrvOutputs` over the wire for `BuildResult`s. I would only
consider revising this once #6223 is merged, and we can mention protocol
versions inside factored-out serialization logic. Until then it is
better not change anything because it would come a the cost of code
reuse.
Diffstat (limited to 'src/libstore/remote-fs-accessor.hh')
0 files changed, 0 insertions, 0 deletions