aboutsummaryrefslogtreecommitdiff
path: root/src/libstore
diff options
context:
space:
mode:
authorDan Peebles <pumpkin@me.com>2017-04-10 09:28:44 -0400
committerDan Peebles <pumpkin@me.com>2017-04-10 09:28:44 -0400
commitd1fdade75562d711ec62e9cdf953f2a6b0e891ce (patch)
treec65d534da2c66ed6e7edcf3b13bfb69f73c24260 /src/libstore
parent53edb55588e362ee6aa8f6b436c6db6b0409b615 (diff)
Add CURLE_WRITE_ERROR as a transient error condition
We've observed it failing downloads in the wild and retrying the same URL a few moments later seemed to fix it.
Diffstat (limited to 'src/libstore')
-rw-r--r--src/libstore/download.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/libstore/download.cc b/src/libstore/download.cc
index d1f760fdc..f8f578695 100644
--- a/src/libstore/download.cc
+++ b/src/libstore/download.cc
@@ -300,6 +300,11 @@ struct CurlDownloader : public Downloader
|| httpStatus == 504 || httpStatus == 522 || httpStatus == 524
|| code == CURLE_COULDNT_RESOLVE_HOST
|| code == CURLE_RECV_ERROR
+
+ // this seems to occur occasionally for retriable reasons, and shows up in an error like this:
+ // curl: (23) Failed writing body (315 != 16366)
+ || code == CURLE_WRITE_ERROR
+
// this is a generic SSL failure that in some cases (e.g., certificate error) is permanent but also appears in transient cases, so we consider it retryable
|| code == CURLE_SSL_CONNECT_ERROR
#if LIBCURL_VERSION_NUM >= 0x073200