aboutsummaryrefslogtreecommitdiff
path: root/src/libutil/file-descriptor.hh
diff options
context:
space:
mode:
authoreldritch horrors <pennae@lix.systems>2024-08-09 21:17:52 +0200
committereldritch horrors <pennae@lix.systems>2024-08-09 19:59:17 +0000
commitc7d97802e4f59b8621e67cf62275d6a7fde8fe62 (patch)
tree8798b34ab28dd2b704da20a21659de2ad24fda07 /src/libutil/file-descriptor.hh
parent35a2f28a46613ad185b96d6e38c3f5d13bfc79b5 (diff)
libutil: rename and optimize closeMostFDs
this is only used to close non-stdio files in derivation sandboxes. we may as well encode that in its name, drop the unnecessary integer set, and use close_range to deal with the actual closing of files. not only is this clearer, it also makes sandbox setup on linux fast by 1ms each Change-Id: Id90e259a49c7bc896189e76bfbbf6ef2c0bcd3b2
Diffstat (limited to 'src/libutil/file-descriptor.hh')
-rw-r--r--src/libutil/file-descriptor.hh4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libutil/file-descriptor.hh b/src/libutil/file-descriptor.hh
index a83bc028f..7270b73b5 100644
--- a/src/libutil/file-descriptor.hh
+++ b/src/libutil/file-descriptor.hh
@@ -66,10 +66,10 @@ public:
};
/**
- * Close all file descriptors except those listed in the given set.
+ * Close all file descriptors except stdio fds (ie 0, 1, 2).
* Good practice in child processes.
*/
-void closeMostFDs(const std::set<int> & exceptions);
+void closeExtraFDs();
/**
* Set the close-on-exec flag for the given file descriptor.