Merge remote-tracking branch 'upstream/master' into hash-always-has-type

4 files changed, 13 insertions, 10 deletions

diff --git a/src/nix/develop.cc b/src/nix/develop.cc
index a6d7d6add..2f590f53f 100644
--- a/src/nix/develop.cc
+++ b/src/nix/develop.cc
@@ -130,14 +130,16 @@ StorePath getDerivationEnvironment(ref<Store> store, const StorePath & drvPath)
     drvName += "-env";
     for (auto & output : drv.outputs)
         drv.env.erase(output.first);
-    drv.outputs = {{"out", DerivationOutput { .path = StorePath::dummy }}};
+    drv.outputs = {{"out", DerivationOutput { .output = DerivationOutputInputAddressed { .path = StorePath::dummy }}}};
     drv.env["out"] = "";
     drv.env["_outputs_saved"] = drv.env["outputs"];
     drv.env["outputs"] = "out";
     drv.inputSrcs.insert(std::move(getEnvShPath));
     Hash h = hashDerivationModulo(*store, drv, true);
     auto shellOutPath = store->makeOutputPath("out", h, drvName);
-    drv.outputs.insert_or_assign("out", DerivationOutput { .path = shellOutPath });
+    drv.outputs.insert_or_assign("out", DerivationOutput { .output = DerivationOutputInputAddressed {
+                .path = shellOutPath
+            } });
     drv.env["out"] = store->printStorePath(shellOutPath);
     auto shellDrvPath2 = writeDerivation(store, drv, drvName);
 
diff --git a/src/nix/installables.cc b/src/nix/installables.cc
index ab17aaa47..72aae7ef7 100644
--- a/src/nix/installables.cc
+++ b/src/nix/installables.cc
@@ -304,8 +304,9 @@ struct InstallableStorePath : Installable
     {
         if (storePath.isDerivation()) {
             std::map<std::string, StorePath> outputs;
-            for (auto & [name, output] : store->readDerivation(storePath).outputs)
-                outputs.emplace(name, output.path);
+            auto drv = store->readDerivation(storePath);
+            for (auto & [name, output] : drv.outputs)
+                outputs.emplace(name, output.path(*store, drv.name));
             return {
                 Buildable {
                     .drvPath = storePath,
diff --git a/src/nix/repl.cc b/src/nix/repl.cc
index 8eb58f62a..fb9050d0d 100644
--- a/src/nix/repl.cc
+++ b/src/nix/repl.cc
@@ -483,10 +483,10 @@ bool NixRepl::processLine(string line)
                but doing it in a child makes it easier to recover from
                problems / SIGINT. */
             if (runProgram(settings.nixBinDir + "/nix", Strings{"build", "--no-link", drvPath}) == 0) {
-                auto drv = readDerivation(*state->store, drvPath);
+                auto drv = readDerivation(*state->store, drvPath, Derivation::nameFromPath(state->store->parseStorePath(drvPath)));
                 std::cout << std::endl << "this derivation produced the following outputs:" << std::endl;
                 for (auto & i : drv.outputs)
-                    std::cout << fmt("  %s -> %s\n", i.first, state->store->printStorePath(i.second.path));
+                    std::cout << fmt("  %s -> %s\n", i.first, state->store->printStorePath(i.second.path(*state->store, drv.name)));
             }
         } else if (command == ":i") {
             runProgram(settings.nixBinDir + "/nix-env", Strings{"-i", drvPath});
diff --git a/src/nix/show-derivation.cc b/src/nix/show-derivation.cc
index b5434f982..9fd26e2d7 100644
--- a/src/nix/show-derivation.cc
+++ b/src/nix/show-derivation.cc
@@ -69,10 +69,10 @@ struct CmdShowDerivation : InstallablesCommand
                 auto outputsObj(drvObj.object("outputs"));
                 for (auto & output : drv.outputs) {
                     auto outputObj(outputsObj.object(output.first));
-                    outputObj.attr("path", store->printStorePath(output.second.path));
-                    if (output.second.hash) {
-                        outputObj.attr("hashAlgo", output.second.hash->printMethodAlgo());
-                        outputObj.attr("hash", output.second.hash->hash.to_string(Base16, false));
+                    outputObj.attr("path", store->printStorePath(output.second.path(*store, drv.name)));
+                    if (auto hash = std::get_if<DerivationOutputFixed>(&output.second.output)) {
+                        outputObj.attr("hashAlgo", hash->hash.printMethodAlgo());
+                        outputObj.attr("hash", hash->hash.hash.to_string(Base16, false));
                     }
                 }
             }