diff options
author | Robert Hensing <robert@roberthensing.nl> | 2022-11-15 17:57:40 +0100 |
---|---|---|
committer | Robert Hensing <robert@roberthensing.nl> | 2022-11-15 17:57:40 +0100 |
commit | bcd298d39bffbb1a79ae5ce2c4eec8c45fa9f2a0 (patch) | |
tree | b75c70f09516dc13b1c6d3edea696ebd5c31d2d9 /src | |
parent | 4bf70b74a78bf10f3f19ed122ae7377963e14003 (diff) |
libstore/derivation-goal: Elaborate a TODO for performance concern
Diffstat (limited to 'src')
-rw-r--r-- | src/libstore/build/derivation-goal.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/libstore/build/derivation-goal.cc b/src/libstore/build/derivation-goal.cc index 00e375fe9..2f22dbcec 100644 --- a/src/libstore/build/derivation-goal.cc +++ b/src/libstore/build/derivation-goal.cc @@ -538,7 +538,8 @@ void DerivationGoal::inputsRealised() However, the impure derivations feature still relies on this fragile way of doing things, because its builds do not have a representation in the store, which is a usability problem - in itself */ + in itself. When implementing this logic entirely with lookups + make sure that they're cached. */ if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) { worker.store.computeFSClosure(*outPath, inputPaths); } |