diff options
| author | Eelco Dolstra <edolstra@gmail.com> | 2018-06-01 14:14:22 +0200 |
|---|---|---|
| committer | Eelco Dolstra <edolstra@gmail.com> | 2018-06-01 14:14:22 +0200 |
| commit | 73357500aca2ad4a2d82111993fbd5aaf0af4ec6 (patch) | |
| tree | 1a29541c85aa2ed7f8997b8a99348145b73972b7 /src | |
| parent | f0d9909f108b2f8bffaf65743e283e773204b62f (diff) | |
Improve binary cache upload messages
Don't say "download" when we mean "upload".
Diffstat (limited to 'src')
| -rw-r--r-- | src/libstore/download.cc | 18 | ||||
| -rw-r--r-- | src/libstore/http-binary-cache-store.cc | 2 |
2 files changed, 15 insertions, 5 deletions
diff --git a/src/libstore/download.cc b/src/libstore/download.cc index 72a08ef00..0b768b591 100644 --- a/src/libstore/download.cc +++ b/src/libstore/download.cc @@ -102,7 +102,9 @@ struct CurlDownloader : public Downloader Callback<DownloadResult> callback) : downloader(downloader) , request(request) - , act(*logger, lvlTalkative, actDownload, fmt("downloading '%s'", request.uri), {request.uri}, request.parentAct) + , act(*logger, lvlTalkative, actDownload, + fmt(request.data ? "uploading '%s'" : "downloading '%s'", request.uri), + {request.uri}, request.parentAct) , callback(callback) { if (!request.expectedETag.empty()) @@ -371,12 +373,20 @@ struct CurlDownloader : public Downloader attempt++; + auto verb = request.data ? "upload" : "download"; + auto exc = code == CURLE_ABORTED_BY_CALLBACK && _isInterrupted - ? DownloadError(Interrupted, format("download of '%s' was interrupted") % request.uri) + ? DownloadError(Interrupted, fmt("%s of '%s' was interrupted", verb, request.uri)) : httpStatus != 0 - ? DownloadError(err, format("unable to download '%s': HTTP error %d (curl error: %s)") % request.uri % httpStatus % curl_easy_strerror(code)) - : DownloadError(err, format("unable to download '%s': %s (%d)") % request.uri % curl_easy_strerror(code) % code); + ? DownloadError(err, + fmt("unable to %s '%s': HTTP error %d", + verb, request.uri, httpStatus) + + (code == CURLE_OK ? "" : fmt(" (curl error: %s)", curl_easy_strerror(code))) + ) + : DownloadError(err, + fmt("unable to %s '%s': %s (%d)", + verb, request.uri, curl_easy_strerror(code), code)); /* If this is a transient error, then maybe retry the download after a while. */ diff --git a/src/libstore/http-binary-cache-store.cc b/src/libstore/http-binary-cache-store.cc index 6fdae40e3..ab524d523 100644 --- a/src/libstore/http-binary-cache-store.cc +++ b/src/libstore/http-binary-cache-store.cc @@ -73,7 +73,7 @@ protected: try { getDownloader()->download(req); } catch (DownloadError & e) { - throw UploadToHTTP(format("uploading to HTTP binary cache at %1% not supported: %2%") % cacheUri % e.msg()); + throw UploadToHTTP("while uploading to HTTP binary cache at '%s': %s", cacheUri, e.msg()); } } |