diff options
author | John Ericson <John.Ericson@Obsidian.Systems> | 2021-01-15 16:37:41 +0000 |
---|---|---|
committer | John Ericson <John.Ericson@Obsidian.Systems> | 2021-01-15 16:37:41 +0000 |
commit | 7af743470c09b835f910d2e25786c080ccfe52c1 (patch) | |
tree | 5d91f16367e376c75d3e93923fd9786191c20ea5 /tests/function-trace.sh | |
parent | 0027b05a15e5845c5ce70c86b5b1a34e7caff039 (diff) |
Make public keys and `requireSigs` local-store specific again
Thanks @regnat and @edolstra for catching this and comming up with the
solution.
They way I had generalized those is wrong, because local settings for
non-local stores is confusing default. And due to the nature of C++
inheritance, fixing the defaults is more annoying than it should be.
Additionally, I thought we might just drop the check in the substitution
logic since `Store::addToStore` is now streaming, but @regnat rightfully
pointed out that as it downloads dependencies first, that would still be
too late, and also waste effort on possibly unneeded/unwanted
dependencies.
The simple and correct thing to do is just make a store method for the
boolean logic, keeping all the setting and key stuff the way it was
before. That new method is both used by `LocalStore::addToStore` and the
substitution goal check. Perhaps we might eventually make it fancier,
e.g. sending the ValidPathInfo to remote stores for them to validate,
but this is good enough for now.
Diffstat (limited to 'tests/function-trace.sh')
0 files changed, 0 insertions, 0 deletions