diff options
author | John Ericson <John.Ericson@Obsidian.Systems> | 2020-06-18 17:54:16 +0000 |
---|---|---|
committer | John Ericson <John.Ericson@Obsidian.Systems> | 2020-06-18 17:54:16 +0000 |
commit | 639e20dc3ed9c5b28138285653912de78fe0507f (patch) | |
tree | 5f89c2b9814c729c0b63da212a0c70904b40097d /tests/shell.shebang.rb | |
parent | 6c000eed80565d83d596da800ca0db92e248342e (diff) |
Prevent '%' in URL from causing crashes
We have a larger problem that passsing computed strings to the first
variable argument of many exception constructors is unsafe because that
first variable argument is interpreted not as a plain string, but format
string, and if it contains '%' boost::format will abort, since there are
no arguments to the format string.
In this particular instance '%' was used as part of an escape code in a
URL, which, when the download failed, caused Nix to abort displaying the
`FileTransferError`.
Diffstat (limited to 'tests/shell.shebang.rb')
0 files changed, 0 insertions, 0 deletions