diff options
| author | eldritch horrors <pennae@lix.systems> | 2024-05-18 02:35:34 +0200 |
|---|---|---|
| committer | eldritch horrors <pennae@lix.systems> | 2024-07-16 00:57:42 +0000 |
| commit | a5d1f698417dff4e470eb94c38ad6c4e5ebf38ff (patch) | |
| tree | 116b887a80fd96f9008bc55c872a24ef1955ca2f /tests/unit | |
| parent | 5271424d14241ec5cbe7ab3bda85ddeb486cff76 (diff) | |
libstore: generatorize protocol serializers
this is cursed. deeply and profoundly cursed. under NO CIRCUMSTANCES
must protocol serializer helpers be applied to temporaries! doing so
will inevitably cause dangling references and cause the entire thing
to crash. we need to do this even so to get rid of boost coroutines,
and likewise to encapsulate the serializers we suffer today at least
a little bit to allow a gradual migration to an actual IPC protocol.
(this isn't a problem that's unique to generators. c++ coroutines in
general cannot safely take references to arbitrary temporaries since
c++ does not have a lifetime system that can make this safe. -sigh-)
Change-Id: I2921ba451e04d86798752d140885d3c5cc08e146
Diffstat (limited to 'tests/unit')
| -rw-r--r-- | tests/unit/libstore/common-protocol.cc | 2 | ||||
| -rw-r--r-- | tests/unit/libstore/protocol.hh | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tests/unit/libstore/common-protocol.cc b/tests/unit/libstore/common-protocol.cc index a820cb1c2..1d25f81c7 100644 --- a/tests/unit/libstore/common-protocol.cc +++ b/tests/unit/libstore/common-protocol.cc @@ -50,7 +50,7 @@ public: auto file = goldenMaster(testStem); StringSink to; - CommonProto::write( + to << CommonProto::write( *store, CommonProto::WriteConn { .to = to }, value); diff --git a/tests/unit/libstore/protocol.hh b/tests/unit/libstore/protocol.hh index f480f4ad1..269c9f7aa 100644 --- a/tests/unit/libstore/protocol.hh +++ b/tests/unit/libstore/protocol.hh @@ -56,7 +56,7 @@ public: auto file = ProtoTest<Proto, protocolDir>::goldenMaster(testStem); StringSink to; - Proto::write( + to << Proto::write( *LibStoreTest::store, typename Proto::WriteConn {to, version}, value); |