aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--.github/PULL_REQUEST_TEMPLATE.md28
-rw-r--r--doc/manual/src/command-ref/nix-store.md23
-rw-r--r--doc/manual/src/glossary.md25
-rw-r--r--doc/manual/src/language/index.md4
-rw-r--r--doc/manual/src/language/operators.md4
5 files changed, 67 insertions, 17 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 000000000..a268d7caf
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,28 @@
+# Motivation
+<!-- Briefly explain what the change is about and why it is desirable. -->
+
+# Context
+<!-- Provide context. Reference open issues if available. -->
+
+<!-- Non-trivial change: Briefly outline the implementation strategy. -->
+
+<!-- Invasive change: Discuss alternative designs or approaches you considered. -->
+
+<!-- Large change: Provide instructions to reviewers how to read the diff. -->
+
+# Checklist for maintainers
+
+<!-- Contributors: please leave this as is -->
+
+Maintainers: tick if completed or explain if not relevant
+
+ - [ ] agreed on idea
+ - [ ] agreed on implementation strategy
+ - [ ] tests, as appropriate
+ - functional tests - `tests/**.sh`
+ - unit tests - `src/*/tests`
+ - integration tests
+ - [ ] documentation in the manual
+ - [ ] code and comments are self-explanatory
+ - [ ] commit message explains why the change was made
+ - [ ] new feature or bug fix: updated release notes
diff --git a/doc/manual/src/command-ref/nix-store.md b/doc/manual/src/command-ref/nix-store.md
index 6d0e02ca5..f6017481c 100644
--- a/doc/manual/src/command-ref/nix-store.md
+++ b/doc/manual/src/command-ref/nix-store.md
@@ -66,11 +66,11 @@ The operation `--realise` essentially “builds” the specified store
paths. Realisation is a somewhat overloaded term:
- If the store path is a *derivation*, realisation ensures that the
- output paths of the derivation are [valid](../glossary.md) (i.e.,
+ output paths of the derivation are [valid] (i.e.,
the output path and its closure exist in the file system). This
can be done in several ways. First, it is possible that the
outputs are already valid, in which case we are done
- immediately. Otherwise, there may be [substitutes](../glossary.md)
+ immediately. Otherwise, there may be [substitutes]
that produce the outputs (e.g., by downloading them). Finally, the
outputs can be produced by running the build task described
by the derivation.
@@ -82,6 +82,9 @@ paths. Realisation is a somewhat overloaded term:
produced through substitutes. If there are no (successful)
substitutes, realisation fails.
+[valid]: ../glossary.md#validity
+[substitutes]: ../glossary.md#substitute
+
The output path of each derivation is printed on standard output. (For
non-derivations argument, the argument itself is printed.)
@@ -295,8 +298,8 @@ error: cannot delete path `/nix/store/zq0h41l75vlb4z45kzgjjmsjxvcv1qk7-mesa-6.4'
## Description
-The operation `--query` displays various bits of information about the
-store paths . The queries are described below. At most one query can be
+The operation `--query` displays information about [store path]s.
+The queries are described below. At most one query can be
specified. The default query is `--outputs`.
The paths *paths* may also be symlinks from outside of the Nix store, to
@@ -316,12 +319,12 @@ symlink.
## Queries
- `--outputs`\
- Prints out the [output paths](../glossary.md) of the store
+ Prints out the [output path]s of the store
derivations *paths*. These are the paths that will be produced when
the derivation is built.
- `--requisites`; `-R`\
- Prints out the [closure](../glossary.md) of the store path *paths*.
+ Prints out the [closure] of the given *paths*.
This query has one option:
@@ -338,10 +341,12 @@ symlink.
derivation and specifying the option `--include-outputs`.
- `--references`\
- Prints the set of [references](../glossary.md) of the store paths
+ Prints the set of [references]s of the store paths
*paths*, that is, their immediate dependencies. (For *all*
dependencies, use `--requisites`.)
+ [reference]: ../glossary.md#gloss-reference
+
- `--referrers`\
Prints the set of *referrers* of the store paths *paths*, that is,
the store paths currently existing in the Nix store that refer to
@@ -356,11 +361,13 @@ symlink.
in the Nix store that are dependent on *paths*.
- `--deriver`; `-d`\
- Prints the [deriver](../glossary.md) of the store paths *paths*. If
+ Prints the [deriver] of the store paths *paths*. If
the path has no deriver (e.g., if it is a source file), or if the
deriver is not known (e.g., in the case of a binary-only
deployment), the string `unknown-deriver` is printed.
+ [deriver]: ../glossary.md#gloss-deriver
+
- `--graph`\
Prints the references graph of the store paths *paths* in the format
of the `dot` tool of AT\&T's [Graphviz
diff --git a/doc/manual/src/glossary.md b/doc/manual/src/glossary.md
index e63f6becc..5a49af8dc 100644
--- a/doc/manual/src/glossary.md
+++ b/doc/manual/src/glossary.md
@@ -19,6 +19,17 @@
[store derivation]: #gloss-store-derivation
+ - [realise]{#gloss-realise}, realisation\
+ Ensure a [store path] is [valid][validity].
+
+ This means either running the `builder` executable as specified in the corresponding [derivation] or fetching a pre-built [store object] from a [substituter].
+
+ See [`nix-build`](./command-ref/nix-build.md) and [`nix-store --realise`](./command-ref/nix-store.md#operation---realise).
+
+ See [`nix build`](./command-ref/new-cli/nix3-build.md) (experimental).
+
+ [realise]: #gloss-realise
+
- [content-addressed derivation]{#gloss-content-addressed-derivation}\
A derivation which has the
[`__contentAddressed`](./language/advanced-attributes.md#adv-attr-__contentAddressed)
@@ -101,6 +112,8 @@
copy store objects it doesn't have. For details, see the
[`substituters` option](./command-ref/conf-file.md#conf-substituters).
+ [substituter]: #gloss-substituter
+
- [purity]{#gloss-purity}\
The assumption that equal Nix derivations when run always produce
the same output. This cannot be guaranteed in general (e.g., a
@@ -149,13 +162,15 @@
[output path]: #gloss-output-path
- [deriver]{#gloss-deriver}\
- The deriver of an *output path* is the store
- derivation that built it.
+ The [store derivation] that produced an [output path].
- [validity]{#gloss-validity}\
- A store path is considered *valid* if it exists in the file system,
- is listed in the Nix database as being valid, and if all paths in
- its closure are also valid.
+ A store path is valid if all [store object]s in its [closure] can be read from the [store].
+
+ For a local store, this means:
+ - The store path leads to an existing [store object] in that [store].
+ - The store path is listed in the Nix database as being valid.
+ - All paths in the store path's [closure] are valid.
- [user environment]{#gloss-user-env}\
An automatically generated store object that consists of a set of
diff --git a/doc/manual/src/language/index.md b/doc/manual/src/language/index.md
index db34fde75..31300631c 100644
--- a/doc/manual/src/language/index.md
+++ b/doc/manual/src/language/index.md
@@ -191,12 +191,12 @@ This is an incomplete overview of language features, by example.
<tr>
<td>
- <nixpkgs>
+ `<nixpkgs>`
</td>
<td>
- Search path. Value determined by [`$NIX_PATH` environment variable](../command-ref/env-common.md#env-NIX_PATH).
+ Search path for Nix files. Value determined by [`$NIX_PATH` environment variable](../command-ref/env-common.md#env-NIX_PATH).
</td>
</tr>
diff --git a/doc/manual/src/language/operators.md b/doc/manual/src/language/operators.md
index a287b513f..1f918bd4d 100644
--- a/doc/manual/src/language/operators.md
+++ b/doc/manual/src/language/operators.md
@@ -124,8 +124,8 @@ The result is a string.
Update [attribute set] *attrset1* with names and values from *attrset2*.
-The returned attribute set will have of all the attributes in *e1* and *e2*.
-If an attribute name is present in both, the attribute value from the former is taken.
+The returned attribute set will have of all the attributes in *attrset1* and *attrset2*.
+If an attribute name is present in both, the attribute value from the latter is taken.
[Update]: #update