aboutsummaryrefslogtreecommitdiff
path: root/src/libstore
diff options
context:
space:
mode:
Diffstat (limited to 'src/libstore')
-rw-r--r--src/libstore/machines.cc17
-rw-r--r--src/libstore/machines.hh2
2 files changed, 15 insertions, 4 deletions
diff --git a/src/libstore/machines.cc b/src/libstore/machines.cc
index 0aa497357..f808b8592 100644
--- a/src/libstore/machines.cc
+++ b/src/libstore/machines.cc
@@ -33,11 +33,14 @@ Machine::Machine(decltype(storeUri) storeUri,
systemTypes(systemTypes),
sshKey(sshKey),
maxJobs(maxJobs),
- speedFactor(std::max(1U, speedFactor)),
+ speedFactor(speedFactor == 0.0f ? 1.0f : std::move(speedFactor)),
supportedFeatures(supportedFeatures),
mandatoryFeatures(mandatoryFeatures),
sshPublicHostKey(sshPublicHostKey)
-{}
+{
+ if (speedFactor < 0.0)
+ throw UsageError("speed factor must be >= 0");
+}
bool Machine::systemSupported(const std::string & system) const
{
@@ -136,6 +139,14 @@ static Machine parseBuilderLine(const std::string & line)
return result.value();
};
+ auto parseFloatField = [&](size_t fieldIndex) {
+ const auto result = string2Int<float>(tokens[fieldIndex]);
+ if (!result) {
+ throw FormatError("bad machine specification: failed to convert column #%lu in a row: '%s' to 'float'", fieldIndex, line);
+ }
+ return result.value();
+ };
+
auto ensureBase64 = [&](size_t fieldIndex) {
const auto & str = tokens[fieldIndex];
try {
@@ -154,7 +165,7 @@ static Machine parseBuilderLine(const std::string & line)
isSet(1) ? tokenizeString<std::set<std::string>>(tokens[1], ",") : std::set<std::string>{settings.thisSystem},
isSet(2) ? tokens[2] : "",
isSet(3) ? parseUnsignedIntField(3) : 1U,
- isSet(4) ? parseUnsignedIntField(4) : 1U,
+ isSet(4) ? parseFloatField(4) : 1.0f,
isSet(5) ? tokenizeString<std::set<std::string>>(tokens[5], ",") : std::set<std::string>{},
isSet(6) ? tokenizeString<std::set<std::string>>(tokens[6], ",") : std::set<std::string>{},
isSet(7) ? ensureBase64(7) : ""
diff --git a/src/libstore/machines.hh b/src/libstore/machines.hh
index 1bca74c28..8516409d4 100644
--- a/src/libstore/machines.hh
+++ b/src/libstore/machines.hh
@@ -13,7 +13,7 @@ struct Machine {
const std::set<std::string> systemTypes;
const std::string sshKey;
const unsigned int maxJobs;
- const unsigned int speedFactor;
+ const float speedFactor;
const std::set<std::string> supportedFeatures;
const std::set<std::string> mandatoryFeatures;
const std::string sshPublicHostKey;