aboutsummaryrefslogtreecommitdiff
path: root/src/nix-env/nix-env.cc
diff options
context:
space:
mode:
Diffstat (limited to 'src/nix-env/nix-env.cc')
-rw-r--r--src/nix-env/nix-env.cc22
1 files changed, 11 insertions, 11 deletions
diff --git a/src/nix-env/nix-env.cc b/src/nix-env/nix-env.cc
index fdac7e69a..6dda34a32 100644
--- a/src/nix-env/nix-env.cc
+++ b/src/nix-env/nix-env.cc
@@ -203,15 +203,15 @@ static void loadDerivations(EvalState & state, const SourcePath & nixExprPath,
}
-static long getPriority(EvalState & state, DrvInfo & drv)
+static NixInt getPriority(EvalState & state, DrvInfo & drv)
{
- return drv.queryMetaInt("priority", 0);
+ return drv.queryMetaInt("priority", NixInt(0));
}
-static long comparePriorities(EvalState & state, DrvInfo & drv1, DrvInfo & drv2)
+static std::strong_ordering comparePriorities(EvalState & state, DrvInfo & drv1, DrvInfo & drv2)
{
- return getPriority(state, drv2) - getPriority(state, drv1);
+ return getPriority(state, drv2) <=> getPriority(state, drv1);
}
@@ -279,7 +279,7 @@ std::vector<Match> pickNewestOnly(EvalState & state, std::vector<Match> matches)
auto & oneDrv = match.drvInfo;
const auto drvName = DrvName { oneDrv.queryName() };
- long comparison = 1;
+ std::strong_ordering comparison = std::strong_ordering::greater;
const auto itOther = newest.find(drvName.name);
@@ -287,9 +287,9 @@ std::vector<Match> pickNewestOnly(EvalState & state, std::vector<Match> matches)
auto & newestDrv = itOther->second.drvInfo;
comparison =
- oneDrv.querySystem() == newestDrv.querySystem() ? 0 :
- oneDrv.querySystem() == settings.thisSystem ? 1 :
- newestDrv.querySystem() == settings.thisSystem ? -1 : 0;
+ oneDrv.querySystem() == newestDrv.querySystem() ? std::strong_ordering::equal :
+ oneDrv.querySystem() == settings.thisSystem ? std::strong_ordering::greater :
+ newestDrv.querySystem() == settings.thisSystem ? std::strong_ordering::less : std::strong_ordering::equal;
if (comparison == 0)
comparison = comparePriorities(state, oneDrv, newestDrv);
if (comparison == 0)
@@ -627,13 +627,13 @@ static void upgradeDerivations(Globals & globals,
continue;
DrvName newName(j->queryName());
if (newName.name == drvName.name) {
- int d = compareVersions(drvName.version, newName.version);
+ std::strong_ordering d = compareVersions(drvName.version, newName.version);
if ((upgradeType == utLt && d < 0) ||
(upgradeType == utLeq && d <= 0) ||
(upgradeType == utEq && d == 0) ||
upgradeType == utAlways)
{
- long d2 = -1;
+ std::strong_ordering d2 = std::strong_ordering::less;
if (bestElem != availElems.end()) {
d2 = comparePriorities(*globals.state, *bestElem, *j);
if (d2 == 0) d2 = compareVersions(bestVersion, newName.version);
@@ -904,7 +904,7 @@ static VersionDiff compareVersionAgainstSet(
for (auto & i : elems) {
DrvName name2(i.queryName());
if (name.name == name2.name) {
- int d = compareVersions(name.version, name2.version);
+ std::strong_ordering d = compareVersions(name.version, name2.version);
if (d < 0) {
diff = cvGreater;
version = name2.version;