aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-03-28Don't interpret strings as format stringsEelco Dolstra
Ludo reported this error: unexpected Nix daemon error: boost::too_few_args: format-string refered to more arguments than were passed coming from this line: printMsg(lvlError, run.program + ": " + string(err, 0, p)); The problem here is that the string ends up implicitly converted to a Boost format() object, so % characters are treated specially. I always assumed (wrongly) that strings are converted to a format object that outputs the string as-is. Since this assumption appears in several places that may be hard to grep for, I've added some C++ type hackery to ensures that the right thing happens. So you don't have to worry about % in statements like printMsg(lvlError, "foo: " + s); or throw Error("foo: " + s);
2014-03-21Make /dev/kvm optionalLudovic Courtès
The daemon now creates /dev deterministically (thanks!). However, it expects /dev/kvm to be present. The patch below restricts that requirement (1) to Linux-based systems, and (2) to systems where /dev/kvm already exists. I’m not sure about the way to handle (2). We could special-case /dev/kvm and create it (instead of bind-mounting it) in the chroot, so it’s always available; however, it wouldn’t help much since most likely, if /dev/kvm missing, then KVM support is missing.
2014-03-18Fix tabsEelco Dolstra
2014-03-18Allow recovery from isValidPath RPCs with an invalid pathLudovic Courtès
Currently, clients cannot recover from an isValidPath RPC with an invalid path parameter because the daemon closes the connection when that happens. More precisely: 1. in performOp, wopIsValidPath case, ‘readStorePath’ raises an ‘Error’ exception; 2. that exception is caught by the handler in ‘processConnection’; 3. the handler determines errorAllowed == false, and thus exits after sending the message. This last part is fixed by calling ‘startWork’ early on, as in the patch below. The same reasoning could be applied to all the RPCs that take one or more store paths as inputs, but isValidPath is, by definition, likely to be passed invalid paths in the first place, so it’s important for this one to allow recovery.
2014-03-17Fix -j and other flags when using the daemonEelco Dolstra
2014-03-17nix-build: Fix --cores flagEelco Dolstra
2014-03-12Remove unnecessary null pointer checksEelco Dolstra
Fixes #225.
2014-03-12Document nix-env -q --jsonEelco Dolstra
2014-03-12Generate release notes againEelco Dolstra
2014-03-12Update release notes for 1.7Eelco Dolstra
2014-03-11Fix passing meta attribute to buildenv.nixEelco Dolstra
Since the meta attributes were not sorted, attribute lookup could fail, leading to package priorities and active flags not working correctly. Broken since 0f24400d90daf65cf20142a662f8245008437e2c.
2014-03-11Fix typosEelco Dolstra
2014-03-11Document null dynamic attrsShea Levy
2014-03-10The expr of AttrNames/DynamicAttrDefs is always an ExprConcatStringsShea Levy
2014-03-10If a dynamic attribute name evaluates to null, remove it from the setShea Levy
2014-03-05Revert "Make ifs and asserts tail-recursive"Eelco Dolstra
This reverts commit 273322c7732093a354e86df82cf75d6604b8bce8.
2014-03-05Install missing Boost headersEelco Dolstra
http://hydra.nixos.org/build/9328376
2014-02-28TypoEelco Dolstra
2014-02-27Set up a private /dev/pts in the chrootEelco Dolstra
2014-02-27Set up a minimal /dev in chrootsEelco Dolstra
Not bind-mounting the /dev from the host also solves the problem with /dev/shm being a symlink to something not in the chroot.
2014-02-27Correctly detect infinite recursion in function applicationEelco Dolstra
If we're evaluating some application ‘v = f x’, we can't store ‘f’ temporarily in ‘v’, because if ‘f x’ refers to ‘v’, it will get ‘f’ rather than an infinite recursion error. Unfortunately, this breaks the tail call optimisation introduced in c897bac54954373f63511702731fe2cb23c0c98e. Fixes #217.
2014-02-27Fix deadlock in SubstitutionGoalEelco Dolstra
We were relying on SubstitutionGoal's destructor releasing the lock, but if a goal is a top-level goal, the destructor won't run in a timely manner since its reference count won't drop to zero. So release it explicitly. Fixes #178.
2014-02-26DohEelco Dolstra
2014-02-26Test trace and addErrorContextEelco Dolstra
2014-02-26Test some more primopsEelco Dolstra
2014-02-26Test executables in NARsEelco Dolstra
2014-02-26And another oneEelco Dolstra
2014-02-26Remove another unused functionEelco Dolstra
2014-02-26Remove unused functionEelco Dolstra
2014-02-26Test nix-env --switch-generationEelco Dolstra
2014-02-26Test nix-env --setEelco Dolstra
2014-02-26Test the -b and -s flags of nix-store -qEelco Dolstra
2014-02-26Test ~/.nix-defexprEelco Dolstra
2014-02-26Test nix-store --switch-profile and more daemon actionsEelco Dolstra
2014-02-26Test nix-store -q --rootsEelco Dolstra
2014-02-26Test nix-store -lEelco Dolstra
2014-02-26Test nix-store --optimiseEelco Dolstra
2014-02-26Add a test for nix-store --dump-db / --load-dbEelco Dolstra
2014-02-26Installer: Handle DarwinEelco Dolstra
"cp -r" doesn't copy symlinks properly on Darwin, but "cp -R" does. Fixes #215.
2014-02-26nix-store -r: Respect --add-root for non-derivationsEelco Dolstra
Fixes #68. Fixes #117.
2014-02-26Also provide an option for setting the curl connection timeoutEelco Dolstra
2014-02-26Respect $NIX_CONNECT_TIMEOUT properlyEelco Dolstra
We were 1) using CURLOPT_TIMEOUT instead of CURLOPT_CONNECTTIMEOUT; 2) not passing it to the curl child process. Issue #93.
2014-02-26Add ~/.nix-profile/sbin to $PATHEelco Dolstra
Fixes #112.
2014-02-26Warn about missing -I pathsEelco Dolstra
Fixes #121. Note that we don't warn about missing $NIX_PATH entries because it's intended that some may be missing (cf. the default $NIX_PATH on NixOS, which includes paths like /etc/nixos/nixpkgs for backward compatibility).
2014-02-26Document dynamic attributesShea Levy
Signed-off-by: Shea Levy <shea@shealevy.com>
2014-02-26Simplify getting use-ssh-substituter from untrusted usersEelco Dolstra
2014-02-26Fix broken patchEelco Dolstra
2014-02-26use USER environmental variable if getting user id by getpwuid is failed in ↵Ian-Woo Kim
perl scripts: download-from-binary-cache.pl and nix-channel
2014-02-26Only start download-via-ssh if it's enabledEelco Dolstra
2014-02-26Add use-ssh-substituter setting.Shea Levy
It defaults to false and can be overridden by RemoteStore. Untested currently, just quickly put this together