aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-07Merge pull request #4922 from nrdxp/default-submodulesShea Levy
libfetchers/git: fetch submodules by default
2021-09-02Add FIXMEEelco Dolstra
2021-09-02Don't use read-only mode for nix build --dry-runGeorges Dubus
In dry run mode, new derivations can't be create, so running the command on anything that has not been evaluated before results in an error message of the form `don't know how to build these paths (may be caused by read-only store access)`. For comparison, the classical `nix-build --dry-run` doesn't use read-only mode. Closes #1795 (cherry picked from commit 54525682df707742e58311c32e9c9cb18de1e31f)
2021-09-02parseInstallables(): Parse store paths as store pathsEelco Dolstra
If the store path contains a flake, this means that a command like "nix path-info /path" will show info about /path, not about the default output of the flake in /path. If you want the latter, you can explicitly ask for it by doing "nix path-info path:/path". Fixes #4568.
2021-09-02Failing test case for flake in storeStéphan Kochen
2021-09-02Merge pull request #5203 from NixOS/fix-invalid-lockfile-namesEelco Dolstra
Don’t create lockfiles with an invalid path name
2021-09-02Merge pull request #5204 from lucc/patch-1Eelco Dolstra
Docs: Fix syntax error in json example in man page
2021-09-02Docs: Fix syntax error in json example in man pageLucas Hoffmann
2021-09-02Don’t create lockfiles with an invalid path nameregnat
Store paths are only allowed to contain a limited subset of the alphabet, which doesn’t include `!`. So don’t create lockfiles that contain this `!` character as that would otherwise confuse (and break) the gc. Fix #5176
2021-09-02Merge pull request #5201 from abathur/fix_missing_install_test_cachixDomen Kožar
fix CI for users with no install-tests cachix
2021-09-02Merge pull request #5202 from abathur/sudo_diskutil2Domen Kožar
installer: fix addVolume perm issue for some users
2021-09-01install: fix addVolume perm issue for some usersTravis A. Everett
As reported in #5198, volume creation can fail with a permission error for some macOS users (probably secondary user accounts?) Sudo appears to be sufficient to avoid this. While I'm here, I also updated the sudo invocation added in 079bde2ae to use the _sudo explanation wrapper.
2021-09-01fix CI for users with no installer-test cachixTravis A. Everett
Closes #5173
2021-09-01StyleEelco Dolstra
2021-09-01Merge branch 'short-circuit-subst' of https://github.com/Kha/nixEelco Dolstra
2021-09-01Merge pull request #5066 from Radvendii/masterEelco Dolstra
add antiquotations to paths
2021-08-31fix parse of `/${foo}`. was `// + foo`Taeer Bar-Yam
I don't think this changes the way any program would behave, but it's a cleaner internal representation.
2021-08-31add documentation for path antiquotationsTaeer Bar-Yam
2021-08-31path antiquotations: canonizePath -> canonicalizePathTaeer Bar-Yam
2021-08-31Merge pull request #5196 from hercules-ci/verbose-tests-fetchurl-for-darwin-eofEelco Dolstra
tests/fetchurl.sh: Be verbose to help debug darwin eof bug #2794
2021-08-31tests/fetchurl.sh: Be verbose to help debug darwin eof bug #2794Robert Hensing
2021-08-31Merge pull request #5071 from NixOS/dont-send-xp-features-to-the-daemonEelco Dolstra
Don’t send the experimental-features to the daemon
2021-08-30TarArchive: Small refactoringEelco Dolstra
2021-08-30Don't segfault if archive_entry_pathname() returns nullEelco Dolstra
Issues #4499.
2021-08-30Merge pull request #5096 from AnatoleLucet/patch-1Eelco Dolstra
Remove curl deps in install script
2021-08-30Merge pull request #5179 from matthewbauer/use-zshrcEelco Dolstra
Revert "Use /etc/zshenv instead of /etc/zshrc for profile"
2021-08-30Merge pull request #5172 from matthewbauer/enableOwnershipEelco Dolstra
Set enableOwnership in macOS install
2021-08-30Merge pull request #5186 from trofi/fix-DESTDIREelco Dolstra
doc/manual/local.mk: fix 'make install DESTDIR=...'
2021-08-30Merge pull request #5175 from Pamplemousse/makeEelco Dolstra
Don't overwrite user provided `lib*_LDFLAGS`
2021-08-30Merge pull request #5187 from trofi/prefer-inplace-libsEelco Dolstra
mk: prefert inplace library paths to system ones
2021-08-30Merge pull request #5191 from hercules-ci/evalstate-lifetime-hygieneEelco Dolstra
EvalState lifetime hygiene
2021-08-30Merge pull request #5192 from hercules-ci/non-null-posEelco Dolstra
Force all Pos* to be non-null
2021-08-30Don’t accept experimental features from the clientregnat
If the client sends an “experimental features” setting, just ignore it
2021-08-30TidyRobert Hensing
2021-08-29Fix use after free with vImportedDrvToDerivationRobert Hensing
2021-08-29Move vCallFlake into EvalStateRobert Hensing
This fixes a use-after-free bug: 1. s = new EvalState(); 2. callFlake() 3. static vCallFlake now references s 4. delete s; 5. s2 = new EvalState(); 6. callFlake() 7. static vCallFlake still references s 8. crash Nix 2.3 did not have a problem with recreating EvalState.
2021-08-29Force all Pos* to be non-nullRobert Hensing
This fixes a class of crashes and introduces ptr<T> to make the code robust against this failure mode going forward. Thanks regnat for the idea of a ref<T> without overhead! Closes #4895 Closes #4893 Closes #5127 Closes #5113
2021-08-28mk: prefert inplace library paths to system onesSergei Trofimovich
The link failure happens on a system with stable nix-2.3.15 installed in /usr/lib64 (it's libutil.so API differs from master): ``` LANG=C make V=1 g++ -o /home/slyfox/dev/git/nix/src/libstore/libnixstore.so \ -shared -L/usr/lib64 -Wl,--no-copy-dt-needed-entries \ src/libstore/binary-cache-store.o ... src/libstore/uds-remote-store.o \ -lsqlite3 -lcurl -lsodium -pthread -ldl -lseccomp -Wl,-z,defs -Wl,-soname=libnixstore.so -Wl,-rpath,/home/slyfox/dev/git/nix/src/libutil -Lsrc/libutil -lnixutil ld: src/libstore/binary-cache-store.o: in function `nix::BinaryCacheStore::BinaryCacheStore( std::map<std::__cxx11::basic_string<char, std::char_traits<char>, ... nix/src/libstore/binary-cache-store.cc:30: undefined reference to `nix::readFile( std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' ... ... ``` This happens due to `-L/usr/lib64 -Lsrc/libutil` search path ordering. The change turns it into `-Lsrc/libutil -L/usr/lib64`. Closes: https://github.com/NixOS/nix/issues/3087
2021-08-28doc/manual/local.mk: fix 'make install DESTDIR=...'Sergei Trofimovich
Install failure is observed when we try to install into inplace location as non-root: ``` $ LANG=C make install DESTDIR=$PWD/__i__ V=1 RUST_LOG=warn mdbook build doc/manual -d /usr/share/doc/nix/manual 2021-08-28 13:29:58 [ERROR] (mdbook::utils): Error: Rendering failed 2021-08-28 13:29:58 [ERROR] (mdbook::utils): Caused By: Unexpected error when constructing destination path 2021-08-28 13:29:58 [ERROR] (mdbook::utils): Caused By: Permission denied (os error 13) make: *** [doc/manual/local.mk:98: /usr/share/doc/nix/manual/index.html] Error 101 ``` The change is to prefix paths with `$(DESTDIR)`.
2021-08-25Revert "Use /etc/zshenv instead of /etc/zshrc for profile"Matthew Bauer
This reverts commit 909d8cb2934869c945ac1cc20dfb71df513042eb. This messes up PATH priority since /etc/profile gets sourced AFTER /etc/zshenv and it sets the system paths so $HOME/.nix-profile/bin:/nix/var/nix/profiles/default/bin is behind /usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin. See discussion in https://github.com/NixOS/nix/issues/4169.
2021-08-25Don't overwrite user provided `lib*_LDFLAGS`Pamplemousse
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
2021-08-24Try setting enableOwnership in macOS installMatthew Bauer
For external hard disks where ownership is not enabled by default.
2021-08-23Coding styleEelco Dolstra
2021-08-23Merge branch 'fix/subflake-follows-fix' of ↵Eelco Dolstra
https://github.com/ArctarusLimited/nix
2021-08-23Merge pull request #5160 from CertainLach/fix/invalid-characters-in-json-loggerEelco Dolstra
Replace invalid characters in json logger
2021-08-23Merge branch 'fix-attr-path-prefixes' of https://github.com/jtojnar/nixEelco Dolstra
2021-08-22Replace invalid characters in json loggerYaroslav Bolyukin
Fixes #5159 Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
2021-08-21nix {bundle,run}: drop broken flake attr-path prefixesJan Tojnar
“packages” was probably meant to be “packages.${system}.” but that is already listed in `getDefaultFlakeAttrPathPrefixes` in `installables`, which is probably why no one noticed it was broken.
2021-08-21nix develop: Fix `devShells` lookupJan Tojnar
It currently fails with the following error: error: flake 'git+file://…' does not provide attribute 'devShells.x86_64-linuxhaskell', 'packages.x86_64-linux.haskell', 'legacyPackages.x86_64-linux.haskell' or 'haskell'
2021-08-20Merge pull request #5153 from Pamplemousse/cleanEelco Dolstra
15f4d4f Documentation follow-up