aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-03-13Merge pull request #8040 from NixOS/macos-warningEelco Dolstra
Fix macOS warning
2023-03-13Merge pull request #7486 from fricklerhandwerk/doc-referenceEelco Dolstra
reword definition of "reference"
2023-03-13Merge pull request #7534 from fricklerhandwerk/maintainers-goalsValentin Gagarin
add objectives and tasks for Nix team
2023-03-13Merge pull request #8037 from edolstra/fix-make-cleanEelco Dolstra
make clean: Delete vars-and-functions.sh
2023-03-13Fix macOS warningEelco Dolstra
2023-03-13make clean: Delete vars-and-functions.shEelco Dolstra
2023-03-10Merge pull request #7896 from obsidiansystems/doxygenJohn Ericson
Generate API docs with Doxygen
2023-03-10Generate API docs with DoxygenJohn Ericson
The motivation is as stated in issue #7814: even though the the C++ API is internal and unstable, people still want it to be well documented for sake of learning, code review, and other purposes that aren't predicated on it being stable. Fixes #7814 Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-03-10Merge pull request #7928 from serokell/doc-includesValentin Gagarin
Documentation: process `#include` directives
2023-03-10Merge pull request #8015 from tweag/progress-during-nix-copyThéophane Hufschmitt
Display progress when running copyPaths (nix copy)
2023-03-09Merge pull request #8020 from edolstra/no-such-processEelco Dolstra
Make findRuntimeRoots() more resilient to disappearing processes
2023-03-09Make findRuntimeRoots() more resilient to disappearing processesEelco Dolstra
I saw this random failure in https://hydra.nixos.org/build/211811692: error: opening /proc/15307/fd: No such process while running nix-collect-garbage in a readfile-context.sh. This is because we're not handling ESRCH errors reading /proc/<pid>/fd. So just move the read inside the try/catch where we do handle it.
2023-03-09Merge pull request #8019 from edolstra/fix-read-from-stdinEelco Dolstra
Fix another uninitialized variable
2023-03-09Fix another uninitialized variableEelco Dolstra
https://hydra.nixos.org/build/211811494
2023-03-09Display progress when running copyPaths (nix copy)Alexander Bantyev
`nix copy` operations did not show progress. This is quite confusing. Add a `progressSink` which displays the progress during `copyPaths`, pretty much copied from `copyStorePath`. Fixes https://github.com/NixOS/nix/issues/8000
2023-03-09Merge pull request #8012 from NixOS/revert-7725-check-coro-gcEelco Dolstra
Revert "Disable GC during coroutine execution + test"
2023-03-08Merge pull request #5754 from obsidiansystems/harden-tests-set-uThéophane Hufschmitt
Harden tests' bash
2023-03-08Revert "Disable GC during coroutine execution + test"Théophane Hufschmitt
2023-03-08Merge pull request #8005 from edolstra/run-installcheckEelco Dolstra
Run 'make installcheck' again
2023-03-08Harden tests' bashJohn Ericson
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-03-08Run 'make installcheck' againEelco Dolstra
This was failing because the check for the existence of the 'installcheck' target failed silently, so the whole phase got skipped. It works by running 'make -n installcheck 2> /dev/null', which however barfs with /nix/store/039g378vc3pc3dvi9dzdlrd0i4q93qwf-binutils-2.39/bin/ld.gold: error: cannot open tests/plugins/plugintest.o: No such file or directory Fixes #8004.
2023-03-08Merge pull request #8007 from edolstra/fix-coverageEelco Dolstra
Fix coverage job
2023-03-08Merge pull request #8006 from edolstra/fix-read-from-stdinEelco Dolstra
Fix uninitialized readFromStdIn variable
2023-03-08Fix coverage jobEelco Dolstra
https://hydra.nixos.org/build/211747539
2023-03-08Fix uninitialized readFromStdIn variableEelco Dolstra
This was causing random failures in tests/ca/substitute.ca: 'nix copy --file ./content-addressed.nix' wouldn't get the default installable '.' applied in InstallablesCommand::load(), so it would do nothing.
2023-03-08Merge pull request #7994 from edolstra/fix-ca-crashEelco Dolstra
Fix crash/hang with CA derivations
2023-03-08Merge pull request #7993 from tweag/fix-profile-gcEelco Dolstra
Fix `nix-collect-garbage -d` with the new profile location
2023-03-08Fix crash/hang with CA derivationsEelco Dolstra
The curl download can outlive DrvOutputSubstitutionGoal (if some other error occurs), so at shutdown setting the promise to an exception will fail because 'this' is no longer valid in the callback. This can manifest itself as a segfault, "corrupted double-linked list" or hang.
2023-03-08Merge pull request #7725 from yorickvP/check-coro-gcThéophane Hufschmitt
Disable GC during coroutine execution + test
2023-03-07Fix `nix-collect-garbage -d` with the new profile locationThéophane Hufschmitt
Low-hanging fix for https://github.com/NixOS/nix/pull/5226#issuecomment-1454669399
2023-03-07Merge pull request #7889 from sidkshatriya/sorted-fetch-pathsThéophane Hufschmitt
Print the store paths to be fetched sorted by StorePath name()
2023-03-06Merge pull request #7580 from fricklerhandwerk/nix-team-add-johnEelco Dolstra
add @Ericson2314 to the Nix team
2023-03-06Merge pull request #7957 from NixOS/update-cachix-install-nixEelco Dolstra
Switch to cachix/install-nix-action@v20
2023-03-06Merge pull request #7958 from amesgen/issue-7955Eelco Dolstra
InstallableFlake: Apply nix config in `getCursors`
2023-03-06Merge pull request #7975 from fricklerhandwerk/fix-fetchgitEelco Dolstra
remove indentation in `fetchGit` attribute listing
2023-03-06Merge pull request #7376 from fricklerhandwerk/installableThéophane Hufschmitt
clarify definition of "installable"
2023-03-06output paths of store derivations are now addressed explicitlyValentin Gagarin
2023-03-05remove indentation in `fetchGit` attribute listingValentin Gagarin
also reword a confusing sentence and add links to Git terminology
2023-03-05clarify definition of "installable"Valentin Gagarin
the term was hard to discover, as its definition and explanation were in a very long document lacking an overview section. search did not help because it occurs so often. - clarify wording in the definition - add an overview of installable types - add "installable" to glossary - link to definition from occurrences of the term - be more precise about where store derivation outputs are processed - installable Nix expressions must evaluate to a derivation Co-authored-by: Adam Joseph <54836058+amjoseph-nixpkgs@users.noreply.github.com>
2023-03-05make descriptions of each installable type an own subsectionValentin Gagarin
this is easier to edit, provides anchors for free, and renders correctly on the terminal without additional effort.
2023-03-04InstallableFlake: Apply nix config in `getCursors`amesgen
2023-03-04Switch to cachix/install-nix-action@v20Théophane Hufschmitt
Fixes the installation issue with the latest Nix. Also revert the pinning to nix-2.13 since it's not needed any more.
2023-03-03Print the store paths to be fetched sorted by StorePath name() and not baseNameSidharth Kshatriya
Presently when nix says something like: ``` these 486 paths will be fetched (511.54 MiB download, 6458.64 MiB unpacked): ...path1 ...path2 ...path3 ... ... ...path486 ``` It sorts path1, path2, path3, ..., path486 in lexicographic order of the store path. After this commit, nix will show path1, path2, path3, ..., path486 sorted by StorePath name() (basically everything after the hash) rather than the store path. This makes it easier to review what exactly is being downloaded at a glance, especially when many paths need to be fetched.
2023-03-03Merge pull request #7918 from zimbatm/fix-empty-nix-store-envEelco Dolstra
treat empty NIX_STORE_DIR env vars as unset
2023-03-03cosmetic indentationValentin Gagarin
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2023-03-03Add talkative msg for coro gc debugYorick van Pelt
2023-03-03fixup: use same style as getEnvzimbatm
2023-03-03fixup: remove warning entirelyzimbatm
fixes https://github.com/NixOS/nix/pull/7918/files/72e1e230517b1e774d2db97cf9d4750e31ebcaa3#r1124211067
2023-03-03Merge pull request #7946 from cole-h/restore-static-bin-distEelco Dolstra
flake: restore binary-dist artifact to Hydra static builds
2023-03-03Merge pull request #7942 from edolstra/remove-formatEelco Dolstra
Remove FormatOrString and remaining uses of format()