aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-01-21Expand tests to reproduce #7655John Ericson
The original `builtins.getContext` test from 1d757292d0cb78beec32fcdfe15c2944a4bc4a95 would have caught this. The problem is that b30be6b450f872f8be6dc8afa28f4b030fa8d1d1 adding `builtins.appendContext` modified that test to make it test too much at once, rather than adding a separate test. We now have isolated tests for both functions, and also a property test showing everything put together (in the form of an eta rule for strings with context). This is better coverage and properly reproduces the bug.
2023-01-20Merge pull request #7577 from hercules-ci/pr-templateRobert Hensing
.github: Add pull request template
2023-01-20Update .github/PULL_REQUEST_TEMPLATE.mdRobert Hensing
2023-01-20Update .github/PULL_REQUEST_TEMPLATE.mdRobert Hensing
2023-01-20Merge pull request #7647 from fps/operator_docValentin Gagarin
doc: fix update operator description
2023-01-20doc: fix update operator descriptionFlorian Paul Schmidt
2023-01-20Merge pull request #7490 from fricklerhandwerk/doc-realiseThéophane Hufschmitt
define the terms "realise" and "valid" for store paths
2023-01-19Merge pull request #7629 from phip1611/patch-3Valentin Gagarin
2023-01-19doc: update language/index.mdPhilipp Schuster
- make `<nixpkgs>` visible (was blank in the rendered version)
2023-01-19Merge pull request #7640 from marceltransier/patch-2Eelco Dolstra
Fix update operator usage in operators.md
2023-01-19Merge pull request #7638 from marceltransier/patch-1Eelco Dolstra
Fix markdown error in operators.md
2023-01-19Fix update operator usage in operators.mdMarcel Transier
2023-01-18Fix markdown error in operators.mdMarcel Transier
Escape logical or pipe in markdown table according to https://github.github.com/gfm/#example-200
2023-01-18Merge pull request #7636 from asymmetric/relnotes-flakre-regEelco Dolstra
Relase notes: add empty flake registry
2023-01-18Relase notes: add empty flake registryLorenzo Manacorda
Introduced in #5420
2023-01-18Merge pull request #7631 from edolstra/output-namesEelco Dolstra
OutputSpec: Allow all valid output names
2023-01-18Add test for OutputsSpec::NamesEelco Dolstra
From @Ericson2314.
2023-01-18Fix indentationEelco Dolstra
2023-01-18Update binary-cache-substituter.md (#7628)Philipp Schuster
`binary-caches` is deprecated and `substituters` the new recommended option.
2023-01-18Merge pull request #7627 from edolstra/fetchTarball-channelEelco Dolstra
Restore support for channel: URLs in fetchTarball
2023-01-18Add some tests for illegal output namesEelco Dolstra
2023-01-18OutputSpec: Allow all valid output namesEelco Dolstra
Fixes #7624.
2023-01-18Merge pull request #7598 from yangsheng6810/fix_env_escapeThéophane Hufschmitt
Add escape for systemd service in installer script
2023-01-18Restore support for channel: URLs in fetchTarballEelco Dolstra
Fixes #7625.
2023-01-18Merge pull request #7621 from hercules-ci/nixpkgs-lib-regression-testRobert Hensing
Revert #6204 to fix regression, add nixpkgs/lib/tests as regression test
2023-01-18flake.nix: Add nixpkgs/lib/tests as regression testRobert Hensing
2023-01-18Revert "Merge pull request #6204 from layus/coerce-string"Robert Hensing
This reverts commit a75b7ba30f1e4f8b15e810fd18e63ee9552e0815, reversing changes made to 9af16c5f742300e831a2cc400e43df1e22f87f31.
2023-01-17Merge pull request #7620 from NixOS/bump-2.14.0Eelco Dolstra
Bump version
2023-01-17Bump versionEelco Dolstra
2023-01-17Merge pull request #7614 from edolstra/typoEelco Dolstra
Fix typo in the release notes
2023-01-17TypoEelco Dolstra
2023-01-17Merge pull request #7613 from obsidiansystems/fix-variant-missing-rawEelco Dolstra
Try again to fix aarch64-linux build failure
2023-01-17Try again to fix aarch64-linux build failureJohn Ericson
f419ab48e6394838097f158265ac3cc531ee7958 was on the right track, but there are a few more missing `raw()` calls to fix.
2023-01-17Merge pull request #7612 from edolstra/release-notesEelco Dolstra
Release notes for 2.13
2023-01-17Merge pull request #7606 from hercules-ci/recognize-some-flake-attributesEelco Dolstra
flake check: Recognize well known community attributes
2023-01-17Release notesEelco Dolstra
2023-01-16flake check: Recognize well known community attributesRobert Hensing
This avoids warning fatigue, making `nix flake check` more effective.
2023-01-16Merge pull request #7585 from NixOS/macos-disconnectEelco Dolstra
MonitorFdHup: Make it work on macOS again
2023-01-16Merge pull request #7604 from obsidiansystems/fix-variant-missing-rawRobert Hensing
Try to fix build failure
2023-01-15Try to fix build failureJohn Ericson
Failure: https://hydra.nixos.org/build/205357257/nixlog/1 The problem seems to be trying to `std::visit` a derived class of `std::variant`. Per https://stackoverflow.com/questions/63616709/incomplete-type-stdvariant-used-in-nested-name-specifier certain C++ standard library implementations allow this, but others do not. The solution is simply to call the `raw` method, which upcasts the reference back to the `std::variant`.
2023-01-14Merge pull request #7599 from obsidiansystems/move-path-info-definitionsRobert Hensing
Move `ValidPathInfo` defintions to `path-info.cc`
2023-01-14Apply suggestions from code reviewRobert Hensing
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-01-13Move `ValidPathInfo` defintions to `path-info.cc`John Ericson
Originally there was no `path-info.*`, then there was `path-info.hh`, then there was `path-info.cc`, but only for new things. Moving this stuff over makes everything consistent.
2023-01-14Add escape for systemd service in installer scriptSheng Yang
Among all the characters that are allowed in a URL, both the percentage sign "%" and the single quotation mark "'" needs escaping when written as a environment variable in a systemd service file. While the single quotation mark may be rare, the percentage sign is widely used to escape characters in a URL. This is especially common in proxy setting, where username and password may contain special characters that need percentage escaping. This patch applies the following replacements: % -> %% ' -> \'
2023-01-13Merge pull request #7597 from tweag/move-implem-bit-to-implem-fileRobert Hensing
Move the `getBuildLog` implementation to its own implementation file
2023-01-13Merge pull request #6815 from obsidiansystems/better-wanted-outputsRobert Hensing
`OutputSpec` for `DerivationGoal` and `DerivedPath`, today's `OutputSpec` -> `ExtendedOutputSpec`
2023-01-13Move the `getBuildLog` implementation to its own implementation fileThéophane Hufschmitt
Keep the header minimal and clean
2023-01-13Merge pull request #7430 from tweag/ca/fix-nix-logThéophane Hufschmitt
Ca/fix nix log
2023-01-13Merge pull request #7427 from fricklerhandwerk/pr-policyThéophane Hufschmitt
state priorities in triaging and discussion process
2023-01-12Write more (extended) output spec testsJohn Ericson