aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-03nix-store.cc: Refactor, remove qDefaultRobert Hensing
2023-04-03Enable -Werror=switch-enumRobert Hensing
switch statements must now match all enum values or disable the warning. Explicit is good. This has helped us find two bugs, after solving another one by debugging. From now on, adding to an enum will raise errors where they are not explicitly handled, which is good for productivity, and helps us decide the correct behavior in all usages. Notably still excluded from this though are the cases where the warning is disabled by local pragmas. fromTOML.cc did not build despite a top-level pragma, so I've had to resort to a makefile solution for that.
2023-04-03Allow open switch-enum in 5 placesRobert Hensing
2023-04-03Add explicit case statements where -Wswitch-enum would report themRobert Hensing
2023-04-03Fix systemd logging for lvlNotice: eqv to lvlInfo, not lvlVomitRobert Hensing
2023-04-03Fix BuildResult.toString() for NoSubstitutersRobert Hensing
2023-04-03Merge pull request #8148 from ↵Robert Hensing
hercules-ci/fix-issue-8119-printValue-tBlackhole-abort eval: Fix crash on missing printValue tBlackhole case
2023-04-03Merge pull request #8152 from obsidiansystems/move-querySubstitutablePathInfosEelco Dolstra
Move `querySubstitutablePathInfos` from `LocalStore` to `Store`
2023-04-03eval: Fix crash on missing printValue tBlackhole caseRobert Hensing
Fixes #8119
2023-04-03Merge pull request #7610 from obsidiansystems/gate-default-settingsThéophane Hufschmitt
Punt on improper global flags for now
2023-04-03Merge pull request #8039 from obsidiansystems/prioritize-testingThéophane Hufschmitt
Prioritize testing in the maintainers process docs
2023-04-03Merge pull request #8151 from obsidiansystems/internal-api-docs-pr-templateEelco Dolstra
Mention internal API docs in PR template
2023-04-02Move `querySubstitutablePathInfos` from `LocalStore` to `Store`John Ericson
The code is not local-store-specific, so we should share it with all stores. More uniform behavior is better, and a less store-specific functionality is more maintainable. This fixes a FIXME added in f73d911628 by @edolstra himself.
2023-04-02Mention internal API docs in PR templateJohn Ericson
I think we want to ensure that all new items in headers are documented, and the documentation on modified items is kept up to date. It will take a while to document the backlog of undocumented things, but we can at least ensure that new items don't extend that backlog.
2023-04-01Merge pull request #8122 from ↵John Ericson
bjornfor/use-nix-store-l-unless-experimental-enabled Don't recommend 'nix log' unless experimental feature is enabled
2023-04-01Merge pull request #8133 from obsidiansystems/improve-internal-api-docsJohn Ericson
Extend internal API docs, part 2
2023-03-31Ensure all headers have `#pragma once` and are in API docsJohn Ericson
`///@file` makes them show up in the internal API dos. A tiny few were missing `#pragma once`.
2023-03-31Extend internal API docs, part 2John Ericson
Picking up from #8111. Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
2023-03-31Merge pull request #8142 from patricksjackson/atomic-syncJohn Ericson
Replace unnecessary Sync<uint64_t> with std::atomic<uint64_t>
2023-03-31Replace unnecessary Sync<uint64_t> with std::atomic<uint64_t>Patrick Jackson
2023-03-31Merge pull request #8137 from edolstra/lazy-trees-cherrypicksEelco Dolstra
Add CanonPath::makeRelative()
2023-03-31IndentationEelco Dolstra
2023-03-31Add CanonPath::makeRelative()Eelco Dolstra
2023-03-31Merge pull request #8139 from edolstra/no-nixpkgsFor-outputEelco Dolstra
Remove nixpkgsFor flake output
2023-03-31Merge pull request #8138 from tweag/fix-installer-vm-testsEelco Dolstra
Fix the installer VM tests
2023-03-31Remove nixpkgsFor flake outputEelco Dolstra
Fixes "warning: unknown flake output 'nixpkgsFor'".
2023-03-31test: Make the installer work on old rhel versionsThéophane Hufschmitt
`scp -r` doesn't seem to behave properly there, so tarpipe ftw!
2023-03-31test: Don't add a channel for the force-no-daemon installer variantThéophane Hufschmitt
Was probably an overlook of when the tests were first added, but that now messes-up with the `nix-channel --update` that happens down the line (and can't access the network since we're inside a Nix build)
2023-03-31Merge pull request #7406 from amesgen/gitlab-fetcherThéophane Hufschmitt
Document `gitlab` input scheme
2023-03-31Merge pull request #8018 from tweag/ssh-password-promptThéophane Hufschmitt
SSH: don't erase password prompt if it is displayed
2023-03-31Merge pull request #8135 from patricksjackson/copyPaths-dataraceThéophane Hufschmitt
Fix data race in copyPaths
2023-03-30Only lock oncePatrick Jackson
2023-03-30Fix data race in copyPathsPatrick Jackson
2023-03-30Merge pull request #8111 from obsidiansystems/improve-internal-api-docsJohn Ericson
Convert a bunch of comments in headers to Doxygen documentation
2023-03-30Merge pull request #7518 from fricklerhandwerk/doc-commandsValentin Gagarin
separate man pages for `nix-store` and `nix-env` subcommands
2023-03-30process includes firstValentin Gagarin
otherwise the order of found `.md` files will influence if `@docroot@` is replaced before them being included, which may mess up relative links. the weirdest thing about it is that the mess-up happens deterministically on macOS, but deterministically doesn't happen on Linux!
2023-03-30Merge pull request #8123 from nomeata/import-flake-docsEelco Dolstra
Docs: Explain why `import nixpkgs` works in flakes
2023-03-30TypoEelco Dolstra
2023-03-30Merge pull request #8129 from figsoda/atEelco Dolstra
Allow `@` in git refs
2023-03-30More precise wordingJoachim Breitner
2023-03-30Split nix-env and nix-store documentation per-subcommandAlexander Bantyev
Documentation on "classic" commands with many sub-commands are notoriously hard to discover due to lack of overview and anchor links. Additionally the information on common options and environment variables is not accessible offline in man pages, and therefore often overlooked by readers. With this change, each sub-command of nix-store and nix-env gets its own page in the manual (listed in the table of contents), and each own man page. Also, man pages for each subcommand now (again) list common options and environment variables. While this makes each page quite long and some common parameters don't apply, this should still make it easier to navigate as that additional information was not accessible on the command line at all. It is now possible to run 'nix-store --<subcommand> --help` to display help pages for the given subcommand. Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-03-30Manual: fail when #include-d file does not existAlexander Bantyev
2023-03-29Convert a bunch of comments in headers to Doxygen documentationJohn Ericson
The internal API docs now contain more useful information. Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2023-03-29Allow `@` in git refsfigsoda
2023-03-29Update src/libexpr/primops.ccJoachim Breitner
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
2023-03-29Merge pull request #8125 from vaci/vaci/hash_to_string_copyEelco Dolstra
Avoid a string copy during Hash::to_string
2023-03-29avoid a string copy in printHash16Vaci Koblizek
2023-03-29return string_view from printHashType rather than stringVaci Koblizek
2023-03-28Don't recommend 'nix log' unless experimental feature is enabledBjørn Forsman
This fixes the issue that `nix-build`, without experimental feature 'nix-command' enabled, recommends the experimental CLI `nix log` to view build logs. Now it'll recommend the stable `nix-store -l` CLI instead. Fixes https://github.com/NixOS/nix/issues/8118
2023-03-28Avoid a string copy during Hash::to_stringVaci Koblizek