| Age | Commit message (Collapse) | Author |
|---|
|
https://hydra.nixos.org/build/211811494
|
|
`nix copy` operations did not show progress. This is quite confusing.
Add a `progressSink` which displays the progress during `copyPaths`,
pretty much copied from `copyStorePath`.
Fixes https://github.com/NixOS/nix/issues/8000
|
|
Revert "Disable GC during coroutine execution + test"
|
|
Harden tests' bash
|
|
|
|
Run 'make installcheck' again
|
|
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
|
|
This was failing because the check for the existence of the
'installcheck' target failed silently, so the whole phase got
skipped. It works by running 'make -n installcheck 2> /dev/null',
which however barfs with
/nix/store/039g378vc3pc3dvi9dzdlrd0i4q93qwf-binutils-2.39/bin/ld.gold: error: cannot open tests/plugins/plugintest.o: No such file or directory
Fixes #8004.
|
|
Fix coverage job
|
|
Fix uninitialized readFromStdIn variable
|
|
https://hydra.nixos.org/build/211747539
|
|
This was causing random failures in tests/ca/substitute.ca: 'nix copy
--file ./content-addressed.nix' wouldn't get the default installable
'.' applied in InstallablesCommand::load(), so it would do nothing.
|
|
Fix crash/hang with CA derivations
|
|
Fix `nix-collect-garbage -d` with the new profile location
|
|
The curl download can outlive DrvOutputSubstitutionGoal (if some other
error occurs), so at shutdown setting the promise to an exception will
fail because 'this' is no longer valid in the callback. This can
manifest itself as a segfault, "corrupted double-linked list" or hang.
|
|
Disable GC during coroutine execution + test
|
|
Low-hanging fix for https://github.com/NixOS/nix/pull/5226#issuecomment-1454669399
|
|
Print the store paths to be fetched sorted by StorePath name()
|
|
|
|
|
|
add @Ericson2314 to the Nix team
|
|
Switch to cachix/install-nix-action@v20
|
|
InstallableFlake: Apply nix config in `getCursors`
|
|
remove indentation in `fetchGit` attribute listing
|
|
clarify definition of "installable"
|
|
|
|
also reword a confusing sentence and add links to Git terminology
|
|
the term was hard to discover, as its definition and explanation were in
a very long document lacking an overview section.
search did not help because it occurs so often.
- clarify wording in the definition
- add an overview of installable types
- add "installable" to glossary
- link to definition from occurrences of the term
- be more precise about where store derivation outputs are processed
- installable Nix expressions must evaluate to a derivation
Co-authored-by: Adam Joseph <54836058+amjoseph-nixpkgs@users.noreply.github.com>
|
|
this is easier to edit, provides anchors for free, and renders correctly
on the terminal without additional effort.
|
|
|
|
Fixes the installation issue with the latest Nix.
Also revert the pinning to nix-2.13 since it's not needed any more.
|
|
Presently when nix says something like:
```
these 486 paths will be fetched (511.54 MiB download, 6458.64 MiB unpacked):
...path1
...path2
...path3
...
...
...path486
```
It sorts path1, path2, path3, ..., path486 in lexicographic order of the
store path.
After this commit, nix will show path1, path2, path3, ..., path486 sorted by
StorePath name() (basically everything after the hash) rather than the store path.
This makes it easier to review what exactly is being downloaded at a glance,
especially when many paths need to be fetched.
|
|
treat empty NIX_STORE_DIR env vars as unset
|
|
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
|
|
|
|
|
|
fixes https://github.com/NixOS/nix/pull/7918/files/72e1e230517b1e774d2db97cf9d4750e31ebcaa3#r1124211067
|
|
flake: restore binary-dist artifact to Hydra static builds
|
|
Remove FormatOrString and remaining uses of format()
|
|
remove stale pull request template
|
|
add comments
|
|
the old one seems not to be picked up by GitHub anyway
|
|
feat: read installable paths from stdin
|
|
|
|
|
|
Fix 'make check' inside 'nix develop'
|
|
Log the decompressed body in case of http errors
|
|
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
|
|
|
|
|
