aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-04-04Show position info in string concatenation / addition errorsEelco Dolstra
2014-04-04derivation: Don't require certain function argumentsEelco Dolstra
Turns out that in Nixpkgs, derivation is actually called without a ‘name’ argument in some places :-(
2014-04-04forceString: Show position infoEelco Dolstra
2014-04-04forceAttrs: Show position infoEelco Dolstra
2014-04-04forceList: Show position infoEelco Dolstra
2014-04-04forceInt: Show position infoEelco Dolstra
2014-04-04Pass position information to primop callsEelco Dolstra
For example: error: `tail' called on an empty list, at /home/eelco/Dev/nixpkgs/pkgs/applications/misc/hello/ex-2/default.nix:13:7
2014-04-04Remove unnecessary quotes around file namesEelco Dolstra
2014-04-04Include position info in function applicationEelco Dolstra
This allows error messages like: error: the anonymous function at `/etc/nixos/configuration.nix:1:1' called without required argument `foo', at `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs/lib/modules.nix:77:59'
2014-04-04Update release notesEelco Dolstra
2014-04-04Document that we require a C++11 compilerEelco Dolstra
2014-04-03Fix compile errors on IllumosDanny Wilson
2014-04-03Sync with make-rules repoEelco Dolstra
2014-04-03Support IllumosEelco Dolstra
From https://github.com/NixOS/nix/pull/236
2014-04-03Tweak error messageEelco Dolstra
2014-04-03Make sure /dev/pts/ptmx is world-writableLudovic Courtès
While running Python 3’s test suite, we noticed that on some systems /dev/pts/ptmx is created with permissions 0 (that’s the case with my Nixpkgs-originating 3.0.43 kernel, but someone with a Debian-originating 3.10-3 reported not having this problem.) There’s still the problem that people without CONFIG_DEVPTS_MULTIPLE_INSTANCES=y are screwed (as noted in build.cc), but I don’t see how we could work around it.
2014-04-01Fix potential segfaultEelco Dolstra
The newEnv variable was accessed (via the dynamicEnv) pointer after it had gone out of scope. Fixes #234.
2014-03-30nix-collect-garbage: Add --delete-older-than optionRicardo M. Correia
2014-03-30nix-env: Add support for --delete-generations 15dRicardo M. Correia
It will delete all generations older than the specified number of days.
2014-03-30Fix nix-shell for derivation with multiple outputsMaxim Ivanov
If derivation declares multiple outputs and first (default) output if not "out", then "nix-instantiate" calls return path with output names appended after "!". Than suffix must be stripped before ant path checks are done.
2014-03-30boost::shared_ptr -> std::shared_ptrEelco Dolstra
2014-03-29Drop pointless #includeEelco Dolstra
2014-03-29Fix potential segfault in waitForInput()Eelco Dolstra
Since the addition of build-max-log-size, a call to handleChildOutput() can result in cancellation of a goal. This invalidated the "j" iterator in the waitForInput() loop, even though it was still used afterwards. Likewise for the maxSilentTime handling. Probably fixes #231. At least it gets rid of the valgrind warnings.
2014-03-29restoreSIGPIPE(): Fill in sa_maskEelco Dolstra
Issue #231.
2014-03-28Don't interpret strings as format stringsEelco Dolstra
Ludo reported this error: unexpected Nix daemon error: boost::too_few_args: format-string refered to more arguments than were passed coming from this line: printMsg(lvlError, run.program + ": " + string(err, 0, p)); The problem here is that the string ends up implicitly converted to a Boost format() object, so % characters are treated specially. I always assumed (wrongly) that strings are converted to a format object that outputs the string as-is. Since this assumption appears in several places that may be hard to grep for, I've added some C++ type hackery to ensures that the right thing happens. So you don't have to worry about % in statements like printMsg(lvlError, "foo: " + s); or throw Error("foo: " + s);
2014-03-21Make /dev/kvm optionalLudovic Courtès
The daemon now creates /dev deterministically (thanks!). However, it expects /dev/kvm to be present. The patch below restricts that requirement (1) to Linux-based systems, and (2) to systems where /dev/kvm already exists. I’m not sure about the way to handle (2). We could special-case /dev/kvm and create it (instead of bind-mounting it) in the chroot, so it’s always available; however, it wouldn’t help much since most likely, if /dev/kvm missing, then KVM support is missing.
2014-03-18Fix tabsEelco Dolstra
2014-03-18Allow recovery from isValidPath RPCs with an invalid pathLudovic Courtès
Currently, clients cannot recover from an isValidPath RPC with an invalid path parameter because the daemon closes the connection when that happens. More precisely: 1. in performOp, wopIsValidPath case, ‘readStorePath’ raises an ‘Error’ exception; 2. that exception is caught by the handler in ‘processConnection’; 3. the handler determines errorAllowed == false, and thus exits after sending the message. This last part is fixed by calling ‘startWork’ early on, as in the patch below. The same reasoning could be applied to all the RPCs that take one or more store paths as inputs, but isValidPath is, by definition, likely to be passed invalid paths in the first place, so it’s important for this one to allow recovery.
2014-03-17Fix -j and other flags when using the daemonEelco Dolstra
2014-03-17nix-build: Fix --cores flagEelco Dolstra
2014-03-12Remove unnecessary null pointer checksEelco Dolstra
Fixes #225.
2014-03-12Document nix-env -q --jsonEelco Dolstra
2014-03-12Generate release notes againEelco Dolstra
2014-03-12Update release notes for 1.7Eelco Dolstra
2014-03-11Fix passing meta attribute to buildenv.nixEelco Dolstra
Since the meta attributes were not sorted, attribute lookup could fail, leading to package priorities and active flags not working correctly. Broken since 0f24400d90daf65cf20142a662f8245008437e2c.
2014-03-11Fix typosEelco Dolstra
2014-03-11Document null dynamic attrsShea Levy
2014-03-10The expr of AttrNames/DynamicAttrDefs is always an ExprConcatStringsShea Levy
2014-03-10If a dynamic attribute name evaluates to null, remove it from the setShea Levy
2014-03-05Revert "Make ifs and asserts tail-recursive"Eelco Dolstra
This reverts commit 273322c7732093a354e86df82cf75d6604b8bce8.
2014-03-05Install missing Boost headersEelco Dolstra
http://hydra.nixos.org/build/9328376
2014-03-03Don't set an absolute sonameEelco Dolstra
2014-03-03Add support for making relocatable packages using $ORIGINEelco Dolstra
2014-02-28TypoEelco Dolstra
2014-02-28Add a variable GLOBAL_CXXFLAGS_PCH for use by precompiled headersEelco Dolstra
You don't want to use GLOBAL_CXXFLAGS for passing flags like "-include-pch" (clang), because that means you cannot use GLOBAL_CXXFLAGS when generating the PCH.
2014-02-28Add variable GLOBAL_COMMON_DEPSEelco Dolstra
This is a list of dependencies on which all C/C++ object files depend. Primarily useful for global precompiled headers.
2014-02-27Set up a private /dev/pts in the chrootEelco Dolstra
2014-02-27Set up a minimal /dev in chrootsEelco Dolstra
Not bind-mounting the /dev from the host also solves the problem with /dev/shm being a symlink to something not in the chroot.
2014-02-27Correctly detect infinite recursion in function applicationEelco Dolstra
If we're evaluating some application ‘v = f x’, we can't store ‘f’ temporarily in ‘v’, because if ‘f x’ refers to ‘v’, it will get ‘f’ rather than an infinite recursion error. Unfortunately, this breaks the tail call optimisation introduced in c897bac54954373f63511702731fe2cb23c0c98e. Fixes #217.
2014-02-27Fix deadlock in SubstitutionGoalEelco Dolstra
We were relying on SubstitutionGoal's destructor releasing the lock, but if a goal is a top-level goal, the destructor won't run in a timely manner since its reference count won't drop to zero. So release it explicitly. Fixes #178.