aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-11-11Restrict `readFile` context to references that appear in the stringNaïm Favier
When calling `builtins.readFile` on a store path, the references of that path are currently added to the resulting string's context. This change makes those references the *possible* context of the string, but filters them to keep only the references whose hash actually appears in the string, similarly to what is done for determining the runtime references of a path.
2022-10-05Merge pull request #6652 from abathur/doc_install_testsValentin Gagarin
2022-10-05Apply suggestions from code reviewTravis A. Everett
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2022-10-05Merge pull request #6870 from ↵Valentin Gagarin
amjoseph-nixpkgs/pr/doc/explain-local-remote-binary-substituter
2022-10-03Merge pull request #6969 from fricklerhandwerk/refactor-generate-manpageThéophane Hufschmitt
refactor rendering command documentation to markdown
2022-09-30Merge pull request #7080 from squalus/nar-close-fileEelco Dolstra
archive: check close errors when extracting nars
2022-09-30Merge pull request #7108 from rapenne-s/wordingEelco Dolstra
nix-copy-closure: improve wording
2022-09-30bring back lost newlineValentin Gagarin
2022-09-30use more self-explanatory namesValentin Gagarin
2022-09-30move final template to the topValentin Gagarin
this allows readers to enter the code starting with what is visible from the outside, instead of working themselves up from purely technical details.
2022-09-30remove superfluous let-in pairValentin Gagarin
2022-09-30refactor showOptionsValentin Gagarin
it was quite a pain to manipulate strings just with `builtins`
2022-09-30refactor rendering command documentation to markdownValentin Gagarin
idea: - make document structure visible, like in a template - order functions by descending abstraction - avoid nested let bindings
2022-09-30use indented strings where appropriateValentin Gagarin
2022-09-29Merge pull request #7114 from rapenne-s/reenable_testThéophane Hufschmitt
tests/build-dry: re-enable some test
2022-09-28tests/build-dry: re-enable some testSolene Rapenne
2022-09-28nix-copy-closure: improve wordingSolene Rapenne
2022-09-27Merge pull request #7105 from SquidDev/hotfix/fish-returnEelco Dolstra
Use exit instead of return in /etc/profile.d/nix-daemon.fish
2022-09-27Use exit instead of return in fish profileJonathan Coates
Older versions of Fish (such as those bundled with Ubuntu LTS 22.04) do not support return outside of functions. We need to use the equivalent exit instead.
2022-09-27Merge pull request #7103 from lheckemann/remove-add-rootEelco Dolstra
nix-build: remove unused --add-root arg
2022-09-27nix-build: remove unused --add-root argLinus Heckemann
Fixes #1982
2022-09-26Merge pull request #7043 from edolstra/installer-testEelco Dolstra
Add an installer test
2022-09-26Quote URLsEelco Dolstra
2022-09-26Remove FIXMEEelco Dolstra
2022-09-26Merge pull request #7089 from NixOS/mention-accept-flake-config-in-warningEelco Dolstra
Mention `--accept-flake-config` in the related warning
2022-09-26Merge pull request #7093 from amjoseph-nixpkgs/pr/intersectAttrs/valuesEelco Dolstra
src/libexpr/primops.cc: correct definition for intersectAttrs
2022-09-24src/libexpr/primops.cc: correct definition for intersectAttrsAdam Joseph
The current definition of `intersectAttrs` is incorrect: > Return a set consisting of the attributes in the set e2 that also exist in the > set e1. Recall that (Nix manual, section 5.1): > An attribute set is a collection of name-value-pairs (called attributes) According to the existing description of `intersectAttrs`, the following should evaluate to the empty set, since no key-value *pair* (i.e. attribute) exists in both sets: ``` builtins.intersectAttrs { x=3; } {x="foo";} ``` And yet: ``` nix-repl> builtins.intersectAttrs { x=3; } {x="foo";} { x = "foo"; } ``` Clearly the intent here was for the *names* of the resulting attribute set to be the intersection of the *names* of the two arguments, and for the values of the resulting attribute set to be the values from the second argument. This commit corrects the definition, making it match the implementation and intent.
2022-09-24Merge pull request #7010 from edolstra/ignore-shellThéophane Hufschmitt
nix develop: Ignore stdenv's $SHELL
2022-09-24Merge pull request #7046 from mkenigs/fix-root-SHELLThéophane Hufschmitt
dockerImage: fix root shell
2022-09-24Merge pull request #7078 from obsidiansystems/trustworthy-signatureThéophane Hufschmitt
"valid signature" -> "signature by a trusted key"
2022-09-24Merge pull request #7079 from matthewbauer/allow-untrusted-settingsThéophane Hufschmitt
Allow pass max-silent-time and build-poll-interval to daemon untrusted
2022-09-24Merge pull request #7082 from rapenne-s/ccacheThéophane Hufschmitt
add ccacheStdenv
2022-09-24Mention `--accept-flake-config` in the related warningThéophane Hufschmitt
Make sure that people who run Nix in non-interactive mode (and so don't have the possibility to interactively accept the individual flake configuration settings) are aware of this flag. Fix #7086
2022-09-24Merge pull request #7056 from hiroqn/fix-unameEelco Dolstra
Fix `uname -m` return value for armv6l/armv7l
2022-09-24Merge pull request #7059 from NixOS/remove-useless-ca-file-messageEelco Dolstra
Remove a useless debug message in filetransfer.cc
2022-09-23Apply suggestions from code reviewJohn Ericson
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io> Co-authored-by: Rune K. Svendsen <runesvend@gmail.com>
2022-09-23add ccacheStdenvSolène Rapenne
when using ccache, rebuild time has been measured 89% faster while not slowing the speed of cold builds
2022-09-22archive: check close errors when extracting narssqualus
2022-09-22Allow pass max-silent-time and build-poll-interval to daemon untrustedMatthew Bauer
These settings seem harmless, they control the same polling functionality that timeout does, but with different behavior. Should be safe for untrusted users to pass in.
2022-09-22Dodge "trusted" vs "trustworthy" by being explicit John Ericson
Hopefully this is best!
2022-09-22"valid signature" -> "trustworthy signature"John Ericson
I just had a colleague get confused by the previous phrase for good reason. "valid" sounds like an *objective* criterion, e.g. and *invalid signature* would be one that would be trusted by no one, e.g. because it misformatted or something. What is actually going is that there might be a signature which is perfectly valid to *someone else*, but not to the user, because they don't trust the corresponding public key. This is a *subjective* criterion, because it depends on the arbitrary and personal choice of which public keys to trust. I therefore think "trustworthy" is a better adjective to use. Whether something is worthy of trust is clearly subjective, and then "trust" within that word nicely evokes `trusted-public-keys` and friends.
2022-09-21Merge pull request #7070 from alyssais/repl-historyThéophane Hufschmitt
nix repl: warn if creating dir for history fails
2022-09-20nix repl: warn if creating dir for history failsAlyssa Ross
The history is not critical to the functionality of nix repl, so it's enough to warn here, rather than refuse to start if the directory Nix thinks the history should live in can't be created.
2022-09-20Merge pull request #7065 from squalus/schema-corruptThéophane Hufschmitt
Improve durability of schema version file writes
2022-09-20fix `uname -m` return value for armv6l/armv7lhiroqn
2022-09-19Improve durability of schema version file writessqualus
- call close explicitly in writeFile to prevent the close exception from being ignored - fsync after writing schema file to flush data to disk - fsync schema file parent to flush metadata to disk https://github.com/NixOS/nix/issues/7064
2022-09-19Merge pull request #7060 from fricklerhandwerk/issue-templatesThéophane Hufschmitt
issue template: fill 'about' field
2022-09-19issue template: fill 'about' fieldValentin Gagarin
according to [GitHub documentation] some fields are required. `about` is not listed, but it probably is required. [GitHub documentation]: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms
2022-09-19Remove a useless debug message in filetransfer.ccThéophane Hufschmitt
Remove the `verify TLS: Nix CA file = 'blah'` message that Nix used to print when fetching anything as it's both useless (`libcurl` prints the same info in its logs) and misleading (gives the impression that a new TLS connection is being established which might not be the case because of multiplexing. See #7011 )
2022-09-18address review feedbackTravis A. Everett
Mainly: - Try to triangulate between narrative that framed this as a new/easy process and the need for a reference that will not quickly grow stale. - Fix a ~continuity issue where the text was talking about "your Cachix cache" before saying that you'd need to make a Cachix cache to enable the installer tests. - Adopt suggestion on titling, and nest subtitles in the installer test section.