aboutsummaryrefslogtreecommitdiff
path: root/maintainers
AgeCommit message (Collapse)Author
2024-04-08build-release-notes: support multiple PRs/CLsJade Lovelace
Change-Id: I923e4af099d02d2324777cc9f7e6d38b130aac10
2024-04-08Format Nix code with `nixfmt`Rebecca Turner
Change-Id: I61efeb666ff7481c05fcb247168290e86a250151
2024-04-03repl: improve `:doc` builtin repl command to support lambdas.Lunaphied
For a long time `nix repl` has supported displaying documentation set on builtins, however, it has long been convention to use Markdown comments on Nix functions themselves for documentation. This exposes that information to `nix repl` users in a nice and formatted way. NixOS/rfcs#145 doc-comments are primarily what this feature is intended to consume, however, support for lambda documentation in the repl is experimental. We do our best effort to support the RFC here. These changes are based on [the nix-doc library](https://github.com/lf-/nix-doc) and are licensed under the terms described in the relevant source files. Change-Id: Ic6fe947d39a22540705d890737e336c4720b0a22
2024-03-29Add `pre-commit` checksRebecca Turner
The big ones here are `trim-trailing-whitespace` and `end-of-file-fixer` (which makes sure that every file ends with exactly one newline character). Change-Id: Idca73b640883188f068f9903e013cf0d82aa1123
2024-03-27Enable clang build timing analysisJade Lovelace
I didn't enable this by default for clang due to making the build time 10% worse or so. Unfortunate, but tbh devs for whom 10% of build time is not *that* bad should probably simply enable this. Change-Id: I8d1e5b6f3f76c649a4e2f115f534f7f97cee46e6
2024-03-27build: replace changelog-d with local scripteldritch horrors
hacking changelog-d to support not just github but also forgejo and gerrit is a lot more complicated than it's worth, even moreso since the entire thing can just as well be done with ~60 lines of python. this new script is also much cheaper to instantiate (being python), so having it enabled in all shells is far less of a hassle. we've also adjusted existing release notes that referenced a gerrit cl to auto-link to the cl in question, making the diff a bit bigger closes https://git.lix.systems/lix-project/lix/issues/176 Change-Id: I8ba7dd0070aad9ba4474401731215fcf5d9d2130
2024-03-23Issue importer: do not notifyJade Lovelace
This uses the forgejo patch we have for dont_notify on issue creation on the api, and indeed does not notify, so we can simply run the script safely :D Fixes: https://git.lix.systems/lix-project/web-services/issues/38 Change-Id: I86bcbf9b4499b439b79b82af84ee7df0f8eb3298
2024-03-18issue importer: list issues that are *not* closed when finding existing issuesJade Lovelace
Turns out also, you cannot set the queue to 0 with any success. So we really should just like, prevent notifications in forgejo itself. Filed a bug for that: https://git.lix.systems/lix-project/web-services/issues/38 Change-Id: Ib96749f3159659182904963cab7b2ef88fc64442
2024-03-16Forgejo issue importerJade Lovelace
We needed a script to go yoink all the real NixOS/Nix issues from our mirror into the Lix repo. Change-Id: If8c8ebfb58634c675eae450454c0189288c6b18a
2024-03-04Merge pull request #9393 from hercules-ci/changelog-deldritch horrors
Automatically compile hand-written release notes with `changelog-d` (cherry picked from commit 928f0c13414d20c1af88b30bd6700fd730ee0bab) Change-Id: Ia0685835c52edf185b64dd696b19305746c077e5
2023-06-19maintainers: add note on marking PRs as draftValentin Gagarin
as discussed with maintainers team
2023-06-06Upload the manual to releases.nixos.orgEelco Dolstra
Fixes #8451.
2023-06-06Fix MIME typeEelco Dolstra
2023-06-06Upload fallback-paths.nix as part of the releaseEelco Dolstra
https://github.com/NixOS/nixpkgs/pull/235463
2023-05-31Bump versionEelco Dolstra
2023-05-30maintainers/upload-release.pl: Don't update nix-fallback-paths.nixEelco Dolstra
2023-05-02use headings instead of list itemsValentin Gagarin
this allows easier linking and a provides a bit more visual clarity
2023-05-02add procedure for 'idea approved' labelValentin Gagarin
2023-04-05Merge pull request #7579 from fricklerhandwerk/review-processThéophane Hufschmitt
review process: all PRs must be triaged
2023-04-05only triage non-trivial pull requestsValentin Gagarin
the team perceives triaging literally everything as too much overhead, and there is a desire to allow for more parallel action.
2023-03-28review process: all PRs must be triagedValentin Gagarin
in order to make the development process more transparent for everyone, all pull requests should go through the triage process before getting merged. this ensures that all team members are aware of what is going on, and that rationale for decisions is kept track of in the meeting notes for posterity. (ideally all that should go into the commit history, but this is a more invasive process change that needs further deliberation.) having all team members take at least a brief but conscious look at each change may also help with keeping our quality standards, as more reviewers are more likely to remind each other of our shared values.
2023-03-16Prioritize testing in the maintainers process docsJohn Ericson
PRs that don't increase our ongoing obligations (i.e. by adding new features) but do increase test coverage of existing features are good things to merge for the health of the project, and thus good to prioritize.
2023-03-13Merge pull request #7534 from fricklerhandwerk/maintainers-goalsValentin Gagarin
add objectives and tasks for Nix team
2023-03-06Merge pull request #7580 from fricklerhandwerk/nix-team-add-johnEelco Dolstra
add @Ericson2314 to the Nix team
2023-03-02Bump versionEelco Dolstra
2023-02-24incorporate feedback from maintainersValentin Gagarin
2023-02-24add objectives and tasks for Nix teamValentin Gagarin
so far there were no even remotely measurable objectives, only a general purpose statement. this change is intended to focus the team's work on what I (and many others I talked to) perceive to be the main pain point in the development process. Co-authored-by: solene.rapenne@tweag.io
2023-02-24Merge pull request #7412 from edolstra/release-processEelco Dolstra
Document the release process
2023-02-08Apply suggestions from code reviewRobert Hensing
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-01-18maintainers: Document backporting quirkRobert Hensing
Closes #7623
2023-01-12state priorities in triaging and discussion processValentin Gagarin
based on - Nix team decisions https://discourse.nixos.org/t/2022-11-11-nix-team-meeting-minutes-7/23451#planning-discussion-1 https://discourse.nixos.org/t/2022-12-02-nix-team-meeting-minutes-13/23731#discussion-3 - proposal to deal use labels more effectively https://discourse.nixos.org/t/improving-nix-developer-experience/21629 - documentation team decision to foster gauging interest using upvotes https://github.com/NixOS/nix/pull/7387
2023-01-12release-process: Add "create a backport label"Robert Hensing
2023-01-11add @Ericson2314 to the Nix teamValentin Gagarin
John has been part of every meeting since the beginning. He took on a lot of work on behalf of the team, and provided useful suggestions in discussions, advocating for stability, reasonable design decisions, and maintainable code. He was in general highly productive within the team process, and repeatedly helped us to keep focus on our stated goals. Specifically, early on he suggested to gather more experience with the team reviews in order derive our values for the project encode a more structured approach to guiding contributions, which is slowly bearing fruit these days. John is already the contributor with the most code changes to date (only topped by principal author Eelco), and is well-known to be highly knowledgeable about both high-level design and low-level internals of the code base. He has continued to offer high quality work during the team's operation, which resulted in many pull requests getting merged that further the team's goals. It is due time for John to be come an official team member and be granted merge access that he will surely exercise with the great care he is known for.
2022-12-12Apply suggestions from code reviewEelco Dolstra
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2022-12-07Apply suggestions from code reviewEelco Dolstra
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com> Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2022-12-06More tweaksEelco Dolstra
2022-12-06Mention DiscourseEelco Dolstra
2022-12-06Update maintainers/release-process.mdEelco Dolstra
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2022-12-06Update maintainers/release-process.mdEelco Dolstra
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2022-12-06Mention milestoneEelco Dolstra
2022-12-06Document the release processEelco Dolstra
2022-12-06Remove GPG-signing of releasesEelco Dolstra
This makes it easier for others to make releases, and probably few people care about GPG signatures anyway.
2022-12-05maintainers/README.md: Use CETEelco Dolstra
2022-12-05Fix typoEelco Dolstra
2022-11-21rewordValentin Gagarin
2022-11-21add maintainers' handbookValentin Gagarin
write down the process we have been developing and following so far. Co-Authored-By: Théophane Hufschmitt <theophane.hufschmitt@tweag.io> Co-Authored-By: John Ericson <John.Ericson@Obsidian.Systems>
2022-02-18Integrate push-docker.sh into the release scriptEelco Dolstra
This also makes sure that we get the Docker images from the same Hydra eval, rather than the latest build from job/nix/.../dockerImage, which may not be the same.
2022-02-18remove the manifest before creating themRok Garbas
2022-01-26fail earlyRok Garbas
2022-01-26typoRok Garbas