lix -

Age	Commit message (Collapse)	Author
2024-05-10	feat(libstore): print the first line of stdout of SSH in case of failure	Raito Bezarius
	In case of failure to connect as can be seen in https://buildbot.lix.systems/#/builders/39/builds/1386/steps/1/logs/stdio It is difficult to understand what happened, if we enabled the talkative verbose level, we could learn about the first line SSH sent us. In practice, this is not workable, we can just make it warn all the time. Change-Id: Iaaf56894060a58f2dfc78254bb60b1c43482f9bb Signed-off-by: Raito Bezarius <raito@lix.systems>
2024-04-27	libstore/ssh: shut	K900
	This is just logspam, and we have NIX_SSHOPTS for people that want the logspam. Change-Id: Ieff71473686f0661f9c53c212f8952dd2c9565c3
2024-03-18	libutil: make AutoCloseFD a better resource	eldritch horrors
	add a reset() method to close the wrapped fd instead of assigning magic constants. also make the from-fd constructor explicit so you can't accidentally assign the wrong magic constant, or even an unrelated integer that also just happens to be an fd by pure chance. Change-Id: I51311b0f6e040240886b5103d39d1794a6acc325
2024-03-17	Delete hasPrefix and hasSuffix from the codebase	Jade Lovelace
	These now have equivalents in the standard lib in C++20. This change was performed with a custom clang-tidy check which I will submit later. Executed like so: ninja -C build && run-clang-tidy -checks='-,nix-' -load=build/libnix-clang-tidy.so -p .. -fix ../tests \| tee -a clang-tidy-result Change-Id: I62679e315ff9e7ce72a40b91b79c3e9fc01b27e9
2024-03-04	Merge pull request #9293 from ThinkChaos/ssh-misc-improvments	eldritch horrors
	SSH small improvments (cherry picked from commit dcc49744ed0c3b91f905b0f3304d3ca700f9f717) Change-Id: Ie87910df3ab739d0ff983c085190da1d108e96e2
2023-06-13	Pass common ssh options in isMasterRunning	David McFarland

2023-05-16	Fix ControlMaster behaviour	Alexander Bantyev

2023-03-22	SSHMaster: pause logger to show password prompt	Alexander Bantyev
	Pause logger before starting SSH connections, and resume it after the connection is established, so that SSH password prompts are not erased by the logger's updates.
2022-10-22	Defer to SSH config files for ForwardAgent option	Austin Kiekintveld
	Currently, Nix passes `-a` when it runs commands on a remote machine via SSH, which disables agent forwarding. This causes issues when the `ForwardAgent` option is set in SSH config files, as the command line operation always overrides those. In particular, this causes issues if the command being run is `sudo` and the remote machine is configured with the equivalent of NixOS's `security.pam.enableSSHAgentAuth` option. Not allowing SSH agent forwarding can cause authentication to fail unexpectedly. This can currently be worked around by setting `NIX_SSHOPTS="-A"`, but we should defer to the options in the SSH config files to be least surprising for users.
2022-02-25	Remove std::string alias (for real this time)	Eelco Dolstra
	Also use std::string_view in a few more places.
2021-04-07	restoreSignals() + restoreAffinity() -> restoreProcessContext()	Eelco Dolstra

2021-02-25	distributed builds: load remote builder host key from the machines file	Graham Christensen
	This is already used by Hydra, and is very useful when materializing a remote builder list from service discovery. This allows the service discovery tool to only sync one file instead of two.
2020-02-14	Fix PR_SET_PDEATHSIG results in Broken pipe (#2395)	Tobias Möst
	The ssh client is lazily started by the first worker thread, that requires a ssh connection. To avoid the ssh client to be killed, when the worker process is stopped, do not set PR_SET_PDEATHSIG.
2019-12-13	Simplify	Eelco Dolstra

2019-12-12	libstore/ssh: Improve error message on failing `execvp`	Profpatsch
	If the `throw` is reached, this means that execvp into `ssh` wasn’t successful. We can hint at a usual problem, which is a missing `ssh` executable. Test with: ``` env PATH= ./result/bin/nix-copy-closure --builders '' unusedhost ``` and the bash version with ``` env PATH= ./result/bin/nix-copy-closure --builders '' localhost ```
2019-11-22	getEnv(): Return std::optional	Eelco Dolstra
	This allows distinguishing between an empty value and no value.
2019-02-05	Revert "Restore parent mount namespace before executing a child process"	Eelco Dolstra
	This reverts commit a0ef21262f4d5652bfb65cfacaec01d89c475a93. This doesn't work in 'nix run' and nix-shell because setns() fails in multithreaded programs, and Boehm GC mark threads are uncancellable. Fixes #2646.
2018-11-13	Restore parent mount namespace before executing a child process	Eelco Dolstra
	This ensures that they can't write to /nix/store. Fixes #2535.
2018-08-03	SSHMaster: Bypass SSH when connecting to localhost	Eelco Dolstra
	This is primarily useful for testing since it removes the need to have SSH working.
2018-03-20	SSHMaster: Optionally pass -v to ssh	Eelco Dolstra

2017-08-16	Disallow SSH host names starting with a dash	Eelco Dolstra

2017-07-30	Replace Unicode quotes in user-facing strings by ASCII	Jörg Thalheim
	Relevant RFC: NixOS/rfcs#4 $ ag -l \| xargs sed -i -e "/\"/s/’/'/g;/\"/s/‘/'/g"
2017-05-02	build-remote: Ugly hackery to get build logs to work	Eelco Dolstra
	The build hook mechanism expects build log output to go to file descriptor 4, so do that.
2017-03-21	Honor $NIX_SSHOPTS again	Eelco Dolstra
	NixOps needs this.
2017-03-03	SSHMaster: Make thread-safe	Eelco Dolstra

2017-03-03	Improve SSH handling	Eelco Dolstra
	* Unify SSH code in SSHStore and LegacySSHStore. * Fix a race starting the SSH master. We now wait synchronously for the SSH master to finish starting. This prevents the SSH clients from starting their own connections. * Don't use a master if max-connections == 1. * Add a "max-connections" store parameter. * Add a "compress" store parameter.