lix -

Age	Commit message (Collapse)	Author
2023-04-03	Stuctured command stability	John Ericson
	Prior to this, there was an ad-hoc whitelist in `main.cc`. Now, every command states its stability. In a future PR, we will adjust the manual to take advantage of this new information in the JSON. (It will be easier to do that once we have some experimental feature docs to link too; see #5930 and #7798.)
2023-03-31	Ensure all headers have `#pragma once` and are in API docs	John Ericson
	`///@file` makes them show up in the internal API dos. A tiny few were missing `#pragma once`.
2023-03-31	Extend internal API docs, part 2	John Ericson
	Picking up from #8111. Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
2023-03-20	Fix handling of experimental features mid-parse	John Ericson
	If we conditionally "declare" the argument, as we did before, based upon weather the feature is enabled, commands like nix --experimental-features=foo ... --thing-gated-on-foo won't work, because the experimental feature isn't enabled until after we start parsing. Instead, allow arguments to also be associated with experimental features (just as we did for builtins and settings), and then the command line parser will filter out the experimental ones. Since the effects of arguments (handler functions) are performed right away, we get the required behavior: earlier arguments can enable later arguments enabled! There is just one catch: we want to keep non-positional flags...non-positional. So if nix --experimental-features=foo ... --thing-gated-on-foo works, then nix --thing-gated-on-foo --experimental-features=foo ... should also work. This is not my favorite long-term solution, but for now this is implemented by delaying the requirement of needed experimental features until after all the arguments have been parsed.
2023-03-15	Make command infra less stateful and more regular	John Ericson
	Already, we had classes like `BuiltPathsCommand` and `StorePathsCommand` which provided alternative `run` virtual functions providing the implementation with more arguments. This was a very nice and easy way to make writing command; just fill in the virtual functions and it is fairly clear what to do. However, exception to this pattern were `Installable{,s}Command`. These two classes instead just had a field where the installables would be stored, and various side-effecting `prepare` and `load` machinery too fill them in. Command would wish out those fields. This isn't so clear to use. What this commit does is make those command classes like the others, with richer `run` functions. Not only does this restore the pattern making commands easier to write, it has a number of other benefits: - `prepare` and `load` are gone entirely! One command just hands just hands off to the next. - `useDefaultInstallables` because `defaultInstallables`. This takes over `prepare` for the one case that needs it, and provides enough flexiblity to handle `nix repl`'s idiosyncratic migration. - We can use `ref` instead of `std::shared_ptr`. The former must be initialized (so it is like Rust's `Box` rather than `Option<Box>`, This expresses the invariant that the installable are in fact initialized much better. This is possible because since we just have local variables not fields, we can stop worrying about the not-yet-initialized case. - Fewer lines of code! (Finally I have a large refactor that makes the number go down not up...) - `nix repl` is now implemented in a clearer way. The last item deserves further mention. `nix repl` is not like the other installable commands because instead working from once-loaded installables, it needs to be able to load them again and again. To properly support this, we make a new superclass `RawInstallablesCommand`. This class has the argument parsing and completion logic, but does not hand off parsed installables but instead just the raw string arguments. This is exactly what `nix repl` needs, and allows us to instead of having the logic awkwardly split between `prepare`, `useDefaultInstallables,` and `load`, have everything right next to each other. I think this will enable future simplifications of that argument defaulting logic, but I am saving those for a future PR --- best to keep code motion and more complicated boolean expression rewriting separate steps. The "diagnostic ignored `-Woverloaded-virtual`" pragma helps because C++ doesn't like our many `run` methods. In our case, we don't mind the shadowing it all --- it is intentional that the derived class only provides a `run` method, and doesn't call any of the overridden `run` methods. Helps with https://github.com/NixOS/rfcs/pull/134
2022-07-11	Fix flake input completion for `InstallablesCommand`s	Naïm Favier
	Defers completion of flake inputs until the whole command line is parsed so that we know what flakes we need to complete the inputs of. Previously, `nix build flake --update-input <Tab>` always behaved like `nix build . --update-input <Tab>`.
2022-05-31	repl: `--option pure-eval true` actually enables pure eval mode	Maximilian Bosch
	To quote Eelco in #5867: > Unfortunately we can't do > > evalSettings.pureEval.setDefault(false); > > because then we have to do the same in main.cc (where > pureEval is set to true), and that would allow pure-eval > to be disabled globally from nix.conf. Instead, a command should specify that it should be impure by default. Then, `evalSettings.pureEval` will be set to `false;` unless it's overridden by e.g. a CLI flag. In that case it's IMHO OK to be (theoretically) able to override `pure-eval` via `nix.conf` because it doesn't have an effect on commands where `forceImpureByDefault` returns `false` (i.e. everything where pure eval actually matters). Closes #5867
2022-02-25	Remove std::string alias (for real this time)	Eelco Dolstra
	Also use std::string_view in a few more places.
2021-12-22	Don't insert spaces when completing attribute paths	Naïm Favier

2021-09-14	Add "nix profile rollback" command	Eelco Dolstra

2021-09-13	nix --help: Display help using lowdown instead of man	Eelco Dolstra
	Fixes #4476. Fixes #5231.
2021-02-26	nix flake update: Recreate the lock file	Eelco Dolstra
	This is probably what most people expect it to do. Fixes #3781. There is a new command 'nix flake lock' that has the old behaviour of 'nix flake update', i.e. it just adds missing lock file entries unless overriden using --update-input.
2021-02-24	Initialize plugins after handling initial command line flags	Shea Levy
	This is technically a breaking change, since attempting to set plugin files after the first non-flag argument will now throw an error. This is acceptable given the relative lack of stability in a plugin interface and the need to tie the knot somewhere once plugins can actually define new subcommands.
2021-02-07	Support --no-net for backwards compatibility	Eelco Dolstra

2021-01-27	Remove mkFlag()	Eelco Dolstra

2021-01-25	Group common options	Eelco Dolstra

2021-01-25	Make '--help' do the same as 'help' (i.e. show a manpage)	Eelco Dolstra

2021-01-08	Support binary unit prefixes in command line arguments	Eelco Dolstra

2021-01-08	string2Int(): Return std::optional	Eelco Dolstra

2021-01-08	Remove unused mkFlag1	Eelco Dolstra

2021-01-08	Remove mkFlag integer specialisation	Eelco Dolstra

2021-01-08	Remove mkIntFlag	Eelco Dolstra

2020-12-23	Command: Remove examples()	Eelco Dolstra

2020-12-21	Move doc() to Args	Eelco Dolstra

2020-12-03	Add deprecated aliases for renamed commands	Eelco Dolstra

2020-10-09	Add a description in the completion outputs	regnat
	Make nix output completions in the form `completion\tdescription`. This can't be used by bash (afaik), but other shells like zsh or fish can display it along the completion choices
2020-09-25	expectArg(): Respect the 'optional' flag	Eelco Dolstra

2020-08-20	Allow 'nix' subcommands to provide docs in Markdown format	Eelco Dolstra

2020-08-17	Add 'nix dump-args' to dump all commands/flags for manpage generation	Eelco Dolstra

2020-06-26	Merge remote-tracking branch 'origin/master' into flakes	Eelco Dolstra

2020-06-18	Revert the `enum struct` change	John Ericson
	Not a regular git revert as there have been many merges and things.
2020-06-18	Merge branch 'enum-class' into no-hash-type-unknown	John Ericson

2020-06-18	Merge remote-tracking branch 'upstream/master' into enum-class	John Ericson

2020-06-08	Add completion for --update-input	Eelco Dolstra

2020-06-04	Merge remote-tracking branch 'origin/master' into flakes	Eelco Dolstra

2020-06-04	Make 'nix dev-shell' a deprecated alias for 'nix develop'	Eelco Dolstra

2020-06-02	Fix to-base --type handler to correctly set std::optional flag	John Ericson
	Now that we have a separate flag function, also describe why it is optional.
2020-05-28	Merge branch 'master' of github.com:NixOS/nix into enum-class	Carlo Nucera

2020-05-11	When completing flakerefs, only return directories	Eelco Dolstra

2020-05-11	Cleanup	Eelco Dolstra

2020-05-10	Add completion for paths	Eelco Dolstra

2020-05-10	nix: Implement basic bash completion	Eelco Dolstra

2020-05-05	nix --help: Group commands	Eelco Dolstra

2020-05-04	Flag: Use designated initializers	Eelco Dolstra

2020-03-29	Use `enum struct` and drop prefixes	John Ericson
	This does a few enums; the rest will be gotten in subsequent commits.
2019-12-05	Initialize Command::_name	Eelco Dolstra
	(cherry picked from commit d0a769cb061a13ad880c76e5ea69a76150439853)
2019-12-05	Make subcommand construction in MultiCommand lazy	Eelco Dolstra
	(cherry picked from commit a0de58f471c9087d8e6cc60a6078f9940a125b15)
2019-12-05	Move Command and MultiCommand to libutil	Eelco Dolstra
	(cherry picked from commit f70434b1fbbdb0e188718f0c55a8156a7aa08744)
2019-11-10	Remove unneeded semicolons	John Ericson

2017-10-24	nix: Respect -I, --arg, --argstr	Eelco Dolstra
	Also, random cleanup to argument handling.