lix -

Age	Commit message (Collapse)	Author
2024-08-26	treewide: fix a bunch of lints	Jade Lovelace
	Fixes: - Identifiers starting with _ are prohibited - Some driveby header dependency cleaning which wound up with doing some extra fixups. - Fucking C style casts, man. C++ made these 1000% worse by letting you also do memory corruption with them with references. - Remove casts to Expr * where ExprBlackHole is an incomplete type by introducing an explicitly-cast eBlackHoleAddr as Expr . - An incredibly illegal cast of the text bytes of the StorePath hash into a size_t directly. You can't DO THAT. Replaced with actually parsing the hash so we get 100% of the bits being entropy, then memcpying the start of the hash. If this shows up in a profile we should just make the hash parser faster with a lookup table or something sensible like that. - This horrendous bit of UB which I thankfully slapped a deprecation warning on, built, and it didn't trigger anywhere so it was dead code and I just deleted it. But holy crap you cannot* do that. inline void mkString(const Symbol & s) { mkString(((const std::string &) s).c_str()); } - Some wrong lints. Lots of wrong macro lints, one wrong suspicious-sizeof lint triggered by the template being instantiated with only pointers, but the calculation being correct for both pointers and not-pointers. - Exceptions in destructors strike again. I tried to catch the exceptions that might actually happen rather than all the exceptions imaginable. We can let the runtime hard-kill it on other exceptions imo. Change-Id: I71761620846cba64d66ee7ca231b20c061e69710
2024-05-29	util.hh: Delete remaining file and clean up headers	Tom Hubrecht
	Change-Id: Ic1f68e6af658e94ef7922841dd3ad4c69551ef56
2023-04-07	Finish converting existing comments for internal API docs (#8146)	John Ericson
	* Finish converting existing comments for internal API docs 99% of this was just reformatting existing comments. Only two exceptions: - Expanded upon `BuildResult::status` compat note - Split up file-level `symbol-table.hh` doc comments to get per-definition docs Also fixed a few whitespace goofs, turning leading tabs to spaces and removing trailing spaces. Picking up from #8133 * Fix two things from comments * Use triple-backtick not indent for `dumpPath` * Convert GNU-style `\`..'` quotes to markdown style in API docs This will render correctly.
2023-03-31	Ensure all headers have `#pragma once` and are in API docs	John Ericson
	`///@file` makes them show up in the internal API dos. A tiny few were missing `#pragma once`.
2023-03-31	Extend internal API docs, part 2	John Ericson
	Picking up from #8111. Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
2019-11-10	Fix extra ; warnings involving MakeError	John Ericson

2017-10-09	Fix a hang in ThreadPool	Eelco Dolstra
	The worker threads could exit prematurely if they finished processing all items while the main thread was still adding items. In particular, this caused hanging nix-store --serve processes in the build farm. Also, process items from the main thread.
2017-09-08	ThreadPool: On exception, interrupt the other worker threads	Eelco Dolstra

2017-09-08	ThreadPool: Improve exception handling	Eelco Dolstra
	In particular, process() won't return as long as there are active items. This prevents work item lambdas from referring to stack frames that no longer exist.
2017-07-03	processGraph(): Call getEdges in parallel	Eelco Dolstra

2016-07-21	Fix assertion failure in ThreadPool::enqueue()	Eelco Dolstra

2016-04-22	Factor out parallel processing of work items that have dependencies	Eelco Dolstra

2016-04-22	ThreadPool: Start doing work as soon as work items are enqueued	Eelco Dolstra

2016-03-29	Add "nix verify-paths" command	Eelco Dolstra
	Unlike "nix-store --verify-path", this command verifies signatures in addition to store path contents, is multi-threaded (especially useful when verifying binary caches), and has a progress indicator. Example use: $ nix verify-paths --store https://cache.nixos.org -r $(type -p thunderbird) ... [17/132 checked] checking ‘/nix/store/rawakphadqrqxr6zri2rmnxh03gqkrl3-autogen-5.18.6’