aboutsummaryrefslogtreecommitdiff
path: root/src/libutil
AgeCommit message (Collapse)Author
2020-12-10Add lvlNotice log levelEelco Dolstra
This is like syslog's LOG_NOTICE: "normal, but significant, condition".
2020-12-09libstore/openStore: fix stores with IPv6 addressesMaximilian Bosch
In `nixStable` (2.3.7 to be precise) it's possible to connect to stores using an IPv6 address: nix ping-store --store ssh://root@2001:db8::1 This is also useful for `nixops(1)` where you could specify an IPv6 address in `deployment.targetHost`. However, this behavior is broken on `nixUnstable` and fails with the following error: $ nix store ping --store ssh://root@2001:db8::1 don't know how to open Nix store 'ssh://root@2001:db8::1' This happened because `openStore` from `libstore` uses the `parseURL` function from `libfetchers` which expects a valid URL as defined in RFC2732. However, this is unsupported by `ssh(1)`: $ nix store ping --store 'ssh://root@[2001:db8::1]' cannot connect to 'root@[2001:db8::1]' This patch now allows both ways of specifying a store (`root@2001:db8::1`) and also `root@[2001:db8::1]` since the latter one is useful to pass query parameters to the remote store. In order to achieve this, the following changes were made: * The URL regex from `url-parts.hh` now allows an IPv6 address in the form `2001:db8::1` and also `[2001:db8::1]`. * In `libstore`, a new function named `extractConnStr` ensures that a proper URL is passed to e.g. `ssh(1)`: * If a URL looks like either `[2001:db8::1]` or `root@[2001:db8::1]`, the brackets will be removed using a regex. No additional validation is done here as only strings parsed by `parseURL` are expected. * In any other case, the string will be left untouched. * The rules above only apply for `LegacySSHStore` and `SSHStore` (a.k.a `ssh://` and `ssh-ng://`). Unresolved questions: * I'm not really sure whether we want to allow both variants of IPv6 addresses in the URL parser. However it should be noted that both seem to be possible according to RFC2732: > This document incudes an update to the generic syntax for Uniform > Resource Identifiers defined in RFC 2396 [URL]. It defines a syntax > for IPv6 addresses and allows the use of "[" and "]" within a URI > explicitly for this reserved purpose. * Currently, it's not supported to specify a port number behind the hostname, however it seems as this is not really supported by the URL parser. Hence, this is probably out of scope here.
2020-12-03Add deprecated aliases for renamed commandsEelco Dolstra
2020-12-02Add forgotten `override` annotationregnat
2020-12-02read(): Use char * instead of unsigned char *Eelco Dolstra
This gets rid of some pointless casts.
2020-12-02Sink: Use std::string_viewEelco Dolstra
2020-12-02writeFull/writeFile: Use std::string_viewEelco Dolstra
2020-12-01replaceStrings(): Use std::string_viewEelco Dolstra
2020-12-01Macro hygieneEelco Dolstra
2020-12-01Macro hygieneEelco Dolstra
2020-11-26archive: disable preallocate-contents by defaultDominique Martinet
using fallocate() to preallocate files space does more harm than good: - breaks compression on btrfs - has been called "not the right thing to do" by xfs developers (because delayed allocation that most filesystems implement leads to smarter allocation than what the filesystem needs to do if we upfront fallocate files)
2020-11-26Ask for confirmation before allowing flake Nix configuration settingsEelco Dolstra
2020-11-16filterANSIEscapes(): Handle UTF-8 charactersEelco Dolstra
2020-11-11usage example locationBen Burdette
2020-11-10Fix stack overflow introduced in #4206Ricardo M. Correia
2020-11-09Fix appending to Setting<StringSet>Eelco Dolstra
Fixes: warning: unknown setting 'extra-sandbox-paths'
2020-10-30Fix memory corruption caused by GC-invisible coroutine stacksRobert Hensing
Crucially this introduces BoehmGCStackAllocator, but it also adds a bunch of wiring to avoid making libutil depend on bdw-gc. Part of the solutions for #4178, #4200
2020-10-30Fix testEelco Dolstra
2020-10-29Fix assertion failure in tab completion for --optionEelco Dolstra
2020-10-29Generalize extra-* settingsEelco Dolstra
This removes the extra-substituters and extra-sandbox-paths settings and instead makes every array setting extensible by setting "extra-<name> = <value>" in the configuration file or passing "--<name> <value>" on the command line.
2020-10-29Merge pull request #4198 from mkenigs/capitalize-JSONEelco Dolstra
Capitalize JSON for consistency
2020-10-28Capitalize JSON for consistencyMatthew Kenigsberg
2020-10-28ConsistencyEelco Dolstra
2020-10-26BaseSetting<StringMap>::set(): Don't append to previous valueEelco Dolstra
2020-10-26Move ExplicitEelco Dolstra
2020-10-15Add missing include for MAX_PATHJohn Ericson
And remove one that we didn't actually need to add
2020-10-15Merge remote-tracking branch 'upstream/master' into fix-and-ci-static-buildsJohn Ericson
2020-10-11Split out `commonChildInit`John Ericson
2020-10-09Completions::add(): Guard against newlinesEelco Dolstra
2020-10-09Merge pull request #4128 from tweag/extended-completionsEelco Dolstra
Add a zsh completion script
2020-10-09Merge remote-tracking branch 'upstream/master' into fix-and-ci-static-buildsJohn Ericson
2020-10-09Remove LazyEelco Dolstra
This fixes a crash during startup when compiling Nix as a single compilation unit.
2020-10-09writeFile(): Add error context to writeFull() failureEelco Dolstra
Issue #4092.
2020-10-09Add a description in the completion outputsregnat
Make nix output completions in the form `completion\tdescription`. This can't be used by bash (afaik), but other shells like zsh or fish can display it along the completion choices
2020-10-07Serialize exceptions from the sandbox process to the parentEelco Dolstra
Fixes #4118.
2020-10-07FormattingEelco Dolstra
2020-10-06libfetchers/github: allow slashes in refsMaximilian Bosch
Refs #4061
2020-10-06Remove static variable name clashesEelco Dolstra
This was useful for an experiment with building Nix as a single compilation unit. It's not very useful otherwise but also doesn't hurt...
2020-10-06Factor out common showBytes()Eelco Dolstra
2020-10-06Add missing #pragma onceEelco Dolstra
2020-10-05Fix s3:// storeEelco Dolstra
Fixes https://github.com/NixOS/nixos-org-configurations/issues/123.
2020-09-29Merge branch 'master' into access-tokensKevin Quick
2020-09-25Merge remote-tracking branch 'origin/master' into github-api-tokenGregory Hale
2020-09-25stdout_ -> coutJohn Ericson
Better to get creative than just sprinkle arbitrary underscores.
2020-09-25expectArg(): Respect the 'optional' flagEelco Dolstra
2020-09-24Support StringMap configuration settings.Kevin Quick
Allows Configuration values that are space-separated key=value pairs.
2020-09-23Merge pull request #4054 from edolstra/fix-4021Eelco Dolstra
registerOutputs(): Don't call canonicalisePathMetaData() twice
2020-09-23lstat() cleanupEelco Dolstra
2020-09-23libutil/archive: add preallocate-contents optionDominique Martinet
Make archive preallocation (fallocate) optional because some filesystems like btrfs do not behave as expected with fallocate. See #3550.
2020-09-22Merge branch 'add-ca-to-store' of https://github.com/hercules-ci/nixEelco Dolstra
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 12:19:00 +0000