lix -

Age	Commit message (Collapse)	Author
2023-03-15	Make command infra less stateful and more regular	John Ericson
	Already, we had classes like `BuiltPathsCommand` and `StorePathsCommand` which provided alternative `run` virtual functions providing the implementation with more arguments. This was a very nice and easy way to make writing command; just fill in the virtual functions and it is fairly clear what to do. However, exception to this pattern were `Installable{,s}Command`. These two classes instead just had a field where the installables would be stored, and various side-effecting `prepare` and `load` machinery too fill them in. Command would wish out those fields. This isn't so clear to use. What this commit does is make those command classes like the others, with richer `run` functions. Not only does this restore the pattern making commands easier to write, it has a number of other benefits: - `prepare` and `load` are gone entirely! One command just hands just hands off to the next. - `useDefaultInstallables` because `defaultInstallables`. This takes over `prepare` for the one case that needs it, and provides enough flexiblity to handle `nix repl`'s idiosyncratic migration. - We can use `ref` instead of `std::shared_ptr`. The former must be initialized (so it is like Rust's `Box` rather than `Option<Box>`, This expresses the invariant that the installable are in fact initialized much better. This is possible because since we just have local variables not fields, we can stop worrying about the not-yet-initialized case. - Fewer lines of code! (Finally I have a large refactor that makes the number go down not up...) - `nix repl` is now implemented in a clearer way. The last item deserves further mention. `nix repl` is not like the other installable commands because instead working from once-loaded installables, it needs to be able to load them again and again. To properly support this, we make a new superclass `RawInstallablesCommand`. This class has the argument parsing and completion logic, but does not hand off parsed installables but instead just the raw string arguments. This is exactly what `nix repl` needs, and allows us to instead of having the logic awkwardly split between `prepare`, `useDefaultInstallables,` and `load`, have everything right next to each other. I think this will enable future simplifications of that argument defaulting logic, but I am saving those for a future PR --- best to keep code motion and more complicated boolean expression rewriting separate steps. The "diagnostic ignored `-Woverloaded-virtual`" pragma helps because C++ doesn't like our many `run` methods. In our case, we don't mind the shadowing it all --- it is intentional that the derived class only provides a `run` method, and doesn't call any of the overridden `run` methods. Helps with https://github.com/NixOS/rfcs/pull/134
2022-01-18	Add command 'nix store copy-log'	Eelco Dolstra
	Fixes #5222.
2022-01-18	Factor out --from / --to logic	Eelco Dolstra

2021-09-27	run(): Move	Eelco Dolstra

2021-07-22	copyPaths: Pass store by reference	Eelco Dolstra

2021-05-17	Enfore the use of properly built paths in libcmd	regnat
	Replace `DerivedPathWithHints` by a new `BuiltPath` type that serves as a proof that the corresponding path has been built.
2021-02-25	Use `RealisedPath`s in `copyPaths`	regnat
	That way we can copy the realisations too (in addition to the store paths themselves)
2021-01-28	Add a new Cmd type working on RealisedPaths	regnat
	Where a `RealisedPath` is a store path with its history, meaning either an opaque path for stuff that has been directly added to the store, or a `Realisation` for stuff that has been built by a derivation This is a low-level refactoring that doesn't bring anything by itself (except a few dozen extra lines of code :/ ), but raising the abstraction level a bit is important on a number of levels: - Commands like `nix build` have to query for the realisations after the build is finished which is fragile (see 27905f12e4a7207450abe37c9ed78e31603b67e1 for example). Having them oprate directly at the realisation level would avoid that - Others like `nix copy` currently operate directly on (built) store paths, but need a bit more information as they will need to register the realisations on the remote side
2021-01-13	Convert option descriptions to Markdown	Eelco Dolstra

2020-12-21	Add 'nix copy' manpage	Eelco Dolstra

2020-10-06	Remove static variable name clashes	Eelco Dolstra
	This was useful for an experiment with building Nix as a single compilation unit. It's not very useful otherwise but also doesn't hurt...
2020-07-15	nix: Fix examples	Eelco Dolstra

2020-07-15	Clean up RealiseMode	Eelco Dolstra

2020-06-17	Merge remote-tracking branch 'origin/master' into flakes	Eelco Dolstra

2020-06-16	Remove StorePath::clone() and related functions	Eelco Dolstra

2020-05-05	Merge remote-tracking branch 'origin/master' into flakes	Eelco Dolstra

2020-05-05	nix --help: Group commands	Eelco Dolstra

2020-05-04	Flag: Use designated initializers	Eelco Dolstra

2020-04-29	nix copy: Build derivations	Eelco Dolstra
	Fixes $ nix copy .#hydraJobs.vendoredCrates --to /tmp/nix error: path '/nix/store/...' is not valid
2020-04-29	nix copy: Move --from / --to check	Eelco Dolstra
	This means you now get an error message before stuff gets built: $ nix copy .#hydraJobs.vendoredCrates error: you must pass '--from' and/or '--to' Try 'nix --help' for more information.
2019-12-10	Make the Store API more type-safe	Eelco Dolstra
	Most functions now take a StorePath argument rather than a Path (which is just an alias for std::string). The StorePath constructor ensures that the path is syntactically correct (i.e. it looks like <store-dir>/<base32-hash>-<name>). Similarly, functions like buildPaths() now take a StorePathWithOutputs, rather than abusing Path by adding a '!<outputs>' suffix. Note that the StorePath type is implemented in Rust. This involves some hackery to allow Rust values to be used directly in C++, via a helper type whose destructor calls the Rust type's drop() function. The main issue is the dynamic nature of C++ move semantics: after we have moved a Rust value, we should not call the drop function on the original value. So when we move a value, we set the original value to bitwise zero, and the destructor only calls drop() if the value is not bitwise zero. This should be sufficient for most types. Also lots of minor cleanups to the C++ API to make it more modern (e.g. using std::optional and std::string_view in some places).
2019-12-05	Make subcommand construction in MultiCommand lazy	Eelco Dolstra
	(cherry picked from commit a0de58f471c9087d8e6cc60a6078f9940a125b15)
2019-07-10	nix copy: Rename --substitute to --substitute-on-destination	Eelco Dolstra
	'--substitute' was being shadowed by the regular '--substitute' (the short-hand for '--option substitute true'). Fixes #2983.
2018-09-27	Don't talk about a "current folder build output"	Eelco Dolstra
	Presumably this refers to ./default.nix but the support for that in 'nix' is tenuous. Also folders are a Mac thing.
2018-08-02	s3 binary cache: support specifying an endpoint	Graham Christensen
	Works for uploading and not downloading.
2018-03-30	nix copy: add an example with S3	zimbatm
	I couldn't find a good example how to use it with non-us-east-1 buckets.
2018-02-21	nix-copy: fix examples	Jörg Thalheim
	maybe a left-over from nix-store -r ?
2017-10-24	nix: Respect -I, --arg, --argstr	Eelco Dolstra
	Also, random cleanup to argument handling.
2017-09-27	nix copy: make recursive by default	Eelco Dolstra

2017-09-08	nix copy: Add --substitute flag	Eelco Dolstra

2017-09-08	nix copy: Add examples	Eelco Dolstra

2017-09-06	nix build: Add --out-link and --no-link options	Eelco Dolstra

2017-08-16	nix copy: Add --no-check-sigs flag	Eelco Dolstra

2017-07-30	Replace Unicode quotes in user-facing strings by ASCII	Jörg Thalheim
	Relevant RFC: NixOS/rfcs#4 $ ag -l \| xargs sed -i -e "/\"/s/’/'/g;/\"/s/‘/'/g"
2017-03-16	nix copy: Make -r option use the "from" store	Eelco Dolstra
	Previously, we tried to compute the closure in the local store, which obviously doesn't work.
2017-03-16	copyPaths(): Use queryValidPaths() to reduce SSH latency	Eelco Dolstra

2016-11-10	build-remote: Implement in C++	Shea Levy

2016-09-02	Merge openStore and openStoreAt with default arguments	Shea Levy

2016-05-04	Add a copyStorePath() utility function	Eelco Dolstra

2016-04-25	Improved logging abstraction	Eelco Dolstra
	This also gets rid of --log-type, since the nested log type isn't useful in a multi-threaded situation, and nobody cares about the "pretty" log type.
2016-04-22	Factor out parallel processing of work items that have dependencies	Eelco Dolstra

2016-04-22	nix copy: Parallelise	Eelco Dolstra

2016-04-22	Add "nix copy" command	Eelco Dolstra
	This replaces nix-push. For example, $ nix copy --to file:///tmp/cache -r $(type -p firefox) copies the closure of firefox to the specified binary cache. And $ nix copy --from file:///tmp/cache --to s3://my-cache /nix/store/abcd... copies between two binary caches. It will also replace nix-copy-closure, once we have an SSHStore class, e.g. $ nix copy --from ssh://alice@machine /nix/store/abcd...