lix -

Age	Commit message (Collapse)	Author
2024-07-01	tree-wide: unify progress bar inactive and paused states	Alois Wohlschlager
	Previously, the progress bar had two subtly different states in which the bar would not actually render, both with their own shortcomings: inactive (which was irreversible) and paused (reversible, but swallowing logs). Furthermore, there was no way of resetting the statistics, so a very bad solution was implemented (243c0f18dae2a08ea0e46f7ff33277c63f7506d7) that would create a new logger for each line of the repl, leaking the previous one and discarding the value of printBuildLogs. Finally, if stderr was not attached to a TTY, the update thread was started even though the logger was not active, violating the invariant required by the destructor (which is not observed because the logger is leaked). In this commit, the two aforementioned states are unified into a single one, which can be exited again, correctly upholds the invariant that the update thread is only running while the progress bar is active, and does not swallow logs. The latter change in behavior is not expected to be a problems in the rare cases where the paused state was used before, since other loggers (like the simple one) don't exhibit it anyway. The startProgressBar/stopProgressBar API is removed due to being a footgun, and a new method for properly resetting the progress is added. Co-Authored-By: Qyriad <qyriad@qyriad.me> Change-Id: I2b7c3eb17d439cd0c16f7b896cfb61239ac7ff3a
2024-06-20	de-inheritance CmdEdit for InstallableValueCommand	Qyriad
	Change-Id: If85ea78954a45470b0b25c08dc7d40bfebd53610
2024-05-29	util.{hh,cc}: Split out current-process.{hh,cc}	Tom Hubrecht
	Change-Id: I77095b9d37e85310075bada7a076ccd482c28e47
2023-03-16	Move value-only methods to `InstallableValue`	John Ericson
	These methods would previously fail on the other `Installable`s, so moving them to this class is more correct as to where they actually work. Additionally, a `InstallableValueCommand` is created to make it easier (or rather no worse than before) to write commands that just work on `InstallableValue`s. Besides being a cleanup to avoid failing default methods, this gets us closer to https://github.com/NixOS/rfcs/pull/134.
2023-03-15	Make command infra less stateful and more regular	John Ericson
	Already, we had classes like `BuiltPathsCommand` and `StorePathsCommand` which provided alternative `run` virtual functions providing the implementation with more arguments. This was a very nice and easy way to make writing command; just fill in the virtual functions and it is fairly clear what to do. However, exception to this pattern were `Installable{,s}Command`. These two classes instead just had a field where the installables would be stored, and various side-effecting `prepare` and `load` machinery too fill them in. Command would wish out those fields. This isn't so clear to use. What this commit does is make those command classes like the others, with richer `run` functions. Not only does this restore the pattern making commands easier to write, it has a number of other benefits: - `prepare` and `load` are gone entirely! One command just hands just hands off to the next. - `useDefaultInstallables` because `defaultInstallables`. This takes over `prepare` for the one case that needs it, and provides enough flexiblity to handle `nix repl`'s idiosyncratic migration. - We can use `ref` instead of `std::shared_ptr`. The former must be initialized (so it is like Rust's `Box` rather than `Option<Box>`, This expresses the invariant that the installable are in fact initialized much better. This is possible because since we just have local variables not fields, we can stop worrying about the not-yet-initialized case. - Fewer lines of code! (Finally I have a large refactor that makes the number go down not up...) - `nix repl` is now implemented in a clearer way. The last item deserves further mention. `nix repl` is not like the other installable commands because instead working from once-loaded installables, it needs to be able to load them again and again. To properly support this, we make a new superclass `RawInstallablesCommand`. This class has the argument parsing and completion logic, but does not hand off parsed installables but instead just the raw string arguments. This is exactly what `nix repl` needs, and allows us to instead of having the logic awkwardly split between `prepare`, `useDefaultInstallables,` and `load`, have everything right next to each other. I think this will enable future simplifications of that argument defaulting logic, but I am saving those for a future PR --- best to keep code motion and more complicated boolean expression rewriting separate steps. The "diagnostic ignored `-Woverloaded-virtual`" pragma helps because C++ doesn't like our many `run` methods. In our case, we don't mind the shadowing it all --- it is intentional that the derived class only provides a `run` method, and doesn't call any of the overridden `run` methods. Helps with https://github.com/NixOS/rfcs/pull/134
2023-02-20	Split out `CmdRepl` and `editorFor`	John Ericson
	The REPL itself and the `nix repl` CLI are conceptually different things, and thus deserve to be in different files.
2022-04-21	replace most Pos objects/ptrs with indexes into a position table	pennae
	Pos objects are somewhat wasteful as they duplicate the origin file name and input type for each object. on files that produce more than one Pos when parsed this a sizeable waste of memory (one pointer per Pos). the same goes for ptr<Pos> on 64 bit machines: parsing enough source to require 8 bytes to locate a position would need at least 8GB of input and 64GB of expression memory. it's not likely that we'll hit that any time soon, so we can use a uint32_t index to locate positions instead.
2022-04-21	don't use full Pos for findPackageFilename/editorFor	pennae
	only file and line of the returned position were ever used, it wasn't actually used a position. as such we may as well use a path+int pair for only those two values and remove a use of Pos that would not work well with a position table.
2021-07-19	Rename findDerivationFilename -> findPackageFilename	Robert Hensing
	It does not operate on a derivation and does not return a derivation path. Instead it works at the language level, where a distinct term "package" is more appropriate to distinguish the parent object of `meta.position`; an attribute which doesn't even make it into the derivation.
2021-04-07	restoreSignals() + restoreAffinity() -> restoreProcessContext()	Eelco Dolstra

2020-12-21	Add 'nix edit' manpage	Eelco Dolstra

2020-10-06	Remove static variable name clashes	Eelco Dolstra
	This was useful for an experiment with building Nix as a single compilation unit. It's not very useful otherwise but also doesn't hurt...
2020-07-17	nix edit: call restoreSignals() before `execvp`-ing the $EDITOR	Lars Mühmel
	Currently resizing of the terminal doesn't play nicely with nix edit when using kakoune as the editor, as it relies on the SIGWINCH signal which is trapped by nix. How this is not a problem with e.g. vim is beyond me. Virtually all other exec* calls are following a call to restoreSignals(). This commit adds this behavior to nix edit as well.
2020-07-15	nix: Fix examples	Eelco Dolstra

2020-05-05	nix --help: Group commands	Eelco Dolstra

2020-03-24	nix edit: Support non-derivation attributes	Eelco Dolstra
	E.g. $ nix edit .#nixosConfigurations.bla now works. (cherry picked from commit d2032edb2f86e955a8a7724a27c0c3225f386500)
2019-12-05	Make subcommand construction in MultiCommand lazy	Eelco Dolstra
	(cherry picked from commit a0de58f471c9087d8e6cc60a6078f9940a125b15)
2019-10-28	editorFor: take a pos object instead	zimbatm

2019-10-28	libexpr: findDerivationFilename return Pos instead of tuple	zimbatm

2019-10-23	libexpr: add findDerivationFilename	zimbatm
	extract the derivation to filename:lineno heuristic
2019-10-23	libutil: add editorFor heuristic	zimbatm

2019-09-22	Don't catch exceptions by value	Eelco Dolstra
	(cherry picked from commit 893be6f5e36abb58bbaa9c49055a5218114dd514)
2019-02-05	Revert "Restore parent mount namespace before executing a child process"	Eelco Dolstra
	This reverts commit a0ef21262f4d5652bfb65cfacaec01d89c475a93. This doesn't work in 'nix run' and nix-shell because setns() fails in multithreaded programs, and Boehm GC mark threads are uncancellable. Fixes #2646.
2018-11-13	Restore parent mount namespace before executing a child process	Eelco Dolstra
	This ensures that they can't write to /nix/store. Fixes #2535.
2018-04-17	Handle arguments in $EDITOR	Eelco Dolstra
	Fixes #2079.
2017-12-14	edit: Catch stoi exceptions from line number parsing	Ben Gamari

2017-08-29	nix edit / log: Operate on a single Installable	Eelco Dolstra

2017-08-29	nix run: Flush the progress bar before starting the command	Eelco Dolstra

2017-07-30	Replace Unicode quotes in user-facing strings by ASCII	Jörg Thalheim
	Relevant RFC: NixOS/rfcs#4 $ ag -l \| xargs sed -i -e "/\"/s/’/'/g;/\"/s/‘/'/g"
2017-05-08	Add "nix edit" command	Eelco Dolstra
	This is a little convenience command that opens the Nix expression of the specified package. For example, nix edit nixpkgs.perlPackages.Moose opens <nixpkgs/pkgs/top-level/perl-packages.nix> in $EDITOR (at the right line number for some editors). This requires the package to have a meta.position attribute.