lix -

Age	Commit message (Collapse)	Author
2023-03-27	Fix more profile dirs in docs	John Ericson
	Picking up where #8078 left off.
2023-03-27	Merge pull request #7763 from obsidiansystems/installable-wide-info	Eelco Dolstra
	Stratify `ExtraPathInfo` along `Installable` hierarchy
2023-03-27	Merge pull request #8084 from edolstra/store-docs	Eelco Dolstra
	Auto-generate store documentation
2023-03-27	Merge pull request #7609 from obsidiansystems/hide-experimental-settings	John Ericson
	Hide experimental settings
2023-03-26	Catch eval errors in `hasContent`	oxalica
	`legacyPackages` of nixpkgs trigger eval errors in `hasContent`, causing the whole `legacyPackages` being skipped. We should treat it as has-content in that case.
2023-03-24	Stratify `ExtraPathInfo` along `Installable` hierarchy	John Ericson
	Instead of having a bunch of optional fields, have a few subclasses which can have mandatory fields. Additionally, the new `getExtraPathInfo`, and `nixpkgsFlakeRef`, are moved to `InstallableValue`. I did these things because https://github.com/NixOS/rfcs/pull/134 ; with these things moved to `InstallableValue`, the base `Installable` no longer depends on libexpr! This is a major step towards that. Also, add a bunch of doc comments for sake of the internal API docs.
2023-03-24	Merge pull request #7757 from obsidiansystems/more-installable-value	Eelco Dolstra
	Move value-only methods to `InstallableValue`
2023-03-23	Tweaks	Eelco Dolstra

2023-03-23	Document store URLs	Eelco Dolstra

2023-03-22	Merge pull request #8078 from obsidiansystems/profile-md	John Ericson
	Fix `nix profile --help`
2023-03-22	Improve store setting descriptions / Markdown formatting	Eelco Dolstra

2023-03-21	Add a "help" category	Eelco Dolstra
	This makes the help commands show up prominently at the top of the 'nix' manpage.
2023-03-21	Move store docs to 'nix help-stores'	Eelco Dolstra
	Why not 'nix help stores'? Well, 'nix help <arg>' already means 'show help on the "arg" subcommand'.
2023-03-21	Support per-store Markdown documentation	Eelco Dolstra

2023-03-21	nix describe-stores: Remove	Eelco Dolstra
	This command was intended for docs generation, but it was never used for that and we don't need it.
2023-03-21	nix store --help: Include store type documentation	Eelco Dolstra

2023-03-21	Fix misrendering of 'nix store --help'	Eelco Dolstra
	There are no categories underneath 'nix store', so having 'nix store copy-log' in a category rendered as ':'.
2023-03-20	Fix `nix profile --help`	John Ericson
	The documentation hadn't be updated to reflect the new default profile location.
2023-03-20	Fix handling of experimental features mid-parse	John Ericson
	If we conditionally "declare" the argument, as we did before, based upon weather the feature is enabled, commands like nix --experimental-features=foo ... --thing-gated-on-foo won't work, because the experimental feature isn't enabled until after we start parsing. Instead, allow arguments to also be associated with experimental features (just as we did for builtins and settings), and then the command line parser will filter out the experimental ones. Since the effects of arguments (handler functions) are performed right away, we get the required behavior: earlier arguments can enable later arguments enabled! There is just one catch: we want to keep non-positional flags...non-positional. So if nix --experimental-features=foo ... --thing-gated-on-foo works, then nix --thing-gated-on-foo --experimental-features=foo ... should also work. This is not my favorite long-term solution, but for now this is implemented by delaying the requirement of needed experimental features until after all the arguments have been parsed.
2023-03-20	Move enabled experimental feature to libutil struct	John Ericson
	This is needed in subsequent commits to allow the settings and CLI args infrastructure itself to read this setting.
2023-03-19	docs: quote URL literals	figsoda

2023-03-17	Merge pull request #7891 from mupdt/shared-fs-out-links	John Ericson
	no-op refactor: extract outLink generation into a function
2023-03-16	Move value-only methods to `InstallableValue`	John Ericson
	These methods would previously fail on the other `Installable`s, so moving them to this class is more correct as to where they actually work. Additionally, a `InstallableValueCommand` is created to make it easier (or rather no worse than before) to write commands that just work on `InstallableValue`s. Besides being a cleanup to avoid failing default methods, this gets us closer to https://github.com/NixOS/rfcs/pull/134.
2023-03-15	Merge pull request #7750 from obsidiansystems/no-args-prepare	John Ericson
	Make command infra less stateful and more regular
2023-03-15	Make command infra less stateful and more regular	John Ericson
	Already, we had classes like `BuiltPathsCommand` and `StorePathsCommand` which provided alternative `run` virtual functions providing the implementation with more arguments. This was a very nice and easy way to make writing command; just fill in the virtual functions and it is fairly clear what to do. However, exception to this pattern were `Installable{,s}Command`. These two classes instead just had a field where the installables would be stored, and various side-effecting `prepare` and `load` machinery too fill them in. Command would wish out those fields. This isn't so clear to use. What this commit does is make those command classes like the others, with richer `run` functions. Not only does this restore the pattern making commands easier to write, it has a number of other benefits: - `prepare` and `load` are gone entirely! One command just hands just hands off to the next. - `useDefaultInstallables` because `defaultInstallables`. This takes over `prepare` for the one case that needs it, and provides enough flexiblity to handle `nix repl`'s idiosyncratic migration. - We can use `ref` instead of `std::shared_ptr`. The former must be initialized (so it is like Rust's `Box` rather than `Option<Box>`, This expresses the invariant that the installable are in fact initialized much better. This is possible because since we just have local variables not fields, we can stop worrying about the not-yet-initialized case. - Fewer lines of code! (Finally I have a large refactor that makes the number go down not up...) - `nix repl` is now implemented in a clearer way. The last item deserves further mention. `nix repl` is not like the other installable commands because instead working from once-loaded installables, it needs to be able to load them again and again. To properly support this, we make a new superclass `RawInstallablesCommand`. This class has the argument parsing and completion logic, but does not hand off parsed installables but instead just the raw string arguments. This is exactly what `nix repl` needs, and allows us to instead of having the logic awkwardly split between `prepare`, `useDefaultInstallables,` and `load`, have everything right next to each other. I think this will enable future simplifications of that argument defaulting logic, but I am saving those for a future PR --- best to keep code motion and more complicated boolean expression rewriting separate steps. The "diagnostic ignored `-Woverloaded-virtual`" pragma helps because C++ doesn't like our many `run` methods. In our case, we don't mind the shadowing it all --- it is intentional that the derived class only provides a `run` method, and doesn't call any of the overridden `run` methods. Helps with https://github.com/NixOS/rfcs/pull/134
2023-03-16	nix-hash: support base-64 and SRI format	Yueh-Shun Li
	Add the --base64 and --sri flags for the Base64 and SRI format output. Add the --base16 flag to explicitly specify the hexadecimal format. Add the --to-base64 and --to-sri flag to convert a hash to the above mentioned format.
2023-03-12	print-dev-env: stop inadvertently adding . to PATH	lbodor

2023-03-06	no-op refactor: extract outLink generation into a function	mupdt

2023-03-06	output paths of store derivations are now addressed explicitly	Valentin Gagarin

2023-03-05	clarify definition of "installable"	Valentin Gagarin
	the term was hard to discover, as its definition and explanation were in a very long document lacking an overview section. search did not help because it occurs so often. - clarify wording in the definition - add an overview of installable types - add "installable" to glossary - link to definition from occurrences of the term - be more precise about where store derivation outputs are processed - installable Nix expressions must evaluate to a derivation Co-authored-by: Adam Joseph <54836058+amjoseph-nixpkgs@users.noreply.github.com>
2023-03-05	make descriptions of each installable type an own subsection	Valentin Gagarin
	this is easier to edit, provides anchors for free, and renders correctly on the terminal without additional effort.
2023-03-02	Remove FormatOrString and remaining uses of format()	Eelco Dolstra

2023-03-02	Get rid of some unchecked calls to std::cout	Eelco Dolstra

2023-03-02	nix store cat: Use writeFull()	Eelco Dolstra
	Fixes #7939.
2023-03-01	Merge pull request #7788 from ↵	Valentin Gagarin
	bobvanderlinden/pr-improve-nix-profile-install-error Improve error on conflict for nix profile install
2023-03-01	nix-profile: add FIXME about using C++20 std::ranges	Bob van der Linden

2023-02-28	nix-profile-install: show helpful error upon package conflict	Bob van der Linden
	Whenever a file conflict happens during "nix profile install" an error is shown that was previously thrown inside builtins.buildEnv. We catch BuildProfileConflictError here so that we can provide the user with more useful instructions on what to do next. Most notably, we give the user concrete commands to use with all parameters already filled in. This avoids the need for the user to look up these commands in manual pages.
2023-02-21	Merge pull request #7755 from obsidiansystems/mix-read-only-mode	Théophane Hufschmitt
	Make `--read-only` a separate mixin
2023-02-20	Merge pull request #7863 from obsidiansystems/test-derivation-to-json	Robert Hensing
	Move Derivation JSON printing logic to lib and test it
2023-02-20	Make `--read-only` a separate mixin	John Ericson
	It is independent of SourceExprCommand, which is about parsing installables, except for the fact that parsing installables is one of the many things influenced by read-only mode.
2023-02-20	Split out `CmdRepl` and `editorFor`	John Ericson
	The REPL itself and the `nix repl` CLI are conceptually different things, and thus deserve to be in different files.
2023-02-20	Split out `InstallableFlake` and `InstallableAttrPath`	John Ericson

2023-02-19	Move `Derivation` toJSON logic to libnixstore	John Ericson

2023-02-13	Merge pull request #7744 from obsidiansystems/split-installable-store-path	tomberek
	Factor out `InstallableStorePath` to its own file, dedup
2023-02-10	daemon.cc: Rename UserSettings -> AuthorizationSettings	Robert Hensing
	This is a bit more accurate. It's a private name, but before you know it, someone might make it public!
2023-02-04	Scope down `--derivation` to just the commands that use it	John Ericson
	Per the old FIXME, this flag was on too many commands, and mostly ignored. Now it is just on the commands where it actually has an effect. Per https://github.com/NixOS/nix/issues/7261, I would still like to get rid of it entirely, but that is a separate project. This change should be good with or without doing that.
2023-02-03	Factor out `InstallableStorePath` to its own file, dedup	John Ericson
	`nix app` had something called `InstallableDerivedPath` which is actually the same thing. We go with the later's name because it has become more correct. I originally did this change (more hurriedly) as part of #6225 --- a mini store-only Nix and a full Nix need to share this code. In the first RFC meeting for https://github.com/NixOS/rfcs/pull/134 we discussed how some splitting of the massive `installables.cc` could begin prior, as that is a good thing anyways. (@edolstra's words, not mine!) This would be one such PR.
2023-02-03	Merge pull request #7739 from obsidiansystems/user-settings	Eelco Dolstra
	Move `trustedUsers` and `allowedUsers` to separate config struct
2023-02-02	Move `trustedUsers` and `allowedUsers` to separate config struct	John Ericson
	These settings are not needed for libstore at all, they are just used by the nix daemon command for authorization on unix domain sockets. My moving them to a new configuration struct just in that file, we avoid them leaking anywhere else. Also, it is good to break up the mammoth `Settings` struct in general. Issue #5638 tracks this. The message is not changed because I do not want to regress in convenience to the user. Just saying "this connection is not trusted" doesn't tell them out to fix the issue. The ideal thing to do would be to somehow parameterize `processCommand` on how the error should be displayed, so different sorts of connections can display different information to the user based on how authentication is performed for the connection in question. This, however, is a good bit more work, so it is left for the future. This came up with me thinking about the tcp:// store (#5265). The larger project is not TCP per se, but the idea that it should be possible for something else to manage access control to services like the Nix Daemon, and those services simply trust or trust the incoming connection as they are told. This is a more capability-oriented way of thinking about trust than "every server implements its own auth separately" as we are used to today. Its very great that libstore itself already implements just this model, and so via this refactor I basically want to "enshrine" that so it continues to be the case.
2023-02-02	Get rid of the `authHook` parameter on `processConnection`	John Ericson
	This is (morally) dead code. As @edolstra pointed out in https://github.com/NixOS/nix/pull/5226#discussion_r1073470813, this is no longer needed. I created this in 8d4162ff9e940ea9e2f97b07f3030a722695901a, so it is fitting that I now destroy it :).