aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2020-06-18Fix bugsJohn Ericson
- Bad dynamic cast target ...classic - std::shared_ptr need explicit deref
2020-06-18Merge remote-tracking branch 'obsidian/fix-url-format' into ↵John Ericson
add-body-to-network-errors
2020-06-18Prevent '%' in URL from causing crashesJohn Ericson
We have a larger problem that passsing computed strings to the first variable argument of many exception constructors is unsafe because that first variable argument is interpreted not as a plain string, but format string, and if it contains '%' boost::format will abort, since there are no arguments to the format string. In this particular instance '%' was used as part of an escape code in a URL, which, when the download failed, caused Nix to abort displaying the `FileTransferError`.
2020-06-18Merge pull request #3709 from expipiplus1/masterEelco Dolstra
Mention number of derivations to be build/fetched in output
2020-06-18Adjust FileTransferError message to use opt responseJohn Ericson
2020-06-18Don't provide 'getFlake' if the 'flakes' feature is not enabledEelco Dolstra
(cherry picked from commit 0a1d3c1dd311f94e9d1f56e1aa7fe1ab34314ec1)
2020-06-18Some backports from the flakes branchEelco Dolstra
2020-06-18Make constant primops lazyEelco Dolstra
(cherry picked from commit aa0e2a2e70a3519a9dcb9b1da000a13c01aa6cc1)
2020-06-18Rename content-addressed-paths into ca-derivationsregnat
See <https://github.com/NixOS/nix/pull/3710#issuecomment-645480333>
2020-06-17Add HTTP responses to FileTransferErrorsCarlo Nucera
2020-06-17Replace `TransferItem::status` with a local variableCarlo Nucera
Everywhere seems to use `getHTTPStatus` now.
2020-06-17Create a new TeeSink abstractionCarlo Nucera
This is a bit complex because we want to expose extra functionality the wrapped class has. Perhaps there is some inheritancy trickery to do this nicer, but I don't know it, and this is the first thing we tried after a series of attempts that did build. This design is kind of like that of Rust's Writer, Reader, or Iter adapters, which impliment more traits based on what the inner type implements.
2020-06-17Eliminate old TeeSink abstractionCarlo Nucera
This was introduced in fa125b9b28bea25a4eeb4d39a71a481563127cb9, and then "reverted" in 1cf480110879ffc8aee94b4b75999da405b71d7c, except that revert left the struct around doing nothing useful. We're removing it all the way now because we want to make a new `TeeSink` complementing the already-exiting `TeeSource`, that is actually a completely different concept as far as the class hierarchy is concerned.
2020-06-17Merge pull request #3713 from matthewbauer/cleanup-warningsEelco Dolstra
Cleanup class StorePath warning
2020-06-17Merge pull request #3712 from ↵Eelco Dolstra
obsidiansystems/make-http-successful-states-coherent Make successful states coherent
2020-06-17Remove unused narInfoFile in binary-cache-storeMatthew Bauer
2020-06-17Replace struct StorePath with class StorePathMatthew Bauer
also a similar case with struct Goal
2020-06-17Include review commentsCarlo Nucera
2020-06-17Merge pull request #3710 from tweag/reserve_ca_derivationsEelco Dolstra
Reserve the `__contentAddressed` derivation parameter
2020-06-17Merge pull request #3707 from p01arst0rm/outdated-function-fixEelco Dolstra
replaced uncaught_exception with uncaught_exceptions
2020-06-17fixup! Reserve the `__contentAddressed` derivation parameterregnat
2020-06-17Make successful states coherentCarlo Nucera
The successful states used in these two places in the code were slightly different. Should they be the same list?
2020-06-17Use `ansicolor.hh` in `nix repl` rather than duplicatesJohn Ericson
2020-06-17Reserve the `__contentAddressed` derivation parameterregnat
Not implementing anything here, just throwing an error if a derivation sets `__contentAddressed = true` without `--experimental-features content-addressed-paths` (and also with it as there's nothing implemented yet)
2020-06-17Merge pull request #3657 from ↵Eelco Dolstra
obsidiansystems/sligthly-improve-store-path-documentation Clarify the description of StorePath inputs
2020-06-17Mention number of derivations to be build/fetched in outputJoe Hermaszewski
Also correct grammar for the case of a single derivation.
2020-06-17appended ' __attribute__((weak)); ' to 'extern char * * environ 'p01arst0rm
2020-06-17replaced uncaught_exception with uncaught_exceptionsp01arst0rm
2020-06-16Remove StorePath::clone() and related functionsEelco Dolstra
2020-06-16Merge pull request #3702 from NixOS/store-path-cxxEelco Dolstra
Rewrite StorePath class in C++
2020-06-16Add another missing #includeJohn Ericson
2020-06-16StorePath: Rewrite in C++Eelco Dolstra
On nix-env -qa -f '<nixpkgs>', this reduces maximum RSS by 20970 KiB and runtime by 0.8%. This is mostly because we're not parsing the hash part as a hash anymore (just validating that it consists of base-32 characters). Also, replace storePathToHash() by StorePath::hashPart().
2020-06-16Fix FTP supportEelco Dolstra
Fixes #3618.
2020-06-16Fix logging unit testsTobias Pflug
2020-06-15Add mising #include for strerrorJohn Ericson
2020-06-15Print only one error message if a build failsEelco Dolstra
E.g. instead of error: --- BuildError ----------------------------------------------- nix builder for '/nix/store/03nk0a3n8h2948k4lqfgnnmym7knkcma-foo.drv' failed with exit code 1 error: --- Error ---------------------------------------------------- nix build of '/nix/store/03nk0a3n8h2948k4lqfgnnmym7knkcma-foo.drv' failed we now get error: --- Error ---------------------------------------------------- nix builder for '/nix/store/03nk0a3n8h2948k4lqfgnnmym7knkcma-foo.drv' failed with exit code 1
2020-06-15Include only the base name of the program in error messagesEelco Dolstra
2020-06-15Respect terminal width printing error messagesEelco Dolstra
2020-06-15CleanupEelco Dolstra
2020-06-15Always hide the progress bar on exitEelco Dolstra
2020-06-15Remove unnecessary amDone() overridesEelco Dolstra
2020-06-15Give better error message about <...> in pure eval modeEelco Dolstra
2020-06-15Improve "waiting for locks" messagesEelco Dolstra
These are now shown in the progress bar. Closes #3577.
2020-06-15Remove trailing whitespaceEelco Dolstra
2020-06-15Get rid of explicit ErrorInfo constructorsEelco Dolstra
2020-06-15Disambiguate BaseError(Args) constructorEelco Dolstra
This means that 'throw Error({ ... ErrorInfo ... })' now works.
2020-06-15Merge branch 'errors-phase-2' of https://github.com/bburdette/nixEelco Dolstra
2020-06-12Use `std::string_view` in a few more placesJohn Ericson
2020-06-12Fix buildEelco Dolstra
2020-06-12Merge pull request #3674 from matthewbauer/allow-empty-hash2Eelco Dolstra
Allow empty hash in derivations
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 16:52:19 +0000