Age | Commit message (Collapse) | Author |
|
Closes #3256
|
|
Most functions now take a StorePath argument rather than a Path (which
is just an alias for std::string). The StorePath constructor ensures
that the path is syntactically correct (i.e. it looks like
<store-dir>/<base32-hash>-<name>). Similarly, functions like
buildPaths() now take a StorePathWithOutputs, rather than abusing Path
by adding a '!<outputs>' suffix.
Note that the StorePath type is implemented in Rust. This involves
some hackery to allow Rust values to be used directly in C++, via a
helper type whose destructor calls the Rust type's drop()
function. The main issue is the dynamic nature of C++ move semantics:
after we have moved a Rust value, we should not call the drop function
on the original value. So when we move a value, we set the original
value to bitwise zero, and the destructor only calls drop() if the
value is not bitwise zero. This should be sufficient for most types.
Also lots of minor cleanups to the C++ API to make it more modern
(e.g. using std::optional and std::string_view in some places).
|
|
The FunctionCallTrace object consumes a few hundred bytes of stack
space, even when tracing is disabled. This was causing stack overflows:
$ nix-instantiate '<nixpkgs> -A texlive.combined.scheme-full --dry-run
error: stack overflow (possible infinite recursion)
This is with the default stack size of 8 MiB.
Putting the object on the heap reduces stack usage to < 5 MiB.
|
|
This is no longer needed since we're not using POSIX locks anymore.
|
|
(cherry picked from commit 3392f1b77869269580b58e4931b7a79f44799ce0)
|
|
(cherry picked from commit 96c6b08ed7f99be84cb1816515a368392d19dbb5)
|
|
(cherry picked from commit 63c5c91cc053cbc1fcb8d3fe71c41142c9f51bfa)
|
|
(cherry picked from commit 8beedd44861d1fe7208609ee8d231ca1c02dedf6)
|
|
(cherry picked from commit fb692e5f7b34def8cf590298036ab63e40747062)
|
|
This allows writing attribute lookups as
if (auto name = value.attrs->get(state.sName))
...
(cherry picked from commit f216c76c56cdffb5214d074a7d44812843dd174f)
|
|
(cherry picked from commit d0a769cb061a13ad880c76e5ea69a76150439853)
|
|
(cherry picked from commit a0de58f471c9087d8e6cc60a6078f9940a125b15)
|
|
(cherry picked from commit f70434b1fbbdb0e188718f0c55a8156a7aa08744)
|
|
(cherry picked from commit 15a16e5c05d547ec07170df2392263e5e891447b)
|
|
|
|
This reverts commit 2b761d5f50b7dc17dc55c31980c2253c37b3c920.
Also *really* make fmt() take arguments by reference.
|
|
|
|
|
|
|
|
Make nix/unpack-channel.nix a builtin builder
|
|
Fixes #3246.
|
|
https://hydra.nixos.org/build/107467517
Seems that on i686-linux, gcc and rustc disagree on how to return
1-word structs: gcc has the caller pass a pointer to the result, while
rustc has the callee return the result in a register. Work around this
by using a bare pointer.
|
|
Also, fetchGit now runs in O(1) memory since we pipe the output of
'git archive' directly into unpackTarball() (rather than first reading
it all into memory).
|
|
|
|
|
|
We can now convert Rust Errors to C++ exceptions. At the Rust->C++ FFI
boundary, Result<T, Error> will cause Error to be converted to and
thrown as a C++ exception.
|
|
|
|
This was the last function using a shell script, so this allows us to
get rid of tar, coreutils, bash etc.
|
|
|
|
|
|
https://hydra.nixos.org/build/107457009
|
|
|
|
Downloader: Log configured CA file
|
|
Fix sandbox fallback settings
|
|
|
|
|
|
Ensure enough space in attrset bindings
|
|
Fixes #3239.
|
|
|
|
E.g.
$ nix-build '<nixpkgs>' -A hello --experimental-features no-url-literals
error: URL literals are disabled, at /nix/store/vsjamkzh15r3c779q2711az826hqgvzr-nixpkgs-20.03pre194957.bef773ed53f/nixpkgs/pkgs/top-level/all-packages.nix:1236:11
Helps with implementing https://github.com/NixOS/rfcs/pull/45.
|
|
dynamic attributes
|
|
This allows it to be set in nix.conf.
|
|
|
|
This allows distinguishing between an empty value and no value.
|
|
A corrupt entry in .links prevents adding a fixed version of that file
to the store in any path. The user experience is that corruption
present in the store 'spreads' to new paths added to the store:
(With store optimisation enabled)
1. A file in the store gets corrupted somehow (eg: filesystem bug).
2. The user tries to add a thing to the store which contains a good copy
of the corrupted file.
3. The file being added to the store is hashed, found to match the bad
.links entry, and is replaced by a link to the bad .links entry.
(The .links entry's hash is not verified during add -- this would
impose a substantial performance burden.)
4. The user observes that the thing in the store that is supposed to be
a copy of what they were trying to add is not a correct copy -- some
files have different contents! Running "nix-store --verify
--check-contents --repair" does not fix the problem.
This change makes "nix-store --verify --check-contents --repair" fix
this problem. Bad .links entries are simply removed, allowing future
attempts to insert a good copy of the file to succeed.
|
|
|
|
Fix extra semicolons warnings
|
|
Thanks @bhipple for catching!
|
|
|
|
|