aboutsummaryrefslogtreecommitdiff
path: root/tests/fetchGitRefs.sh
AgeCommit message (Collapse)Author
2020-06-17Merge remote-tracking branch 'origin/master' into flakesEelco Dolstra
2020-06-03update error grepBen Burdette
2020-06-03Merge remote-tracking branch 'origin/master' into flakesEelco Dolstra
2020-05-30Improve ref validity checking in fetchGitNikola Knezevic
The previous regex was too strict and did not match what git was allowing. It could lead to `fetchGit` not accepting valid branch names, even though they exist in a repository (for example, branch names containing `/`, which are pretty standard, like `release/1.0` branches). The new regex defines what a branch name should **NOT** contain. It takes the definitions from `refs.c` in https://github.com/git/git and `git help check-ref-format` pages. This change also introduces a test for ref name validity checking, which compares the result from Nix with the result of `git check-ref-format --branch`.