From 3a918014b248a41fe6307228d258b6113e84138b Mon Sep 17 00:00:00 2001 From: Andrew Dunham Date: Sat, 21 Apr 2018 21:10:52 -0700 Subject: Fix library ordering in Makefiles The existing ordering linked `libutil` before `libstore`, which causes link failures when building statically. This is due to `libstore` using functions from `libutil`, and the fact that symbol resolution works "forward" - i.e. if you pass `-lfoo -lbar -lbaz`, any symbols that `libbar` uses from `libbaz` will be resolved, but symbols from `libfoo` will not since it comes first in the command line. All this to say: this commit reorders the libraries which fixes the link errors. --- src/build-remote/local.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/build-remote') diff --git a/src/build-remote/local.mk b/src/build-remote/local.mk index 64368a43f..50b0409d1 100644 --- a/src/build-remote/local.mk +++ b/src/build-remote/local.mk @@ -4,6 +4,6 @@ build-remote_DIR := $(d) build-remote_INSTALL_DIR := $(libexecdir)/nix -build-remote_LIBS = libmain libutil libformat libstore +build-remote_LIBS = libmain libformat libstore libutil build-remote_SOURCES := $(d)/build-remote.cc -- cgit v1.2.3