From c03de0df627864fb7e83e9af88201b8a5fcd4930 Mon Sep 17 00:00:00 2001 From: Artemis Tosini Date: Fri, 29 Mar 2024 20:29:44 -0400 Subject: gc: Find roots using libproc on Darwin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, the garbage collector found runtime roots on Darwin by shelling out to `lsof -n -w -F n` then parsing the result. However, this requires an lsof binary and can be extremely slow. The official Apple lsof returns in a reasonable amount of time, about 250ms in my tests, but the lsof packaged in nixpkgs is quite slow, taking about 40 seconds to run the command. Using libproc directly is about the same speed as Apple lsof, and allows us to reënable several tests that were disabled on Darwin. Change-Id: Ifa0adda7984e13c15535693baba835aae79a3577 --- src/libstore/meson.build | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/libstore/meson.build') diff --git a/src/libstore/meson.build b/src/libstore/meson.build index 94471dc29..5fde92dd0 100644 --- a/src/libstore/meson.build +++ b/src/libstore/meson.build @@ -162,6 +162,9 @@ libstore_headers = files( if host_machine.system() == 'linux' libstore_sources += files('platform/linux.cc') libstore_headers += files('platform/linux.hh') +elif host_machine.system() == 'darwin' + libstore_sources += files('platform/darwin.cc') + libstore_headers += files('platform/darwin.hh') else libstore_sources += files('platform/fallback.cc') libstore_headers += files('platform/fallback.hh') -- cgit v1.2.3