From 292567e0b0a4681eb8ca803c26293d70857fe387 Mon Sep 17 00:00:00 2001 From: Jade Lovelace Date: Sat, 10 Aug 2024 16:02:42 -0700 Subject: fix: check if it is a Real terminal, not just if it is a terminal This will stop printing stuff to dumb terminals that they don't support. I've overall audited usage of isatty and replaced the ones with intent to mean "is a Real terminal" with checking for that. I've also caught a case of carelessly assuming "is a tty" means "should be colour" in nix-env. Change-Id: I6d83725d9a2d932ac94ff2294f92c0a1100d23c9 --- src/nix/main.cc | 1 + 1 file changed, 1 insertion(+) (limited to 'src/nix/main.cc') diff --git a/src/nix/main.cc b/src/nix/main.cc index 1c1e9df7e..9cbe303ac 100644 --- a/src/nix/main.cc +++ b/src/nix/main.cc @@ -362,6 +362,7 @@ void mainWrapped(int argc, char * * argv) setLogFormat(LogFormat::bar); Finally f([] { logger->pause(); }); settings.verboseBuild = false; + // FIXME: stop messing about with log verbosity depending on if it is interactive use if (isatty(STDERR_FILENO)) { verbosity = lvlNotice; } else { -- cgit v1.2.3