From 30dcc19d1f30fc203be460134c4578509cce704f Mon Sep 17 00:00:00 2001 From: John Ericson Date: Thu, 5 Oct 2023 12:12:18 -0400 Subject: Put functional tests in `tests/functional` I think it is bad for these reasons when `tests/` contains a mix of functional and integration tests - Concepts is harder to understand, the documentation makes a good unit vs functional vs integration distinction, but when the integration tests are just two subdirs within `tests/` this is not clear. - Source filtering in the `flake.nix` is more complex. We need to filter out some of the dirs from `tests/`, rather than simply pick the dirs we want and take all of them. This is a good sign the structure of what we are trying to do is not matching the structure of the files. With this change we have a clean: ```shell-session $ git show 'HEAD:tests' tree HEAD:tests functional/ installer/ nixos/ ``` (cherry picked from commit 68c81c737571794f7246db53fb4774e94fcf4b7e) --- tests/lang/eval-fail-to-path.err.exp | 14 -------------- 1 file changed, 14 deletions(-) delete mode 100644 tests/lang/eval-fail-to-path.err.exp (limited to 'tests/lang/eval-fail-to-path.err.exp') diff --git a/tests/lang/eval-fail-to-path.err.exp b/tests/lang/eval-fail-to-path.err.exp deleted file mode 100644 index 43ed2bdfc..000000000 --- a/tests/lang/eval-fail-to-path.err.exp +++ /dev/null @@ -1,14 +0,0 @@ -error: - … while calling the 'toPath' builtin - - at /pwd/lang/eval-fail-to-path.nix:1:1: - - 1| builtins.toPath "foo/bar" - | ^ - 2| - - … while evaluating the first argument passed to builtins.toPath - - at «none»:0: (source not available) - - error: string 'foo/bar' doesn't represent an absolute path -- cgit v1.2.3