aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThéophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>2023-04-03 14:02:45 +0200
committerGitHub <noreply@github.com>2023-04-03 14:02:45 +0200
commit70bb7b72890b962d644411a6f74f8002033b7b5d (patch)
treeb492ff47f86f5bbf3995efc0f5618ddd1184786b
parenta06ea8db77c5d4b0b6add9b9a8a10fb970418dee (diff)
parent7c4dea3cf3ef8cc0185163e69d9f3cb3a0fc95ac (diff)
Merge pull request #7610 from obsidiansystems/gate-default-settings
Punt on improper global flags for now
-rw-r--r--src/nix/main.cc3
-rw-r--r--tests/experimental-features.sh12
2 files changed, 15 insertions, 0 deletions
diff --git a/src/nix/main.cc b/src/nix/main.cc
index 54c920b4e..c2e1dda74 100644
--- a/src/nix/main.cc
+++ b/src/nix/main.cc
@@ -83,6 +83,7 @@ struct NixArgs : virtual MultiCommand, virtual MixCommonArgs
.description = "Print full build logs on standard error.",
.category = loggingCategory,
.handler = {[&]() { logger->setPrintBuildLogs(true); }},
+ .experimentalFeature = Xp::NixCommand,
});
addFlag({
@@ -98,6 +99,7 @@ struct NixArgs : virtual MultiCommand, virtual MixCommonArgs
.description = "Disable substituters and consider all previously downloaded files up-to-date.",
.category = miscCategory,
.handler = {[&]() { useNet = false; }},
+ .experimentalFeature = Xp::NixCommand,
});
addFlag({
@@ -105,6 +107,7 @@ struct NixArgs : virtual MultiCommand, virtual MixCommonArgs
.description = "Consider all previously downloaded files out-of-date.",
.category = miscCategory,
.handler = {[&]() { refresh = true; }},
+ .experimentalFeature = Xp::NixCommand,
});
}
diff --git a/tests/experimental-features.sh b/tests/experimental-features.sh
index 3be77d5cc..f718585f3 100644
--- a/tests/experimental-features.sh
+++ b/tests/experimental-features.sh
@@ -21,3 +21,15 @@ both_ways store gc --help
expect 1 nix --experimental-features 'nix-command' show-config --flake-registry 'https://no'
nix --experimental-features 'nix-command flakes' show-config --flake-registry 'https://no'
+
+# Double check this is stable
+nix --experimental-features '' --help
+
+# These 3 arguments are currently given to all commands, which is wrong (as not
+# all care). To deal with fixing later, we simply make them require the
+# nix-command experimental features --- it so happens that the commands we wish
+# stabilizing to do not need them anyways.
+for arg in '--print-build-logs' '--offline' '--refresh'; do
+ nix --experimental-features 'nix-command' "$arg" --help
+ ! nix --experimental-features '' "$arg" --help
+done