aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShea Levy <shea@shealevy.com>2014-02-19 07:05:15 -0500
committerEelco Dolstra <eelco.dolstra@logicblox.com>2014-02-26 13:32:47 +0100
commitdf5de9dfd72f9dc3d57157d0496443732a517491 (patch)
tree9b0e0e0ea4c2c72bf148b13d8fb1e19c79a2e686
parent36b90e72d7e09b983acfa08f9016e8b3ece5199d (diff)
Add use-ssh-substituter setting.
It defaults to false and can be overridden by RemoteStore. Untested currently, just quickly put this together
-rw-r--r--src/download-via-ssh/download-via-ssh.cc12
-rw-r--r--src/libstore/globals.cc2
-rw-r--r--src/libstore/globals.hh3
3 files changed, 17 insertions, 0 deletions
diff --git a/src/download-via-ssh/download-via-ssh.cc b/src/download-via-ssh/download-via-ssh.cc
index 6361e71e9..b5350f998 100644
--- a/src/download-via-ssh/download-via-ssh.cc
+++ b/src/download-via-ssh/download-via-ssh.cc
@@ -111,6 +111,18 @@ void run(Strings args)
if (args.empty())
throw UsageError("download-via-ssh requires an argument");
+ Settings::SettingsMap overrides = settings.getOverrides();
+ Settings::SettingsMap::iterator use = overrides.find("untrusted-use-ssh-substituter");
+ if (use != overrides.end()) {
+ if (use->second == "true") settings.useSshSubstituter = true;
+ else if (use->second == "false") settings.useSshSubstituter = false;
+ else throw Error(format("configuration option `use-ssh-substituter' should be either `true' or `false', not `%1%'")
+ % use->second);
+ }
+
+ if (!settings.useSshSubstituter)
+ return;
+
if (settings.sshSubstituterHosts.empty())
return;
diff --git a/src/libstore/globals.cc b/src/libstore/globals.cc
index 40000c9db..f9007775a 100644
--- a/src/libstore/globals.cc
+++ b/src/libstore/globals.cc
@@ -41,6 +41,7 @@ Settings::Settings()
syncBeforeRegistering = false;
useSubstitutes = true;
useChroot = false;
+ useSshSubstituter = false;
dirsInChroot.insert("/dev");
dirsInChroot.insert("/dev/pts");
impersonateLinux26 = false;
@@ -153,6 +154,7 @@ void Settings::update()
get(autoOptimiseStore, "auto-optimise-store");
get(envKeepDerivations, "env-keep-derivations");
get(sshSubstituterHosts, "ssh-substituter-hosts");
+ get(useSshSubstituter, "use-ssh-substituter");
}
diff --git a/src/libstore/globals.hh b/src/libstore/globals.hh
index 31324478b..711c36529 100644
--- a/src/libstore/globals.hh
+++ b/src/libstore/globals.hh
@@ -149,6 +149,9 @@ struct Settings {
/* Set of ssh connection strings for the ssh substituter */
Strings sshSubstituterHosts;
+ /* Whether to use the ssh substituter at all */
+ bool useSshSubstituter;
+
/* Whether to impersonate a Linux 2.6 machine on newer kernels. */
bool impersonateLinux26;