aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCole Helbling <cole.e.helbling@outlook.com>2023-09-20 09:09:01 -0700
committergithub-actions[bot] <github-actions[bot]@users.noreply.github.com>2023-09-20 17:03:47 +0000
commitf3005632c417615d2cf3a6d102d0f4f041d8b2b7 (patch)
tree6c4116d254e9b0323b5d0db1abd62793273da234
parent40a014416b245273e2d5ab50a372cd9468d63cb9 (diff)
Re-enable systemd-nspawn test
It was disabled in c6953d1ff62fb6dc4fbd89c03e7949c552c19382 because a recent Nixpkgs bump brought in a new systemd which changed how systemd-nspawn worked. As far as I can tell, the issue was caused by this upstream systemd commit: https://github.com/systemd/systemd/commit/b71a0192c040f585397cfc6fc2ca025bf839733d Bind-mounting the host's `/sys` and `/proc` into the container's `/run/host/{sys,proc}` fixes the issue and allows the test to succeed. (cherry picked from commit 883092e3f78d4efb1066a2e24e343b307035a04c)
-rw-r--r--tests/nixos/containers/containers.nix4
-rw-r--r--tests/nixos/containers/systemd-nspawn.nix2
2 files changed, 4 insertions, 2 deletions
diff --git a/tests/nixos/containers/containers.nix b/tests/nixos/containers/containers.nix
index e721be48f..c8ee78a4a 100644
--- a/tests/nixos/containers/containers.nix
+++ b/tests/nixos/containers/containers.nix
@@ -56,8 +56,8 @@
host.fail("nix build -v --auto-allocate-uids --no-sandbox -L --offline --impure --file ${./id-test.nix} --argstr name id-test-6 --arg uidRange true")
# Run systemd-nspawn in a Nix build.
- #host.succeed("nix build -v --auto-allocate-uids --sandbox -L --offline --impure --file ${./systemd-nspawn.nix} --argstr nixpkgs ${nixpkgs}")
- #host.succeed("[[ $(cat ./result/msg) = 'Hello World' ]]")
+ host.succeed("nix build -v --auto-allocate-uids --sandbox -L --offline --impure --file ${./systemd-nspawn.nix} --argstr nixpkgs ${nixpkgs}")
+ host.succeed("[[ $(cat ./result/msg) = 'Hello World' ]]")
'';
}
diff --git a/tests/nixos/containers/systemd-nspawn.nix b/tests/nixos/containers/systemd-nspawn.nix
index f54f32f2a..1dad4ebd7 100644
--- a/tests/nixos/containers/systemd-nspawn.nix
+++ b/tests/nixos/containers/systemd-nspawn.nix
@@ -73,6 +73,8 @@ runCommand "test"
--resolv-conf=off \
--bind-ro=/nix/store \
--bind=$out \
+ --bind=/proc:/run/host/proc \
+ --bind=/sys:/run/host/sys \
--private-network \
$toplevel/init
''