aboutsummaryrefslogtreecommitdiff
path: root/misc
diff options
context:
space:
mode:
authorJohn Ericson <John.Ericson@Obsidian.Systems>2023-01-16 19:13:31 -0500
committerJohn Ericson <John.Ericson@Obsidian.Systems>2023-03-20 11:35:34 -0400
commit4607ac7aed34b1bc2d7a74bff99c63f3bd684511 (patch)
tree0f72b21b003d7dfd43e77c5569040fd37b5edfac /misc
parentaa663b7e89d3d02248d37ee9f68b52770b247018 (diff)
Fix handling of experimental features mid-parse
If we conditionally "declare" the argument, as we did before, based upon weather the feature is enabled, commands like nix --experimental-features=foo ... --thing-gated-on-foo won't work, because the experimental feature isn't enabled until *after* we start parsing. Instead, allow arguments to also be associated with experimental features (just as we did for builtins and settings), and then the command line parser will filter out the experimental ones. Since the effects of arguments (handler functions) are performed right away, we get the required behavior: earlier arguments can enable later arguments enabled! There is just one catch: we want to keep non-positional flags...non-positional. So if nix --experimental-features=foo ... --thing-gated-on-foo works, then nix --thing-gated-on-foo --experimental-features=foo ... should also work. This is not my favorite long-term solution, but for now this is implemented by delaying the requirement of needed experimental features until *after* all the arguments have been parsed.
Diffstat (limited to 'misc')
0 files changed, 0 insertions, 0 deletions