aboutsummaryrefslogtreecommitdiff
path: root/src/build-remote
diff options
context:
space:
mode:
authorShea Levy <shea@shealevy.com>2021-01-28 09:37:43 -0500
committerShea Levy <shea@shealevy.com>2021-02-24 08:22:17 -0500
commit98d1b64400cc7b75216fc885859883c707c18bef (patch)
tree81b82449977fd5ef0b9c01b38c15666458d567a5 /src/build-remote
parentec3497c1d63f4c0547d0402d92015f846f56aac7 (diff)
Initialize plugins after handling initial command line flags
This is technically a breaking change, since attempting to set plugin files after the first non-flag argument will now throw an error. This is acceptable given the relative lack of stability in a plugin interface and the need to tie the knot somewhere once plugins can actually define new subcommands.
Diffstat (limited to 'src/build-remote')
-rw-r--r--src/build-remote/build-remote.cc3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/build-remote/build-remote.cc b/src/build-remote/build-remote.cc
index 5b8ab3387..f784b5160 100644
--- a/src/build-remote/build-remote.cc
+++ b/src/build-remote/build-remote.cc
@@ -53,6 +53,9 @@ static int main_build_remote(int argc, char * * argv)
unsetenv("DISPLAY");
unsetenv("SSH_ASKPASS");
+ /* If we ever use the common args framework, make sure to
+ remove initPlugins below and initialize settings first.
+ */
if (argc != 2)
throw UsageError("called without required arguments");