diff options
| author | John Ericson <John.Ericson@Obsidian.Systems> | 2023-02-04 18:27:17 -0500 |
|---|---|---|
| committer | John Ericson <John.Ericson@Obsidian.Systems> | 2023-02-04 18:30:02 -0500 |
| commit | 44bea52ae3ca9569250eb1f50100f2c3260cc688 (patch) | |
| tree | 0a9fed384c25d9b6922ef391c83782bbf2b2f96b /src/libcmd/command.hh | |
| parent | 6352e20bc8dba9477e25eedbe7bea91cbe1614f9 (diff) | |
Scope down `--derivation` to just the commands that use it
Per the old FIXME, this flag was on too many commands, and mostly
ignored. Now it is just on the commands where it actually has an effect.
Per https://github.com/NixOS/nix/issues/7261, I would still like to get
rid of it entirely, but that is a separate project. This change should
be good with or without doing that.
Diffstat (limited to 'src/libcmd/command.hh')
| -rw-r--r-- | src/libcmd/command.hh | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/libcmd/command.hh b/src/libcmd/command.hh index 3b4b40981..d16bdbc4b 100644 --- a/src/libcmd/command.hh +++ b/src/libcmd/command.hh @@ -96,9 +96,6 @@ struct SourceExprCommand : virtual Args, MixFlakeOptions std::optional<std::string> expr; bool readOnlyMode = false; - // FIXME: move this; not all commands (e.g. 'nix run') use it. - OperateOn operateOn = OperateOn::Output; - SourceExprCommand(bool supportReadOnlyMode = false); std::vector<std::shared_ptr<Installable>> parseInstallables( @@ -153,8 +150,15 @@ private: std::string _installable{"."}; }; +struct MixOperateOnOptions : virtual Args +{ + OperateOn operateOn = OperateOn::Output; + + MixOperateOnOptions(); +}; + /* A command that operates on zero or more store paths. */ -struct BuiltPathsCommand : public InstallablesCommand +struct BuiltPathsCommand : InstallablesCommand, virtual MixOperateOnOptions { private: |