diff options
| author | Robert Hensing <robert@roberthensing.nl> | 2021-08-29 18:09:13 +0200 |
|---|---|---|
| committer | Robert Hensing <robert@roberthensing.nl> | 2021-08-29 18:11:58 +0200 |
| commit | f10465774fafaa2423cb05e02b38e03ed2abded7 (patch) | |
| tree | ce3c4e35b59ac3ad24c44b65d50ddd041fe70fcf /src/libexpr/value-to-xml.cc | |
| parent | af94b54db3a2be100731a215cb5e95f306471731 (diff) | |
Force all Pos* to be non-null
This fixes a class of crashes and introduces ptr<T> to make the
code robust against this failure mode going forward.
Thanks regnat for the idea of a ref<T> without overhead!
Closes #4895
Closes #4893
Closes #5127
Closes #5113
Diffstat (limited to 'src/libexpr/value-to-xml.cc')
| -rw-r--r-- | src/libexpr/value-to-xml.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libexpr/value-to-xml.cc b/src/libexpr/value-to-xml.cc index 7464455d8..2ddc5f751 100644 --- a/src/libexpr/value-to-xml.cc +++ b/src/libexpr/value-to-xml.cc @@ -42,7 +42,7 @@ static void showAttrs(EvalState & state, bool strict, bool location, XMLAttrs xmlAttrs; xmlAttrs["name"] = i; - if (location && a.pos != &noPos) posToXML(xmlAttrs, *a.pos); + if (location && a.pos != ptr(&noPos)) posToXML(xmlAttrs, *a.pos); XMLOpenElement _(doc, "attr", xmlAttrs); printValueAsXML(state, strict, location, |